basic/source/inc/filefmt.hxx | 2 --
sc/source/core/inc/addinlis.hxx | 2 +-
sc/source/core/inc/adiasync.hxx | 2 +-
sc/source/core/inc/ddelink.hxx | 2 +-
sc/source/core/inc/doubleref.hxx | 4 ++--
sc/source/core/inc/formulagroupcl.hxx | 2 +-
sc/source/core/inc/poolhelp.hxx | 2 +-
sc/source/core/inc/webservicelink.hxx | 2 +-
sc/source/ui/inc/cellsh.hxx | 2 +-
sc/source/ui/inc/chartsh.hxx | 3 +--
sc/source/ui/inc/client.hxx | 2 +-
sc/source/ui/inc/docfunc.hxx | 2 +-
sc/source/ui/inc/drformsh.hxx | 2 +-
sc/source/ui/inc/drtxtob.hxx | 2 +-
sc/source/ui/inc/drwtrans.hxx | 2 +-
sc/source/ui/inc/editsh.hxx | 2 +-
sc/source/ui/inc/graphsh.hxx | 2 +-
sc/source/ui/inc/mediash.hxx | 2 +-
sc/source/ui/inc/msgpool.hxx | 4 ++--
sc/source/ui/inc/oleobjsh.hxx | 2 +-
sc/source/ui/inc/pgbrksh.hxx | 2 +-
sc/source/ui/inc/pivotsh.hxx | 2 +-
sc/source/ui/inc/prevwsh.hxx | 3 +--
23 files changed, 24 insertions(+), 28 deletions(-)
New commits:
commit f6a38df16cb2749f007a644db3d0dee829960114
Author: Arnaud Versini <arnaud.vers...@libreoffice.org>
AuthorDate: Sun Jan 31 13:52:33 2021 +0100
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Feb 1 07:27:41 2021 +0100
basic : remove useless class pre declaration
Change-Id: Iba78fb4d28651b298ed6ec5e53b30b2afebb28a6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110203
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/basic/source/inc/filefmt.hxx b/basic/source/inc/filefmt.hxx
index f6cc8e1fe88f..3460b1abbd7f 100644
--- a/basic/source/inc/filefmt.hxx
+++ b/basic/source/inc/filefmt.hxx
@@ -19,8 +19,6 @@
#pragma once
-class SvStream;
-
// Version 2: data type of the return value for publics
// Version 3: new opcodes
// Version 4: new opcodes
commit e65b1480426667622335aeb2e2413d3d8703a273
Author: Noel <noel.gran...@collabora.co.uk>
AuthorDate: Fri Jan 29 09:57:09 2021 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Feb 1 07:27:34 2021 +0100
loplugin:finalclasses in sc
Change-Id: Iac689d15effa08dd6216d275ad5294471e48f1b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110155
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/sc/source/core/inc/addinlis.hxx b/sc/source/core/inc/addinlis.hxx
index 612ed992d133..ea83de408e68 100644
--- a/sc/source/core/inc/addinlis.hxx
+++ b/sc/source/core/inc/addinlis.hxx
@@ -31,7 +31,7 @@ namespace rtl { template <class reference_type> class
Reference; }
class ScDocument;
-class ScAddInListener : public cppu::WeakImplHelper<
+class ScAddInListener final : public cppu::WeakImplHelper<
css::sheet::XResultListener,
css::lang::XServiceInfo >,
public SvtBroadcaster
diff --git a/sc/source/core/inc/adiasync.hxx b/sc/source/core/inc/adiasync.hxx
index bc0a22ee3315..1fd3dd4334cc 100644
--- a/sc/source/core/inc/adiasync.hxx
+++ b/sc/source/core/inc/adiasync.hxx
@@ -33,7 +33,7 @@ void CALLTYPE ScAddInAsyncCallBack( double& nHandle, void*
pData );
class ScDocument;
using ScAddInDocs = std::set<ScDocument*>;
-class ScAddInAsync : public SvtBroadcaster
+class ScAddInAsync final : public SvtBroadcaster
{
private:
union
diff --git a/sc/source/core/inc/ddelink.hxx b/sc/source/core/inc/ddelink.hxx
index 548fd7e0fd03..47cf54475a3a 100644
--- a/sc/source/core/inc/ddelink.hxx
+++ b/sc/source/core/inc/ddelink.hxx
@@ -31,7 +31,7 @@ class ScMultipleReadHeader;
class ScMultipleWriteHeader;
class SvStream;
-class ScDdeLink : public ::sfx2::SvBaseLink, public SvtBroadcaster
+class ScDdeLink final : public ::sfx2::SvBaseLink, public SvtBroadcaster
{
private:
static bool bIsInUpdate;
diff --git a/sc/source/core/inc/doubleref.hxx b/sc/source/core/inc/doubleref.hxx
index 621bb2e6ba66..15e30f444404 100644
--- a/sc/source/core/inc/doubleref.hxx
+++ b/sc/source/core/inc/doubleref.hxx
@@ -89,7 +89,7 @@ private:
ScDocument* mpDoc;
};
-class ScDBInternalRange : public ScDBRangeBase
+class ScDBInternalRange final : public ScDBRangeBase
{
public:
explicit ScDBInternalRange(ScDocument* pDoc, const ScRange& rRange);
@@ -132,7 +132,7 @@ private:
ScRange maRange;
};
-class ScDBExternalRange : public ScDBRangeBase
+class ScDBExternalRange final : public ScDBRangeBase
{
public:
explicit ScDBExternalRange(ScDocument* pDoc, const ScMatrixRef& pMat);
diff --git a/sc/source/core/inc/formulagroupcl.hxx
b/sc/source/core/inc/formulagroupcl.hxx
index 0e5eb9ee9147..a9853f35b0d9 100644
--- a/sc/source/core/inc/formulagroupcl.hxx
+++ b/sc/source/core/inc/formulagroupcl.hxx
@@ -14,7 +14,7 @@
namespace sc::opencl {
-class FormulaGroupInterpreterOpenCL : public FormulaGroupInterpreter
+class FormulaGroupInterpreterOpenCL final : public FormulaGroupInterpreter
{
public:
FormulaGroupInterpreterOpenCL();
diff --git a/sc/source/core/inc/poolhelp.hxx b/sc/source/core/inc/poolhelp.hxx
index 23fa529f7088..66a729ad49ea 100644
--- a/sc/source/core/inc/poolhelp.hxx
+++ b/sc/source/core/inc/poolhelp.hxx
@@ -31,7 +31,7 @@ class ScStyleSheetPool;
class SvNumberFormatter;
class SfxItemPool;
-class ScPoolHelper : public salhelper::SimpleReferenceObject
+class ScPoolHelper final : public salhelper::SimpleReferenceObject
{
private:
mutable osl::Mutex maMtxCreateNumFormatter;
diff --git a/sc/source/core/inc/webservicelink.hxx
b/sc/source/core/inc/webservicelink.hxx
index 2bcc64f8c268..59f58f2f82ef 100644
--- a/sc/source/core/inc/webservicelink.hxx
+++ b/sc/source/core/inc/webservicelink.hxx
@@ -20,7 +20,7 @@ class Any;
class ScDocument;
-class ScWebServiceLink : public ::sfx2::SvBaseLink, public SvtBroadcaster
+class ScWebServiceLink final : public ::sfx2::SvBaseLink, public SvtBroadcaster
{
private:
ScDocument* pDoc;
diff --git a/sc/source/ui/inc/cellsh.hxx b/sc/source/ui/inc/cellsh.hxx
index 837923fb4e20..1c0592057bb3 100644
--- a/sc/source/ui/inc/cellsh.hxx
+++ b/sc/source/ui/inc/cellsh.hxx
@@ -48,7 +48,7 @@ struct CellShell_Impl
~CellShell_Impl();
};
-class ScCellShell: public ScFormatShell
+class ScCellShell final : public ScFormatShell
{
private:
std::unique_ptr<CellShell_Impl> pImpl;
diff --git a/sc/source/ui/inc/chartsh.hxx b/sc/source/ui/inc/chartsh.hxx
index 44000af245da..e13cddf22012 100644
--- a/sc/source/ui/inc/chartsh.hxx
+++ b/sc/source/ui/inc/chartsh.hxx
@@ -27,7 +27,7 @@ class ScViewData;
#include "drawsh.hxx"
-class ScChartShell : public ScDrawShell
+class ScChartShell final : public ScDrawShell
{
public:
SFX_DECL_INTERFACE(SCID_CHART_SHELL)
@@ -36,7 +36,6 @@ private:
/// SfxInterface initializer.
static void InitInterface_Impl();
-protected:
virtual void Activate(bool bMDI) override;
virtual void Deactivate(bool bMDI) override;
diff --git a/sc/source/ui/inc/client.hxx b/sc/source/ui/inc/client.hxx
index 38c02103e329..0b2bd9fe98c2 100644
--- a/sc/source/ui/inc/client.hxx
+++ b/sc/source/ui/inc/client.hxx
@@ -26,7 +26,7 @@ class ScTabViewShell;
class SdrOle2Obj;
class SdrModel;
-class ScClient : public SfxInPlaceClient
+class ScClient final : public SfxInPlaceClient
{
private:
SdrModel* pModel;
diff --git a/sc/source/ui/inc/docfunc.hxx b/sc/source/ui/inc/docfunc.hxx
index 411abc10496e..1cf8c394437a 100644
--- a/sc/source/ui/inc/docfunc.hxx
+++ b/sc/source/ui/inc/docfunc.hxx
@@ -238,7 +238,7 @@ private:
void ProtectDocument(const ScDocProtection& rProtect);
};
-class ScDocFuncDirect : public ScDocFunc
+class ScDocFuncDirect final : public ScDocFunc
{
public:
ScDocFuncDirect( ScDocShell& rDocSh ) : ScDocFunc( rDocSh ) {}
diff --git a/sc/source/ui/inc/drformsh.hxx b/sc/source/ui/inc/drformsh.hxx
index ec335b2e516a..0d20d4dbd939 100644
--- a/sc/source/ui/inc/drformsh.hxx
+++ b/sc/source/ui/inc/drformsh.hxx
@@ -28,7 +28,7 @@ class SfxModule;
#include "drawsh.hxx"
-class ScDrawFormShell : public ScDrawShell
+class ScDrawFormShell final : public ScDrawShell
{
public:
SFX_DECL_INTERFACE(SCID_FORM_SHELL)
diff --git a/sc/source/ui/inc/drtxtob.hxx b/sc/source/ui/inc/drtxtob.hxx
index b83c03fb218b..a5b25e12e692 100644
--- a/sc/source/ui/inc/drtxtob.hxx
+++ b/sc/source/ui/inc/drtxtob.hxx
@@ -33,7 +33,7 @@ class ScViewData;
class TransferableDataHelper;
class TransferableClipboardListener;
-class ScDrawTextObjectBar : public SfxShell
+class ScDrawTextObjectBar final : public SfxShell
{
ScViewData& mrViewData;
rtl::Reference<TransferableClipboardListener> mxClipEvtLstnr;
diff --git a/sc/source/ui/inc/drwtrans.hxx b/sc/source/ui/inc/drwtrans.hxx
index bfb5175738dc..8854b62546bc 100644
--- a/sc/source/ui/inc/drwtrans.hxx
+++ b/sc/source/ui/inc/drwtrans.hxx
@@ -35,7 +35,7 @@ class ScDrawView;
class SdrOle2Obj;
enum class ScDragSrc;
-class ScDrawTransferObj : public TransferDataContainer
+class ScDrawTransferObj final : public TransferDataContainer
{
private:
std::unique_ptr<SdrModel> m_pModel;
diff --git a/sc/source/ui/inc/editsh.hxx b/sc/source/ui/inc/editsh.hxx
index e6c69f1489de..0a52dc3c02e9 100644
--- a/sc/source/ui/inc/editsh.hxx
+++ b/sc/source/ui/inc/editsh.hxx
@@ -34,7 +34,7 @@ class SvxURLField;
class TransferableDataHelper;
class TransferableClipboardListener;
-class ScEditShell : public SfxShell
+class ScEditShell final : public SfxShell
{
private:
EditView* pEditView;
diff --git a/sc/source/ui/inc/graphsh.hxx b/sc/source/ui/inc/graphsh.hxx
index df854eedd0ef..23c7122c9369 100644
--- a/sc/source/ui/inc/graphsh.hxx
+++ b/sc/source/ui/inc/graphsh.hxx
@@ -31,7 +31,7 @@ class SfxModule;
#include "drawsh.hxx"
-class ScGraphicShell: public ScDrawShell
+class ScGraphicShell final : public ScDrawShell
{
public:
SFX_DECL_INTERFACE(SCID_GRAPHIC_SHELL)
diff --git a/sc/source/ui/inc/mediash.hxx b/sc/source/ui/inc/mediash.hxx
index c5ea643f2617..31c55ef4c12b 100644
--- a/sc/source/ui/inc/mediash.hxx
+++ b/sc/source/ui/inc/mediash.hxx
@@ -28,7 +28,7 @@ class SfxModule;
#include "drawsh.hxx"
-class ScMediaShell : public ScDrawShell
+class ScMediaShell final : public ScDrawShell
{
public:
SFX_DECL_INTERFACE(SCID_MEDIA_SHELL)
diff --git a/sc/source/ui/inc/msgpool.hxx b/sc/source/ui/inc/msgpool.hxx
index 974b267e141a..d5f68b217bd0 100644
--- a/sc/source/ui/inc/msgpool.hxx
+++ b/sc/source/ui/inc/msgpool.hxx
@@ -30,7 +30,7 @@
class ScDocumentPool;
-class ScMessagePool: public SfxItemPool
+class ScMessagePool final : public SfxItemPool
{
SfxStringItem aGlobalStringItem;
SvxSearchItem aGlobalSearchItem;
@@ -48,7 +48,7 @@ class ScMessagePool: public SfxItemPool
public:
ScMessagePool();
-protected:
+private:
virtual ~ScMessagePool() override;
public:
diff --git a/sc/source/ui/inc/oleobjsh.hxx b/sc/source/ui/inc/oleobjsh.hxx
index 8b15c15c9486..cba751da6bce 100644
--- a/sc/source/ui/inc/oleobjsh.hxx
+++ b/sc/source/ui/inc/oleobjsh.hxx
@@ -28,7 +28,7 @@ class SfxModule;
#include "drawsh.hxx"
-class ScOleObjectShell : public ScDrawShell
+class ScOleObjectShell final : public ScDrawShell
{
public:
SFX_DECL_INTERFACE(SCID_OLEOBJECT_SHELL)
diff --git a/sc/source/ui/inc/pgbrksh.hxx b/sc/source/ui/inc/pgbrksh.hxx
index 90dd34684141..dcda667edf9a 100644
--- a/sc/source/ui/inc/pgbrksh.hxx
+++ b/sc/source/ui/inc/pgbrksh.hxx
@@ -27,7 +27,7 @@
class SfxModule;
class ScTabViewShell;
-class ScPageBreakShell : public SfxShell
+class ScPageBreakShell final : public SfxShell
{
public:
SFX_DECL_INTERFACE(SCID_PAGEBREAK_SHELL)
diff --git a/sc/source/ui/inc/pivotsh.hxx b/sc/source/ui/inc/pivotsh.hxx
index 9a6e9698e82b..af290d801c00 100644
--- a/sc/source/ui/inc/pivotsh.hxx
+++ b/sc/source/ui/inc/pivotsh.hxx
@@ -28,7 +28,7 @@ class ScTabViewShell;
class ScDPObject;
class SfxModule;
-class ScPivotShell : public SfxShell
+class ScPivotShell final : public SfxShell
{
public:
SFX_DECL_INTERFACE(SCID_PIVOT_SHELL)
diff --git a/sc/source/ui/inc/prevwsh.hxx b/sc/source/ui/inc/prevwsh.hxx
index d23eca09eacb..3dfee355c3ca 100644
--- a/sc/source/ui/inc/prevwsh.hxx
+++ b/sc/source/ui/inc/prevwsh.hxx
@@ -37,7 +37,7 @@ class ScPreviewLocationData;
class CommandEvent;
class SfxViewFactory;
-class SC_DLLPUBLIC ScPreviewShell: public SfxViewShell
+class SC_DLLPUBLIC ScPreviewShell final : public SfxViewShell
{
ScDocShell* pDocShell;
@@ -60,7 +60,6 @@ private:
void DoScroll( sal_uInt16 nMode );
void ExitPreview();
-protected:
virtual void Activate(bool bMDI) override;
void AdjustPosSizePixel( const Point &rPos, const Size &rSize );
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
