accessibility/inc/extended/AccessibleBrowseBox.hxx | 4 ++-- accessibility/inc/extended/AccessibleGridControl.hxx | 4 ++-- accessibility/inc/extended/textwindowaccessibility.hxx | 2 +- accessibility/inc/standard/vclxaccessiblemenu.hxx | 3 +-- toolkit/inc/awt/vclxwindows.hxx | 9 ++++----- toolkit/inc/controls/svmedit.hxx | 2 +- toolkit/inc/controls/treecontrolpeer.hxx | 2 +- 7 files changed, 12 insertions(+), 14 deletions(-)
New commits: commit 53e972671d9ae392f7a691f8d1d42f0d753eabc4 Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Fri Jun 25 09:07:21 2021 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Sat Jun 26 13:32:03 2021 +0200 loplugin:finalclasses in toolkit Change-Id: Ib3db1d6421e6dfba57fe660174e2e4c2af0c6369 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117888 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/toolkit/inc/awt/vclxwindows.hxx b/toolkit/inc/awt/vclxwindows.hxx index 7c8b4a42b21d..416b7feabda8 100644 --- a/toolkit/inc/awt/vclxwindows.hxx +++ b/toolkit/inc/awt/vclxwindows.hxx @@ -237,7 +237,7 @@ public: virtual void GetPropertyIds( std::vector< sal_uInt16 > &aIds ) override { return ImplGetPropertyIds( aIds ); } }; -class VCLXMultiLineEdit : public css::awt::XTextComponent, +class VCLXMultiLineEdit final : public css::awt::XTextComponent, public css::awt::XTextArea, public css::awt::XTextLayoutConstrains, public VCLXWindow @@ -246,7 +246,6 @@ private: TextListenerMultiplexer maTextListeners; LineEnd meLineEndType; -protected: void ProcessWindowEvent( const VclWindowEvent& rVclWindowEvent ) override; public: @@ -720,7 +719,7 @@ protected: virtual void GetPropertyIds( std::vector< sal_uInt16 > &aIds ) override { return ImplGetPropertyIds( aIds ); } }; -class SVTXCurrencyField : public css::awt::XCurrencyField, public SVTXFormattedField +class SVTXCurrencyField final : public css::awt::XCurrencyField, public SVTXFormattedField { public: SVTXCurrencyField(); @@ -763,7 +762,7 @@ public: -class SVTXNumericField : public css::awt::XNumericField, public SVTXFormattedField +class SVTXNumericField final : public css::awt::XNumericField, public SVTXFormattedField { public: SVTXNumericField(); @@ -799,7 +798,7 @@ public: virtual void GetPropertyIds( std::vector< sal_uInt16 > &aIds ) override; }; -class SVTXDateField : public VCLXDateField +class SVTXDateField final : public VCLXDateField { public: SVTXDateField(); diff --git a/toolkit/inc/controls/svmedit.hxx b/toolkit/inc/controls/svmedit.hxx index 33586c84f064..77295cdd5851 100644 --- a/toolkit/inc/controls/svmedit.hxx +++ b/toolkit/inc/controls/svmedit.hxx @@ -21,7 +21,7 @@ #include <vcl/toolkit/vclmedit.hxx> -class MultiLineEdit : public VclMultiLineEdit +class MultiLineEdit final : public VclMultiLineEdit { public: MultiLineEdit( vcl::Window* pParent, WinBits nWinStyle ); diff --git a/toolkit/inc/controls/treecontrolpeer.hxx b/toolkit/inc/controls/treecontrolpeer.hxx index 0bfb7c643238..d584516ae35b 100644 --- a/toolkit/inc/controls/treecontrolpeer.hxx +++ b/toolkit/inc/controls/treecontrolpeer.hxx @@ -38,7 +38,7 @@ class UnoTreeListEntry; class TreeControlPeer; class UnoTreeListBoxImpl; -class TreeControlPeer : public ::cppu::ImplInheritanceHelper< VCLXWindow, css::awt::tree::XTreeControl, css::awt::tree::XTreeDataModelListener > +class TreeControlPeer final : public ::cppu::ImplInheritanceHelper< VCLXWindow, css::awt::tree::XTreeControl, css::awt::tree::XTreeDataModelListener > { typedef std::map<css::uno::Reference<css::awt::tree::XTreeNode>, UnoTreeListEntry*> TreeNodeMap; commit 1720bacfc0efd071ea56757b97a1bf2951f80cee Author: Noel Grandin <noel.gran...@collabora.co.uk> AuthorDate: Fri Jun 25 09:34:17 2021 +0200 Commit: Noel Grandin <noel.gran...@collabora.co.uk> CommitDate: Sat Jun 26 13:31:49 2021 +0200 loplugin:finalclasses in accessibility Change-Id: Idac98767a97a150964c4c5fc736f184057b1a79a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117892 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk> diff --git a/accessibility/inc/extended/AccessibleBrowseBox.hxx b/accessibility/inc/extended/AccessibleBrowseBox.hxx index 5b676ecf5bd3..c854ffef52f0 100644 --- a/accessibility/inc/extended/AccessibleBrowseBox.hxx +++ b/accessibility/inc/extended/AccessibleBrowseBox.hxx @@ -191,7 +191,7 @@ private: The instance holds its XAccessibleContext with a hard reference, while the context holds this instance weak. */ -class AccessibleBrowseBoxAccess: +class AccessibleBrowseBoxAccess final : public cppu::WeakImplHelper<css::accessibility::XAccessible>, public ::vcl::IAccessibleBrowseBox { @@ -212,7 +212,7 @@ public: /// returns the AccessibleContext belonging to this Accessible AccessibleBrowseBox* getContext() { return m_xContext.get(); } -protected: +private: virtual ~AccessibleBrowseBoxAccess() override; // XAccessible diff --git a/accessibility/inc/extended/AccessibleGridControl.hxx b/accessibility/inc/extended/AccessibleGridControl.hxx index 34d0d0ffaf1c..6fa1a91b4919 100644 --- a/accessibility/inc/extended/AccessibleGridControl.hxx +++ b/accessibility/inc/extended/AccessibleGridControl.hxx @@ -163,7 +163,7 @@ private: the context holds this instance weak.</p> */ -class AccessibleGridControlAccess : +class AccessibleGridControlAccess final : public ::cppu::WeakImplHelper< css::accessibility::XAccessible > ,public ::vcl::table::IAccessibleTableControl { @@ -181,7 +181,7 @@ public: /// returns the AccessibleContext belonging to this Accessible AccessibleGridControl* getContext() { return m_xContext.get(); } -protected: +private: virtual ~AccessibleGridControlAccess() override; // XAccessible diff --git a/accessibility/inc/extended/textwindowaccessibility.hxx b/accessibility/inc/extended/textwindowaccessibility.hxx index 91ccd4b5d52a..151e77dcfd30 100644 --- a/accessibility/inc/extended/textwindowaccessibility.hxx +++ b/accessibility/inc/extended/textwindowaccessibility.hxx @@ -313,7 +313,7 @@ private: typedef std::unordered_map< OUString, css::beans::PropertyValue > tPropValMap; -class Document: public ::VCLXAccessibleComponent, public ::SfxListener +class Document final : public ::VCLXAccessibleComponent, public ::SfxListener { public: Document(::VCLXWindow * pVclXWindow, ::TextEngine & rEngine, diff --git a/accessibility/inc/standard/vclxaccessiblemenu.hxx b/accessibility/inc/standard/vclxaccessiblemenu.hxx index 34524eb0ba32..1bd7be7d1e77 100644 --- a/accessibility/inc/standard/vclxaccessiblemenu.hxx +++ b/accessibility/inc/standard/vclxaccessiblemenu.hxx @@ -30,10 +30,9 @@ typedef ::cppu::ImplHelper1 < css::accessibility::XAccessibleSelection > VCLXAccessibleMenu_BASE; -class VCLXAccessibleMenu : public VCLXAccessibleMenuItem, +class VCLXAccessibleMenu final : public VCLXAccessibleMenuItem, public VCLXAccessibleMenu_BASE { -protected: virtual bool IsFocused() override; virtual bool IsPopupMenuOpen() override; sal_Int32 implGetSelectedAccessibleChildCount(); _______________________________________________ Libreoffice-commits mailing list libreoffice-comm...@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits