vcl/source/window/window.cxx | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
New commits:
commit 303c46e2394f6b744f0df5e8e55a8e1cd8e22a91
Author: Michael Meeks <michael.me...@collabora.com>
AuthorDate: Fri Jul 9 15:14:50 2021 +0100
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Tue Jul 13 15:46:52 2021 +0200
vcl: make get_id safe for disposed windows.
crash from:
findChild(vcl::Window*, rtl::OUString const&, bool)
include/rtl/ustring.hxx:1744
WindowUIObject::get_visible_child(rtl::OUString const&)
/vcl/source/uitest/uiobject.cxx:463
lcl_sendDialogEvent ...
Change-Id: Ic1756c7b03f2dee9780fb1a735917f1d0fc11876
Signed-off-by: Michael Meeks <michael.me...@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118691
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/vcl/source/window/window.cxx b/vcl/source/window/window.cxx
index 41751c015a43..3a960cf76984 100644
--- a/vcl/source/window/window.cxx
+++ b/vcl/source/window/window.cxx
@@ -3911,7 +3911,8 @@ void Window::set_id(const OUString& rID)
const OUString& Window::get_id() const
{
- return mpWindowImpl->maID;
+ static OUString empty;
+ return mpWindowImpl ? mpWindowImpl->maID : empty;
}
FactoryFunction Window::GetUITestFactory() const
_______________________________________________
Libreoffice-commits mailing list
libreoffice-comm...@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
