compilerplugins/clang/badstatics.cxx | 5 +++++
1 file changed, 5 insertions(+)
New commits:
commit 9a681101543f9c60112dfc0d04309be7dc50b61d
Author: Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Tue Nov 30 12:14:30 2021 +0100
Commit: Stephan Bergmann <sberg...@redhat.com>
CommitDate: Tue Nov 30 16:03:18 2021 +0100
Silence loplugin:badstatics
> /Users/stephan/lo/core/vcl/osx/a11yfocustracker.cxx:40:33: error: bad
static variable causes crash on shutdown [loplugin:badstatics]
> static AquaA11yFocusTracker SINGLETON;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
> /Users/stephan/lo/core/vcl/inc/osx/a11yfocustracker.hxx:85:35: note: ...
due to this member of 'AquaA11yFocusTracker' [loplugin:badstatics]
> std::set<VclPtr<vcl::Window>> m_aDocumentWindowList;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~
Change-Id: I7fd0b1808e5433bab6e1436c345044a5ce804f4c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126115
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sberg...@redhat.com>
diff --git a/compilerplugins/clang/badstatics.cxx
b/compilerplugins/clang/badstatics.cxx
index 75eee2606769..9539559f699e 100644
--- a/compilerplugins/clang/badstatics.cxx
+++ b/compilerplugins/clang/badstatics.cxx
@@ -226,6 +226,11 @@ public:
// sfx2/source/view/frame.cxx, vector of pointer, so not a
problem, nothing is going to happen on shutdown
|| name == "g_pOLELRU_Cache" || name == "s_aTableColumnsMap"
// TODO
+ || name == "SINGLETON"
+ // TheAquaA11yFocusTracker in vcl/osx/a11yfocustracker.cxx,
+ // AquaA11yFocusTracker::m_aDocumentWindowList elements
symmetrically added and
+ // removed in AquaA11yFocusTracker::window_got_focus and
+ // AquaA11yFocusTracker::WindowEventHandler (TODO: is that
guaranteed?)
) // these variables appear unproblematic
{
return true;
