chart2/source/controller/dialogs/dlg_CreationWizard.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 67e88d173fb56a2628a5464d56276134bf6f65a2
Author:     Rafael Lima <rafael.palma.l...@gmail.com>
AuthorDate: Mon Jan 3 23:37:26 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Fri Jan 21 17:55:55 2022 +0100

    tdf#135935 Ensure help page is opened in chart creation Wizard dialog
    
    Prior to this patch, if the user opens the Chart Wizard dialog (Insert > 
Chart) and clicks the Help button without clicking anywhere in the dialog, the 
help ID was not being applied. This problem happens on kf5 and gen, but not on 
gtk3.
    
    With this patch, the expected behavior is achieved in gtk3, gen and kf5.
    
    Change-Id: Ief7852fce00de45f65c21ea0ddc8e4d6477612d8
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127783
    Tested-by: Jenkins
    Tested-by: Caolán McNamara <caol...@redhat.com>
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx 
b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
index 56da19feacd6..e186633c869f 100644
--- a/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
+++ b/chart2/source/controller/dialogs/dlg_CreationWizard.cxx
@@ -73,7 +73,8 @@ CreationWizard::CreationWizard(weld::Window* pParent, const 
rtl::Reference<::cha
 
     declarePath(PATH_FULL, aPath);
 
-    SetRoadmapHelpId(HID_SCH_WIZARD_ROADMAP);
+    // tdf#135935 ensure help ID is set when no element is clicked in the 
dialog
+    m_xAssistant->set_help_id(HID_SCH_WIZARD_ROADMAP);
 
     if (!m_pDialogModel->getModel().isDataFromSpreadsheet())
     {

Reply via email to