[Libreoffice-commits] core.git: wizards/source

[Jean-Pierre Ledure (via logerrit)]

 wizards/source/scriptforge/SF_Utils.xba |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 3e340d3f7b73c8577e58c561a34c2b826e77da51
Author:     Jean-Pierre Ledure <j...@ledure.be>
AuthorDate: Wed Feb 9 14:33:25 2022 +0100
Commit:     Jean-Pierre Ledure <j...@ledure.be>
CommitDate: Thu Feb 10 09:43:10 2022 +0100

    ScriptForge - (SF_Utils) review optional argument of _Repr()
    
    As from LO 7.3, optional missing arguments must not be used
    in assignments and comparisons.
    The Basic interpreter tolerated it before 7.3.
    
    Probable commit having changed Basic behaviour:
        https://gerrit.libreoffice.org/c/core/+/121794
    
    A unique case of this singularity was found in the
        SF_Utils._Repr()
    method.
    
    The bad consequence was that the commonly used
        SF_Exception.DebugPrint()
    method calls above method. This broke in fact
    the whole ScriptForge library.
    
    Change-Id: Iba8792b92c73c992429de4382bd8a3dc4b58a94f
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129728
    Tested-by: Jean-Pierre Ledure <j...@ledure.be>
    Tested-by: Jenkins
    Reviewed-by: Jean-Pierre Ledure <j...@ledure.be>

diff --git a/wizards/source/scriptforge/SF_Utils.xba 
b/wizards/source/scriptforge/SF_Utils.xba
index 2ca9a6fe09d3..a6a4f49abe4d 100644
--- a/wizards/source/scriptforge/SF_Utils.xba
+++ b/wizards/source/scriptforge/SF_Utils.xba
@@ -542,7 +542,8 @@ Const cstMaxLength = 2^15 - 1       &apos;  32767
 Const cstByteLength = 25
 Const cstEtc = &quot; … &quot;
 
-       If IsMissing(plMax) Or plMax = 0 Then plMax = cstMaxLength
+       If IsMissing(plMax) Then plMax = cstMaxLength
+       If plMax = 0 Then plMax = cstMaxLength
        If IsArray(pvArg) Then
                sArg = SF_Array._Repr(pvArg)
        Else