[Libreoffice-commits] core.git: sc/source

[Luboš Luňák (via logerrit)]

 sc/source/core/data/dociter.cxx |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 2b0579fbcc064dbcaf9217feead7ef23ec7a5222
Author:     Luboš Luňák <l.lu...@collabora.com>
AuthorDate: Fri Apr 22 11:25:46 2022 +0200
Commit:     Luboš Luňák <l.lu...@collabora.com>
CommitDate: Fri Apr 22 13:40:39 2022 +0200

    remove nonsensical 'over and out' comments
    
    First of all, it's very obvious that a return statement returns,
    so there's little point in commenting that. Second, 'over' and 'out'
    together is Hollywood nonsense, 'over' means "talk, I'm listening"
    and 'out' means "I'm not listening anymore" ... so 'over and out'
    I guess means "talk, I'm not listening" ?
    
    Change-Id: I60a202c78b33bd063c40ef4cd51514f7a2e6c95d
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133321
    Tested-by: Luboš Luňák <l.lu...@collabora.com>
    Reviewed-by: Luboš Luňák <l.lu...@collabora.com>

diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index 01583d570d63..052439698adb 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -181,7 +181,7 @@ bool ScValueIterator::GetThis(double& rValue, FormulaError& 
rErr)
                     if (mnTab > maEndPos.Tab())
                     {
                         rErr = FormulaError::NONE;
-                        return false; // Over and out
+                        return false;
                     }
                 }
                 pCol = &(mrDoc.maTabs[mnTab])->aCol[mnCol];
@@ -937,7 +937,7 @@ bool ScCellIterator::getCurrent()
                     if (maCurPos.Tab() > maEndPos.Tab())
                     {
                         maCurCell.clear();
-                        return false; // Over and out
+                        return false;
                     }
                 }
                 pCol = getColumn();
@@ -1142,7 +1142,7 @@ bool ScQueryCellIterator::GetThis()
             {
                 ++nCol;
                 if (nCol > maParam.nCol2 || nCol >= 
rDoc.maTabs[nTab]->GetAllocatedColumnsCount())
-                    return false; // Over and out
+                    return false;
                 if ( bAdvanceQuery )
                 {
                     AdvanceQueryParamEntryField();
@@ -1529,7 +1529,7 @@ int ScCountIfCellIterator::GetCount()
             {
                 ++nCol;
                 if (nCol > maParam.nCol2 || nCol >= 
rDoc.maTabs[nTab]->GetAllocatedColumnsCount())
-                    return count; // Over and out
+                    return count;
                 AdvanceQueryParamEntryField();
                 pCol = &(rDoc.maTabs[nTab])->aCol[nCol];
             }