[Libreoffice-commits] core.git: sd/source

[Caolán McNamara (via logerrit)]

 sd/source/ui/dlg/BulletAndPositionDlg.cxx |    9 +++++++--
 sd/source/ui/inc/BulletAndPositionDlg.hxx |    1 +
 2 files changed, 8 insertions(+), 2 deletions(-)

New commits:
commit 9969b7ee3413b4c83f6e93d92e1038daeaf649e8
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Mon May 16 20:50:37 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Tue May 17 09:54:15 2022 +0200

    Resolves: tdf#149093 connect_value_change if we will query its value
    
    and not the text_change which is called before the value is parsed
    from the new text
    
    Change-Id: Ib6bd5647139f1b79f299beb42b704b465ddf535c
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134412
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/sd/source/ui/dlg/BulletAndPositionDlg.cxx 
b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
index becea079e374..384b477e46b6 100644
--- a/sd/source/ui/dlg/BulletAndPositionDlg.cxx
+++ b/sd/source/ui/dlg/BulletAndPositionDlg.cxx
@@ -138,7 +138,7 @@ 
SvxBulletAndPositionDlg::SvxBulletAndPositionDlg(weld::Window* pWindow, const Sf
     m_xWidthMF->connect_value_changed(LINK(this, SvxBulletAndPositionDlg, 
SizeHdl_Impl));
     m_xHeightMF->connect_value_changed(LINK(this, SvxBulletAndPositionDlg, 
SizeHdl_Impl));
     m_xRatioCB->connect_toggled(LINK(this, SvxBulletAndPositionDlg, 
RatioHdl_Impl));
-    m_xStartED->connect_changed(LINK(this, SvxBulletAndPositionDlg, 
EditModifyHdl_Impl));
+    m_xStartED->connect_value_changed(LINK(this, SvxBulletAndPositionDlg, 
SpinModifyHdl_Impl));
     m_xPrefixED->connect_changed(LINK(this, SvxBulletAndPositionDlg, 
EditModifyHdl_Impl));
     m_xSuffixED->connect_changed(LINK(this, SvxBulletAndPositionDlg, 
EditModifyHdl_Impl));
     m_xBulRelSizeMF->connect_value_changed(LINK(this, SvxBulletAndPositionDlg, 
BulRelSizeHdl_Impl));
@@ -659,7 +659,7 @@ void 
SvxBulletAndPositionDlg::CheckForStartValue_Impl(sal_uInt16 nNumberingType)
                           || SVX_NUM_CHARS_LOWER_LETTER_N == nNumberingType;
     m_xStartED->set_min(bNoZeroAllowed ? 1 : 0);
     if (bIsNull && bNoZeroAllowed)
-        EditModifyHdl_Impl(*m_xStartED);
+        SpinModifyHdl_Impl(*m_xStartED);
 }
 
 IMPL_LINK(SvxBulletAndPositionDlg, LevelHdl_Impl, weld::TreeView&, rBox, void)
@@ -1125,6 +1125,11 @@ IMPL_LINK(SvxBulletAndPositionDlg, EditModifyHdl_Impl, 
weld::Entry&, rEdit, void
     EditModifyHdl_Impl(&rEdit);
 }
 
+IMPL_LINK(SvxBulletAndPositionDlg, SpinModifyHdl_Impl, weld::SpinButton&, 
rSpinButton, void)
+{
+    EditModifyHdl_Impl(&rSpinButton);
+}
+
 IMPL_LINK(SvxBulletAndPositionDlg, DistanceHdl_Impl, weld::MetricSpinButton&, 
rFld, void)
 {
     if (bInInitControl)
diff --git a/sd/source/ui/inc/BulletAndPositionDlg.hxx 
b/sd/source/ui/inc/BulletAndPositionDlg.hxx
index 4645060e251c..6dde737537ce 100644
--- a/sd/source/ui/inc/BulletAndPositionDlg.hxx
+++ b/sd/source/ui/inc/BulletAndPositionDlg.hxx
@@ -124,6 +124,7 @@ class SvxBulletAndPositionDlg : public 
weld::GenericDialogController
     DECL_LINK(SizeHdl_Impl, weld::MetricSpinButton&, void);
     DECL_LINK(RatioHdl_Impl, weld::Toggleable&, void);
     DECL_LINK(EditModifyHdl_Impl, weld::Entry&, void);
+    DECL_LINK(SpinModifyHdl_Impl, weld::SpinButton&, void);
     DECL_LINK(BulColorHdl_Impl, ColorListBox&, void);
     DECL_LINK(BulRelSizeHdl_Impl, weld::MetricSpinButton&, void);
     DECL_LINK(PreviewInvalidateHdl_Impl, Timer*, void);