[Libreoffice-commits] core.git: idlc/inc idl/inc

[Noel Grandin (via logerrit)]

 idl/inc/hash.hxx                |    5 +++--
 idlc/inc/inheritedinterface.hxx |    5 +++--
 idlc/inc/options.hxx            |    4 ++--
 3 files changed, 8 insertions(+), 6 deletions(-)

New commits:
commit 9f25d34d652de14959b5eebed8462225b43e408c
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Wed May 18 14:51:21 2022 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Wed May 18 18:18:14 2022 +0200

    clang-tidy modernize-pass-by-value in idl/idlc
    
    Change-Id: Iccd18eb394564d3ba90c395725923c559b2b81e1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134532
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/idl/inc/hash.hxx b/idl/inc/hash.hxx
index 150c604ff9d4..6bc904133f61 100644
--- a/idl/inc/hash.hxx
+++ b/idl/inc/hash.hxx
@@ -24,14 +24,15 @@
 #include <tools/solar.h>
 #include <unordered_map>
 #include <memory>
+#include <utility>
 
 class SvStringHashEntry
 {
     OString     aName;
     sal_uLong   nValue;
 public:
-    SvStringHashEntry( const OString& rName )
-        : aName(rName)
+    SvStringHashEntry( OString aName_ )
+        : aName(std::move(aName_))
         , nValue(0)
     {
     }
diff --git a/idlc/inc/inheritedinterface.hxx b/idlc/inc/inheritedinterface.hxx
index 10e6ace39342..16462b4da16d 100644
--- a/idlc/inc/inheritedinterface.hxx
+++ b/idlc/inc/inheritedinterface.hxx
@@ -23,6 +23,7 @@
 #include "idlc.hxx"
 
 #include <rtl/ustring.hxx>
+#include <utility>
 
 class AstInterface;
 class AstType;
@@ -31,9 +32,9 @@ class InheritedInterface {
 public:
     InheritedInterface(
         AstType const * theInterface, bool theOptional,
-        OUString const & theDocumentation):
+        OUString theDocumentation):
         interface(theInterface), optional(theOptional),
-        documentation(theDocumentation) {}
+        documentation(std::move(theDocumentation)) {}
 
     AstType const * getInterface() const { return interface; }
 
diff --git a/idlc/inc/options.hxx b/idlc/inc/options.hxx
index b3a791bcb1c5..c3a0949b3d2f 100644
--- a/idlc/inc/options.hxx
+++ b/idlc/inc/options.hxx
@@ -21,14 +21,14 @@
 #define INCLUDED_IDLC_INC_OPTIONS_HXX
 
 #include "idlctypes.hxx"
+#include <utility>
 
 typedef std::unordered_map< OString, OString > OptionMap;
 
 class IllegalArgument
 {
 public:
-    IllegalArgument(const OString& msg)
-        : m_message(msg) {}
+    IllegalArgument(OString msg) : m_message(std::move(msg)) {}
 
     OString  m_message;
 };