[Libreoffice-commits] core.git: include/editeng

[Noel Grandin (via logerrit)]

 include/editeng/fontitem.hxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 86922db292f5708d2431959d15c5ceea70aee7fb
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Thu Jun 2 15:07:04 2022 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Thu Jun 2 15:55:55 2022 +0200

    Revert "mark SvxFontItem as IsSortable"
    
    This reverts commit c390c2e3f44953e236389467c7c090cee9ebc1b7.
    
    Causes crashes like
    ./instdir/program/soffice --headless --convert-to pdf ooo30162-3.xls
    because code likes modifying items that are in existing
    pools.
    
    Change-Id: I988745a538509f90f357ec6a321b2e37828a4111
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135308
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/include/editeng/fontitem.hxx b/include/editeng/fontitem.hxx
index 35743b9949e1..2ccaade20121 100644
--- a/include/editeng/fontitem.hxx
+++ b/include/editeng/fontitem.hxx
@@ -47,7 +47,6 @@ public:
     // "pure virtual Methods" from SfxPoolItem
     virtual bool operator==(const SfxPoolItem& rItem) const override;
     bool operator<(const SfxPoolItem& rCmp) const override;
-    virtual bool IsSortable() const override { return true; }
     virtual SvxFontItem* Clone(SfxItemPool *pPool = nullptr) const override;
     virtual bool QueryValue(css::uno::Any& rVal, sal_uInt8 nMemberId = 0) 
const override;
     virtual bool PutValue(const css::uno::Any& rVal, sal_uInt8 nMemberId) 
override;