[Libreoffice-commits] core.git: Branch 'libreoffice-7-4' - sc/source

[Eike Rathke (via logerrit)]

 sc/source/core/tool/addincol.cxx |    2 +-
 sc/source/core/tool/interpr4.cxx |    2 +-
 sc/source/core/tool/parclass.cxx |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9f7ab29857a552be0f7141a7e49e3dd5291f19a6
Author:     Eike Rathke <er...@redhat.com>
AuthorDate: Sat Jun 18 00:56:30 2022 +0200
Commit:     Eike Rathke <er...@redhat.com>
CommitDate: Sat Jun 18 19:58:20 2022 +0200

    Related: tdf#142293 Do not use locale's uppercase for Add-In programmatic 
name
    
    ... so in a tr-TR locale
    com.sun.star.sheet.addin.Analysis.getEdate
    is not upper-cased to
    COM.SUN.STAR.SHEET.ADDİN.ANALYSİS.GETEDATE
    
    Which didn't matter as long as it was consistent and only used for
    lookup and mapping, if so..
    
    Additionally, the programmatic name does not need the CharClass
    overhead and toAsciiUpperCase() is sufficient and faster.
    
    Change-Id: I1c987cc56dc3a62b5285a0bc367c754e7acb6815
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136070
    Reviewed-by: Eike Rathke <er...@redhat.com>
    Tested-by: Jenkins
    (cherry picked from commit 36cb12bce80836a29e5124167b588490b3f7700d)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136045

diff --git a/sc/source/core/tool/addincol.cxx b/sc/source/core/tool/addincol.cxx
index 26b7baa9ed7f..addb1512806f 100644
--- a/sc/source/core/tool/addincol.cxx
+++ b/sc/source/core/tool/addincol.cxx
@@ -92,7 +92,7 @@ ScUnoAddInFuncData::ScUnoAddInFuncData( const OUString& rNam, 
const OUString& rL
             pArgDescs[i] = pAD[i];
     }
 
-    aUpperName = ScGlobal::getCharClass().uppercase(aUpperName);
+    aUpperName = aUpperName.toAsciiUpperCase();  // programmatic name
     aUpperLocal = ScGlobal::getCharClass().uppercase(aUpperLocal);
 }
 
diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index 540928f0bee6..c123374c745d 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -2530,7 +2530,7 @@ void ScInterpreter::ScExternal()
 {
     sal_uInt8 nParamCount = GetByte();
     OUString aUnoName;
-    OUString aFuncName( ScGlobal::getCharClass().uppercase( 
pCur->GetExternal() ) );
+    OUString aFuncName( pCur->GetExternal().toAsciiUpperCase());    // 
programmatic name
     LegacyFuncData* pLegacyFuncData = 
ScGlobal::GetLegacyFuncCollection()->findByName(aFuncName);
     if (pLegacyFuncData)
     {
diff --git a/sc/source/core/tool/parclass.cxx b/sc/source/core/tool/parclass.cxx
index 81c6df1b0b39..473177c8fca0 100644
--- a/sc/source/core/tool/parclass.cxx
+++ b/sc/source/core/tool/parclass.cxx
@@ -407,7 +407,7 @@ formula::ParamClass 
ScParameterClassification::GetExternalParameterType( const f
         return eRet;
 
     // similar to ScInterpreter::ScExternal()
-    OUString aFuncName = ScGlobal::getCharClass().uppercase( 
pToken->GetExternal());
+    OUString aFuncName = pToken->GetExternal().toAsciiUpperCase();  // 
programmatic name
     {
         const LegacyFuncData* pLegacyFuncData = 
ScGlobal::GetLegacyFuncCollection()->findByName(aFuncName);
         if (pLegacyFuncData)