Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
16 new defect(s) introduced to LibreOffice found with Coverity Scan.
1 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 16 of 16 defect(s)
** CID 1507857: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 770 in
ScUndoAutoFormat::ScUndoAutoFormat(ScDocShell *, const ScRange &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, ScMarkData,
bool, unsigned short)()
________________________________________________________________________________________________________
*** CID 1507857: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 770 in
ScUndoAutoFormat::ScUndoAutoFormat(ScDocShell *, const ScRange &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, ScMarkData,
bool, unsigned short)()
764 {
765 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
766 }
767
768 ScUndoAutoFormat::ScUndoAutoFormat( ScDocShell* pNewDocShell,
769 const ScRange& rRange, ScDocumentUniquePtr
pNewUndoDoc,
>>> CID 1507857: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
770 ScMarkData aMark, bool bNewSize, sal_uInt16
nNewFormatNo )
771 : ScBlockUndo( pNewDocShell, rRange, bNewSize ?
SC_UNDO_MANUALHEIGHT : SC_UNDO_AUTOHEIGHT ),
772 pUndoDoc ( std::move(pNewUndoDoc) ),
773 aMarkData (std::move( aMark )),
774 bSize ( bNewSize ),
775 nFormatNo ( nNewFormatNo )
** CID 1507856: API usage errors (PRINTF_ARGS)
/sw/source/core/layout/atrfrm.cxx: 1777 in
SwFormatAnchor::dumpAsXml(_xmlTextWriter *) const()
________________________________________________________________________________________________________
*** CID 1507856: API usage errors (PRINTF_ARGS)
/sw/source/core/layout/atrfrm.cxx: 1777 in
SwFormatAnchor::dumpAsXml(_xmlTextWriter *) const()
1771 {
1772 std::stringstream aContentAnchor;
1773 aContentAnchor << *m_oContentAnchor;
1774 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_pContentAnchor"), BAD_CAST(aContentAnchor.str().c_str()));
1775 }
1776 else
>>> CID 1507856: API usage errors (PRINTF_ARGS)
>>> Argument "std::nullptr_t()" to format specifier "%p" was expected to
>>> have pointer type but has type "std::nullptr_t".
1777 (void)xmlTextWriterWriteFormatAttribute(pWriter,
BAD_CAST("m_pContentAnchor"), "%p", nullptr);
1778 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_eAnchorType"),
BAD_CAST(OString::number(static_cast<int>(m_eAnchorId)).getStr()));
1779 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_nPageNumber"), BAD_CAST(OString::number(m_nPageNumber).getStr()));
1780 (void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("m_nOrder"),
BAD_CAST(OString::number(m_nOrder).getStr()));
1781 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("s_nOrderCounter"),
BAD_CAST(OString::number(s_nOrderCounter).getStr()));
1782 OUString aPresentation;
** CID 1507855: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 1793 in
ScUndoSelectionStyle::ScUndoSelectionStyle(ScDocShell *, ScMarkData, const
ScRange &, rtl::OUString, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>)()
________________________________________________________________________________________________________
*** CID 1507855: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 1793 in
ScUndoSelectionStyle::ScUndoSelectionStyle(ScDocShell *, ScMarkData, const
ScRange &, rtl::OUString, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>)()
1787 return !rViewData.GetDocument().IsScenario(
rViewData.GetTabNo() );
1788 }
1789 return false;
1790 }
1791
1792 ScUndoSelectionStyle::ScUndoSelectionStyle( ScDocShell* pNewDocShell,
>>> CID 1507855: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
1793 ScMarkData aMark,
1794 const ScRange& rRange,
1795 OUString aName,
1796 ScDocumentUniquePtr
pNewUndoDoc ) :
1797 ScSimpleUndo( pNewDocShell ),
1798 aMarkData(std::move( aMark )),
** CID 1507854: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 1283 in
ScUndoRefConversion::ScUndoRefConversion(ScDocShell *, const ScRange &,
ScMarkData, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, bool)()
________________________________________________________________________________________________________
*** CID 1507854: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 1283 in
ScUndoRefConversion::ScUndoRefConversion(ScDocShell *, const ScRange &,
ScMarkData, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, bool)()
1277 bool ScUndoConversion::CanRepeat(SfxRepeatTarget& rTarget) const
1278 {
1279 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
1280 }
1281
1282 ScUndoRefConversion::ScUndoRefConversion( ScDocShell* pNewDocShell,
>>> CID 1507854: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
1283 const ScRange& aMarkRange,
ScMarkData aMark,
1284 ScDocumentUniquePtr
pNewUndoDoc, ScDocumentUniquePtr pNewRedoDoc, bool bNewMulti) :
1285 ScSimpleUndo( pNewDocShell ),
1286 aMarkData (std::move( aMark )),
1287 pUndoDoc ( std::move(pNewUndoDoc) ),
1288 pRedoDoc ( std::move(pNewRedoDoc) ),
** CID 1507853: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 207 in
ScUndoFillTable::ScUndoFillTable(ScDocShell *, ScMarkData, short, int, short,
short, int, short, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, bool, short, InsertDeleteFlags, ScPasteFunc,
bool, bool)()
________________________________________________________________________________________________________
*** CID 1507853: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 207 in
ScUndoFillTable::ScUndoFillTable(ScDocShell *, ScMarkData, short, int, short,
short, int, short, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, bool, short, InsertDeleteFlags, ScPasteFunc,
bool, bool)()
201 bool ScUndoDeleteContents::CanRepeat(SfxRepeatTarget& rTarget) const
202 {
203 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
204 }
205
206 ScUndoFillTable::ScUndoFillTable( ScDocShell* pNewDocShell,
>>> CID 1507853: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
207 ScMarkData aMark,
208 SCCOL nStartX, SCROW nStartY, SCTAB nStartZ,
209 SCCOL nEndX, SCROW nEndY, SCTAB nEndZ,
210 ScDocumentUniquePtr pNewUndoDoc, bool bNewMulti, SCTAB
nSrc,
211 InsertDeleteFlags nFlg, ScPasteFunc nFunc, bool bSkip,
bool bLink )
212 : ScSimpleUndo( pNewDocShell ),
** CID 1507852: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/dbgui/pvfundlg.cxx: 649 in
ScDPSubtotalOptDlg::ScDPSubtotalOptDlg(weld::Window *, ScDPObject &,
ScDPLabelData, const std::vector<ScDPName, std::allocator<ScDPName>> &, bool)()
________________________________________________________________________________________________________
*** CID 1507852: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/dbgui/pvfundlg.cxx: 649 in
ScDPSubtotalOptDlg::ScDPSubtotalOptDlg(weld::Window *, ScDPObject &,
ScDPLabelData, const std::vector<ScDPName, std::allocator<ScDPName>> &, bool)()
643 }
644 return DataPilotFieldShowItemsMode::FROM_TOP;
645 }
646 }
647
648 ScDPSubtotalOptDlg::ScDPSubtotalOptDlg(weld::Window* pParent,
ScDPObject& rDPObj,
>>> CID 1507852: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aLabelData of type "ScDPLabelData" (size 136 bytes)
>>> by value.
649 ScDPLabelData aLabelData, const ScDPNameVec& rDataFields,
650 bool bEnableLayout )
651 : GenericDialogController(pParent,
"modules/scalc/ui/datafieldoptionsdialog.ui",
652 "DataFieldOptionsDialog")
653 , m_xLbSortBy(m_xBuilder->weld_combo_box("sortby"))
654 , m_xRbSortAsc(m_xBuilder->weld_radio_button("ascending"))
** CID 1507851: API usage errors (PW.PRINTF_ARG_MISMATCH)
/sw/source/core/layout/atrfrm.cxx: 1777 in ()
________________________________________________________________________________________________________
*** CID 1507851: API usage errors (PW.PRINTF_ARG_MISMATCH)
/sw/source/core/layout/atrfrm.cxx: 1777 in ()
1771 {
1772 std::stringstream aContentAnchor;
1773 aContentAnchor << *m_oContentAnchor;
1774 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_pContentAnchor"), BAD_CAST(aContentAnchor.str().c_str()));
1775 }
1776 else
>>> CID 1507851: API usage errors (PW.PRINTF_ARG_MISMATCH)
>>> argument is incompatible with corresponding format string conversion
1777 (void)xmlTextWriterWriteFormatAttribute(pWriter,
BAD_CAST("m_pContentAnchor"), "%p", nullptr);
1778 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_eAnchorType"),
BAD_CAST(OString::number(static_cast<int>(m_eAnchorId)).getStr()));
1779 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("m_nPageNumber"), BAD_CAST(OString::number(m_nPageNumber).getStr()));
1780 (void)xmlTextWriterWriteAttribute(pWriter, BAD_CAST("m_nOrder"),
BAD_CAST(OString::number(m_nOrder).getStr()));
1781 (void)xmlTextWriterWriteAttribute(pWriter,
BAD_CAST("s_nOrderCounter"),
BAD_CAST(OString::number(s_nOrderCounter).getStr()));
1782 OUString aPresentation;
** CID 1507850: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk2.cxx: 38 in
ScUndoWidthOrHeight::ScUndoWidthOrHeight(ScDocShell *, ScMarkData, int, short,
int, short, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
std::vector<sc::ColRowSpan, std::allocator<sc::ColRowSpan>> &&,
std::unique_ptr<ScOutlineTable, std::default_delete<ScOutlineTable>>,
ScSizeMode, unsigned short, bool)()
________________________________________________________________________________________________________
*** CID 1507850: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk2.cxx: 38 in
ScUndoWidthOrHeight::ScUndoWidthOrHeight(ScDocShell *, ScMarkData, int, short,
int, short, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
std::vector<sc::ColRowSpan, std::allocator<sc::ColRowSpan>> &&,
std::unique_ptr<ScOutlineTable, std::default_delete<ScOutlineTable>>,
ScSizeMode, unsigned short, bool)()
32
33 #include <svx/svdundo.hxx>
34 #include <utility>
35
36 /** Change column widths or row heights */
37 ScUndoWidthOrHeight::ScUndoWidthOrHeight( ScDocShell* pNewDocShell,
>>> CID 1507850: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
38 ScMarkData aMark,
39 SCCOLROW nNewStart, SCTAB nNewStartTab, SCCOLROW
nNewEnd, SCTAB nNewEndTab,
40 ScDocumentUniquePtr pNewUndoDoc,
std::vector<sc::ColRowSpan>&& rRanges,
41 std::unique_ptr<ScOutlineTable> pNewUndoTab,
42 ScSizeMode eNewMode, sal_uInt16 nNewSizeTwips, bool
bNewWidth ) :
43 ScSimpleUndo( pNewDocShell ),
** CID 1507849: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 1674 in
ScUndoUseScenario::ScUndoUseScenario(ScDocShell *, ScMarkData, const ScArea &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, rtl::OUString)()
________________________________________________________________________________________________________
*** CID 1507849: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 1674 in
ScUndoUseScenario::ScUndoUseScenario(ScDocShell *, ScMarkData, const ScArea &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, rtl::OUString)()
1668 bool ScUndoConditionalFormatList::CanRepeat(SfxRepeatTarget& ) const
1669 {
1670 return false;
1671 }
1672
1673 ScUndoUseScenario::ScUndoUseScenario( ScDocShell* pNewDocShell,
>>> CID 1507849: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
1674 ScMarkData aMark,
1675 /*C*/ const ScArea& rDestArea,
1676 ScDocumentUniquePtr pNewUndoDoc,
1677 OUString aNewName ) :
1678 ScSimpleUndo( pNewDocShell ),
1679 pUndoDoc( std::move(pNewUndoDoc) ),
** CID 1507848: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 1172 in
ScUndoConversion::ScUndoConversion(ScDocShell *, ScMarkData, short, int, short,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, short, int,
short, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
ScConversionParam)()
________________________________________________________________________________________________________
*** CID 1507848: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 1172 in
ScUndoConversion::ScUndoConversion(ScDocShell *, ScMarkData, short, int, short,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, short, int,
short, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>,
ScConversionParam)()
1166 bool ScUndoTabOp::CanRepeat(SfxRepeatTarget& /* rTarget */) const
1167 {
1168 return false;
1169 }
1170
1171 ScUndoConversion::ScUndoConversion(
>>> CID 1507848: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
1172 ScDocShell* pNewDocShell, ScMarkData aMark,
1173 SCCOL nCurX, SCROW nCurY, SCTAB nCurZ, ScDocumentUniquePtr
pNewUndoDoc,
1174 SCCOL nNewX, SCROW nNewY, SCTAB nNewZ, ScDocumentUniquePtr
pNewRedoDoc,
1175 ScConversionParam aConvParam ) :
1176 ScSimpleUndo( pNewDocShell ),
1177 aMarkData(std::move( aMark )),
** CID 1507847: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 916 in ScUndoPaste::ScUndoPaste(ScDocShell *,
const ScRangeList &, ScMarkData, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, InsertDeleteFlags,
std::unique_ptr<ScRefUndoData, std::default_delete<ScRefUndoData>>, bool, const
ScUndoPasteOptions *)()
________________________________________________________________________________________________________
*** CID 1507847: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 916 in ScUndoPaste::ScUndoPaste(ScDocShell *,
const ScRangeList &, ScMarkData, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, InsertDeleteFlags,
std::unique_ptr<ScRefUndoData, std::default_delete<ScRefUndoData>>, bool, const
ScUndoPasteOptions *)()
910 bool ScUndoCut::CanRepeat(SfxRepeatTarget& rTarget) const
911 {
912 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
913 }
914
915 ScUndoPaste::ScUndoPaste( ScDocShell* pNewDocShell, const ScRangeList&
rRanges,
>>> CID 1507847: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
916 ScMarkData aMark,
917 ScDocumentUniquePtr pNewUndoDoc, ScDocumentUniquePtr
pNewRedoDoc,
918 InsertDeleteFlags nNewFlags,
919 std::unique_ptr<ScRefUndoData> pRefData,
920 bool bRedoIsFilled, const ScUndoPasteOptions* pOptions
) :
921 ScMultiBlockUndo( pNewDocShell, rRanges ),
** CID 1507846: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 486 in
ScUndoAutoFill::ScUndoAutoFill(ScDocShell *, const ScRange &, const ScRange &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, ScMarkData,
FillDir, FillCmd, FillDateCmd, double, double, double)()
________________________________________________________________________________________________________
*** CID 1507846: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 486 in
ScUndoAutoFill::ScUndoAutoFill(ScDocShell *, const ScRange &, const ScRange &,
std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>>, ScMarkData,
FillDir, FillCmd, FillDateCmd, double, double, double)()
480 {
481 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
482 }
483
484 ScUndoAutoFill::ScUndoAutoFill( ScDocShell* pNewDocShell,
485 const ScRange& rRange, const ScRange& rSourceArea,
>>> CID 1507846: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
486 ScDocumentUniquePtr pNewUndoDoc, ScMarkData aMark,
487 FillDir eNewFillDir, FillCmd eNewFillCmd, FillDateCmd
eNewFillDateCmd,
488 double fNewStartValue, double fNewStepValue, double
fNewMaxValue )
489 : ScBlockUndo( pNewDocShell, rRange, SC_UNDO_AUTOHEIGHT ),
490 aSource ( rSourceArea ),
491 aMarkData (std::move( aMark )),
** CID 1507845: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 817 in ScUndoCut::ScUndoCut(ScDocShell *, const
ScRange &, const ScAddress &, ScMarkData, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>)()
________________________________________________________________________________________________________
*** CID 1507845: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk.cxx: 817 in ScUndoCut::ScUndoCut(ScDocShell *, const
ScRange &, const ScAddress &, ScMarkData, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>)()
811 bool ScUndoDeleteMulti::CanRepeat(SfxRepeatTarget& rTarget) const
812 {
813 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
814 }
815
816 ScUndoCut::ScUndoCut(ScDocShell* pNewDocShell, const ScRange& aRange,
const ScAddress& aOldEnd,
>>> CID 1507845: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
817 ScMarkData aMark, ScDocumentUniquePtr pNewUndoDoc)
818 : ScBlockUndo(pNewDocShell, ScRange(aRange.aStart, aOldEnd),
SC_UNDO_AUTOHEIGHT)
819 , aMarkData(std::move(aMark))
820 , pUndoDoc(std::move(pNewUndoDoc))
821 , aExtendedRange(aRange)
822 {
** CID 1507844: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 61 in
ScUndoDeleteContents::ScUndoDeleteContents(ScDocShell *, ScMarkData, const
ScRange &, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>> &&,
bool, InsertDeleteFlags, bool)()
________________________________________________________________________________________________________
*** CID 1507844: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 61 in
ScUndoDeleteContents::ScUndoDeleteContents(ScDocShell *, ScMarkData, const
ScRange &, std::unique_ptr<ScDocument, o3tl::default_delete<ScDocument>> &&,
bool, InsertDeleteFlags, bool)()
55
56 // TODO:
57 /*A*/ // SetOptimalHeight on Document, when no View
58
59 ScUndoDeleteContents::ScUndoDeleteContents(
60 ScDocShell* pNewDocShell,
>>> CID 1507844: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
61 ScMarkData aMark, const ScRange& rRange,
62 ScDocumentUniquePtr&& pNewUndoDoc, bool bNewMulti,
63 InsertDeleteFlags nNewFlags, bool bObjects )
64 : ScSimpleUndo( pNewDocShell ),
65 aRange ( rRange ),
66 aMarkData (std::move( aMark )),
** CID 1507843: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 343 in
ScUndoSelectionAttr::ScUndoSelectionAttr(ScDocShell *, ScMarkData, short, int,
short, short, int, short, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, bool, const ScPatternAttr *, const
SvxBoxItem *, const SvxBoxInfoItem *, const ScRange *)()
________________________________________________________________________________________________________
*** CID 1507843: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 343 in
ScUndoSelectionAttr::ScUndoSelectionAttr(ScDocShell *, ScMarkData, short, int,
short, short, int, short, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, bool, const ScPatternAttr *, const
SvxBoxItem *, const SvxBoxInfoItem *, const ScRange *)()
337 bool ScUndoFillTable::CanRepeat(SfxRepeatTarget& rTarget) const
338 {
339 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
340 }
341
342 ScUndoSelectionAttr::ScUndoSelectionAttr( ScDocShell* pNewDocShell,
>>> CID 1507843: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
343 ScMarkData aMark,
344 SCCOL nStartX, SCROW nStartY, SCTAB nStartZ,
345 SCCOL nEndX, SCROW nEndY, SCTAB nEndZ,
346 ScDocumentUniquePtr pNewUndoDoc, bool bNewMulti,
347 const ScPatternAttr* pNewApply,
348 const SvxBoxItem* pNewOuter, const SvxBoxInfoItem*
pNewInner,
** CID 1507842: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 918 in ScUndoReplace::ScUndoReplace(ScDocShell
*, ScMarkData, short, int, short, rtl::OUString, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, const SvxSearchItem *)()
________________________________________________________________________________________________________
*** CID 1507842: Performance inefficiencies (PASS_BY_VALUE)
/sc/source/ui/undo/undoblk3.cxx: 918 in ScUndoReplace::ScUndoReplace(ScDocShell
*, ScMarkData, short, int, short, rtl::OUString, std::unique_ptr<ScDocument,
o3tl::default_delete<ScDocument>>, const SvxSearchItem *)()
912
913 bool ScUndoAutoFormat::CanRepeat(SfxRepeatTarget& rTarget) const
914 {
915 return dynamic_cast<const ScTabViewTarget*>( &rTarget) != nullptr;
916 }
917
>>> CID 1507842: Performance inefficiencies (PASS_BY_VALUE)
>>> Passing parameter aMark of type "ScMarkData" (size 352 bytes) by value.
918 ScUndoReplace::ScUndoReplace( ScDocShell* pNewDocShell, ScMarkData
aMark,
919 SCCOL nCurX, SCROW nCurY, SCTAB
nCurZ,
920 OUString aNewUndoStr,
ScDocumentUniquePtr pNewUndoDoc,
921 const SvxSearchItem* pItem )
922 : ScSimpleUndo( pNewDocShell ),
923 aCursorPos ( nCurX, nCurY, nCurZ ),
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50ypSs1kiFPuCn2xFdlMIFBirii0zZ9j2-2F9F2XPBcBm2BNgi9duPy3v-2FzgFDd2LJ-2BDKI-3D4mg0_OTq2XUZbbipYjyLSo6GRo-2FpVxQ9OzkDINu9UTS-2FQhSdO0F0jQniitrGlNxDIzPJiJgvvqgkV6OxfdcC-2Ff1FVH-2BdtaL21ae2fVUJ3mVYlr8syIkaGJUnYeAwRT6czErlS1zCYpzyZi2mTrWCRaWLkal-2F5vW2aO5ZAl0LLrd0GsNtYp9S8Ko049vm4Vcjhn76FvJXPmW-2BVdXD16ujynx3blBii9UvN4LctDcD5RcGQ76c-3D
