[Libreoffice-commits] core.git: sc/source

[Luboš Luňák (via logerrit)]

 sc/source/core/opencl/formulagroupcl.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 19e64b69fe1327993e8eeec41572d9c258686965
Author:     Luboš Luňák <l.lu...@collabora.com>
AuthorDate: Tue Aug 30 15:44:26 2022 +0200
Commit:     Luboš Luňák <l.lu...@collabora.com>
CommitDate: Wed Aug 31 09:13:13 2022 +0200

    do not take strings for opencl <,>,<=,>= operations
    
    OpenCL code doesn't actually work on strings themselves, but only on their
    hashes. And comparing hashes doesn't necessarily have the same result
    as comparing the strings themselves.
    This is a part of preparation for removal of string handling in opencl,
    as the whole idea of handling strings in opencl is probably stupid.
    
    Change-Id: I8fa98bca0af14832f0d76135c1e195e1fb24451a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139050
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lu...@collabora.com>

diff --git a/sc/source/core/opencl/formulagroupcl.cxx 
b/sc/source/core/opencl/formulagroupcl.cxx
index 67f0da6eb3d6..b30fa97f854f 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -1546,7 +1546,7 @@ public:
             vSubArguments[1]->GenSlidingWindowDeclRef()) << ";\n\t";
         ss << "return tmp;\n}";
     }
-    virtual bool takeString() const override { return true; }
+    virtual bool takeString() const override { return false; }
     virtual bool takeNumeric() const override { return true; }
 };
 
@@ -1791,6 +1791,7 @@ public:
         return ss.str();
     }
     virtual std::string BinFuncName() const override { return "eq"; }
+    virtual bool takeString() const override { return true; }
 };
 
 class OpLessEqual : public Binary