sd/source/ui/framework/factories/BasicViewFactory.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
New commits: commit f5ce2df24a91796d6b8c732ad1a8ab3c5f736cde Author: Caolán McNamara <caol...@redhat.com> AuthorDate: Thu Sep 1 11:28:31 2022 +0100 Commit: Caolán McNamara <caol...@redhat.com> CommitDate: Thu Sep 1 15:01:20 2022 +0200 cid#1500537 silence Dereference after null check CreateView never return a null/empty Change-Id: I55829aff18f6ea3d508cfbd101ebcbf09ff37295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caol...@redhat.com> diff --git a/sd/source/ui/framework/factories/BasicViewFactory.cxx b/sd/source/ui/framework/factories/BasicViewFactory.cxx index 425cb44467f8..5e862c6aebc2 100644 --- a/sd/source/ui/framework/factories/BasicViewFactory.cxx +++ b/sd/source/ui/framework/factories/BasicViewFactory.cxx @@ -163,8 +163,7 @@ Reference<XResource> SAL_CALL BasicViewFactory::createResource ( pDescriptor = CreateView(rxViewId, *pFrame, *pWindow, xPane, pFrameView, bIsCenterPane); } - if (pDescriptor != nullptr) - xView = pDescriptor->mxView; + xView = pDescriptor->mxView; mpViewShellContainer->push_back(pDescriptor);