[Libreoffice-commits] core.git: filter/source

[Caolán McNamara (via logerrit)]

 filter/source/msfilter/svdfppt.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 552b46cdc5add38005a602172bd0143c562a6c4c
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Wed Sep 21 09:03:55 2022 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Wed Sep 21 13:29:28 2022 +0200

    cid#1515518 Dereference before null check
    
    and
    
    cid#1515520 Logically dead code
    
    Change-Id: If3eaece51004e3b05eaf123a3d80430ffc154be2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140308
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/filter/source/msfilter/svdfppt.cxx 
b/filter/source/msfilter/svdfppt.cxx
index a3d82924af6a..f0aed23a3363 100644
--- a/filter/source/msfilter/svdfppt.cxx
+++ b/filter/source/msfilter/svdfppt.cxx
@@ -1857,7 +1857,7 @@ rtl::Reference<SdrObject> SdrPowerPointImport::ImportOLE( 
sal_uInt32 nOLEId,
             if ( bSuccess )
             {
                 pDest->Seek(0);
-                Storage* pObjStor = pDest ? new Storage( *pDest, true ) : 
nullptr;
+                Storage* pObjStor = new Storage(*pDest, true);
                 if (pObjStor)
                 {
                     tools::SvRef<SotStorage> xObjStor( new SotStorage( 
pObjStor ) );