[Libreoffice-commits] core.git: svx/source vcl/source

[Stephan Bergmann (via logerrit)]

 svx/source/svdraw/svddrgmt.cxx         |    4 ++--
 vcl/source/filter/svm/SvmConverter.cxx |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 7079cf51a95c8efb1ba250e829bddfcaf6bbc132
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Thu Nov 10 18:48:08 2022 +0100
Commit:     Stephan Bergmann <sberg...@redhat.com>
CommitDate: Fri Nov 11 11:23:03 2022 +0100

    Revert useless std::move of const objects
    
    ...added with 8a843f7e98dfe6bfb04e91e5b16e3a1df18fbf58 "loplugin:moveit".
    
    (I came across this code with an upcoming loplugin:constmove that flags
    suspicious uses of std::move involving const-qualified types.)
    
    Change-Id: I099130acd67de7379992ce394226a7e233d6ca55
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142561
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sberg...@redhat.com>

diff --git a/svx/source/svdraw/svddrgmt.cxx b/svx/source/svdraw/svddrgmt.cxx
index 4a332e8271c7..37531632c5b4 100644
--- a/svx/source/svdraw/svddrgmt.cxx
+++ b/svx/source/svdraw/svddrgmt.cxx
@@ -2881,7 +2881,7 @@ void SdrDragCrook::createSdrDragEntries()
 
         if(aDragRaster.count())
         {
-            addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new 
SdrDragEntryPolyPolygon(std::move(aDragRaster))));
+            addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new 
SdrDragEntryPolyPolygon(aDragRaster)));
         }
     }
 
@@ -3412,7 +3412,7 @@ void SdrDragDistort::createSdrDragEntries()
 
         if(aDragRaster.count())
         {
-            addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new 
SdrDragEntryPolyPolygon(std::move(aDragRaster))));
+            addSdrDragEntry(std::unique_ptr<SdrDragEntry>(new 
SdrDragEntryPolyPolygon(aDragRaster)));
         }
     }
 
diff --git a/vcl/source/filter/svm/SvmConverter.cxx 
b/vcl/source/filter/svm/SvmConverter.cxx
index 063c6e45b505..0729a41c767e 100644
--- a/vcl/source/filter/svm/SvmConverter.cxx
+++ b/vcl/source/filter/svm/SvmConverter.cxx
@@ -550,7 +550,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
                     rMtf.AddAction( new MetaLineColorAction( COL_TRANSPARENT, 
false ) );
                     rMtf.AddAction( new MetaPolygonAction( aPoly ) );
                     rMtf.AddAction( new MetaPopAction() );
-                    rMtf.AddAction( new MetaPolyLineAction( std::move(aPoly), 
aLineInfo ) );
+                    rMtf.AddAction( new MetaPolyLineAction( aPoly, aLineInfo ) 
);
                 }
                 else
                     rMtf.AddAction( new MetaArcAction( aRect, aPt, aPt1 ) );
@@ -571,7 +571,7 @@ void SVMConverter::ImplConvertFromSVM1( SvStream& rIStm, 
GDIMetaFile& rMtf )
                     rMtf.AddAction( new MetaLineColorAction( COL_TRANSPARENT, 
false ) );
                     rMtf.AddAction( new MetaPolygonAction( aPoly ) );
                     rMtf.AddAction( new MetaPopAction() );
-                    rMtf.AddAction( new MetaPolyLineAction( std::move(aPoly), 
aLineInfo ) );
+                    rMtf.AddAction( new MetaPolyLineAction( aPoly, aLineInfo ) 
);
                 }
                 else
                     rMtf.AddAction( new MetaPieAction( aRect, aPt, aPt1 ) );