sc/qa/unit/helper/qahelper.cxx | 9 ---------
sc/qa/unit/helper/qahelper.hxx | 6 ------
sc/qa/unit/helper/shared_test_impl.hxx | 9 +++++++++
3 files changed, 9 insertions(+), 15 deletions(-)
New commits:
commit 4714b371809fb0e65073cbc95b4aafedb2c6a9ca
Author: Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Fri Nov 18 18:04:57 2022 +0100
Commit: Xisco Fauli <xiscofa...@libreoffice.org>
CommitDate: Fri Nov 18 21:09:44 2022 +0100
sc: move isFormulaWithoutError where is used
Change-Id: I846e1621b0ab82a921a12a0f1440ccb0e6c75215
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142951
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index a4af811db503..73250ba299e1 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -507,15 +507,6 @@ bool checkOutput(
return bResult;
}
-bool isFormulaWithoutError(ScDocument& rDoc, const ScAddress& rPos)
-{
- ScFormulaCell* pFC = rDoc.GetFormulaCell(rPos);
- if (!pFC)
- return false;
-
- return pFC->GetErrCode() == FormulaError::NONE;
-}
-
OUString toString(
ScDocument& rDoc, const ScAddress& rPos, ScTokenArray& rArray,
formula::FormulaGrammar::Grammar eGram)
{
diff --git a/sc/qa/unit/helper/qahelper.hxx b/sc/qa/unit/helper/qahelper.hxx
index e1e7ad4652e8..dd41622a579c 100644
--- a/sc/qa/unit/helper/qahelper.hxx
+++ b/sc/qa/unit/helper/qahelper.hxx
@@ -119,12 +119,6 @@ SCQAHELPER_DLLPUBLIC bool checkOutput(
const ScDocument* pDoc, const ScRange& aOutRange,
const std::vector<std::vector<const char*>>& aCheck, const char* pCaption
);
-/**
- * Check if the cell at specified position is a formula cell that doesn't
- * have an error value.
- */
-SCQAHELPER_DLLPUBLIC bool isFormulaWithoutError(ScDocument& rDoc, const
ScAddress& rPos);
-
/**
* Convert formula token array to a formula string.
*/
diff --git a/sc/qa/unit/helper/shared_test_impl.hxx
b/sc/qa/unit/helper/shared_test_impl.hxx
index 60aa4ae41571..33b6fe06a0f5 100644
--- a/sc/qa/unit/helper/shared_test_impl.hxx
+++ b/sc/qa/unit/helper/shared_test_impl.hxx
@@ -154,6 +154,15 @@ void testColorScale3Entry_Impl(const ScDocument& rDoc)
}
}
+bool isFormulaWithoutError(ScDocument& rDoc, const ScAddress& rPos)
+{
+ ScFormulaCell* pFC = rDoc.GetFormulaCell(rPos);
+ if (!pFC)
+ return false;
+
+ return pFC->GetErrCode() == FormulaError::NONE;
+}
+
void testFunctionsExcel2010_Impl( ScDocument& rDoc )
{
// Original test case document is functions-excel-2010.xlsx
