[Libreoffice-commits] core.git: svl/source

[Stephan Bergmann (via logerrit)]

 svl/source/items/sitem.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7a82ea5c79adee70eddf74ac53347544766a91b0
Author:     Stephan Bergmann <sberg...@redhat.com>
AuthorDate: Tue Nov 22 11:29:30 2022 +0100
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Tue Nov 22 18:52:42 2022 +0100

    Fix presumed typo
    
    ...introduced in 6cb400f41df0dd108cdb4b4d3ec6656844814147 "store the 
SfxItemSet
    inside SfxSetItem by value".  It appears to make more sense here to check 
that
    an SfxItemSet is not an SfxAllItemSet, than to check that an SfxSetItem is 
not
    an SfxAllItemSet.
    
    Change-Id: I292c2a88910db9852cf8ba7c61999c5f281ed14a
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143119
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/svl/source/items/sitem.cxx b/svl/source/items/sitem.cxx
index db738a2e4b37..a34b9ebff532 100644
--- a/svl/source/items/sitem.cxx
+++ b/svl/source/items/sitem.cxx
@@ -44,7 +44,7 @@ SfxSetItem::SfxSetItem( const SfxSetItem& rCopy, SfxItemPool 
*pPool ) :
     SfxPoolItem(rCopy),
     maSet(rCopy.maSet.CloneAsValue(true, pPool))
 {
-    assert(!dynamic_cast<const SfxAllItemSet*>(&rCopy) && "cannot handle 
SfxAllItemSet here");
+    assert(!dynamic_cast<const SfxAllItemSet*>(&rCopy.maSet) && "cannot handle 
SfxAllItemSet here");
 }