cui/source/tabpages/autocdlg.cxx | 2 -- 1 file changed, 2 deletions(-)
New commits: commit abdb918f146ceb6ea7d310968a96cdeb6f801a8f Author: Michael Weghorn <m.wegh...@posteo.de> AuthorDate: Wed Feb 22 09:53:06 2023 +0100 Commit: Michael Weghorn <m.wegh...@posteo.de> CommitDate: Wed Feb 22 11:00:58 2023 +0000 tdf#142942 Drop unused checkbox col in sw AutoCorrect opts dialog While the extra checkbox column enabled by weld::TreeView::enable_toggle_buttons(weld::ColumnToggleType::Check) is used for the non-Writer case in the "Options" and "Localized Options" tabs in the AutoCorrect options dialog, they are not used in the case of Writer, where there are two columns of checkboxes handled separately ("[M]: Replace while modifying existing text" and "[T]: AutoCorrect while typing"). Before commit 714b2b617e9baef02510c482c6fd028e6e72acd8 Date: Tue Jun 30 15:03:31 2020 +0100 tdf#134270 rearrange so we know the final treeview width , setting column widths manually by calling `weld::TreeView::set_column_fixed_widths` would disable the extra space for the (unused) checkboxes (by setting `m_bDisableCheckBoxAutoWidth`). Since that commit, it no longer does, causing the separately handled real checkbox in the first visible column to be unnecessarily positioned further to the right in this dialog for Writer for the non-gtk case. Fix this by dropping the use of the unused checkbox column for the Writer case, i.e. the `bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and in `OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage`. The handling for the non-Writer modules (i.e. `!bShowSWOptions` case in `OfaQuoteTabPage::OfaQuoteTabPage` and `OfaAutocorrOptionsPage`) remains unchanged. Change-Id: If7bd216fc4efda506817cffb55230722bb2ac89b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147454 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.wegh...@posteo.de> diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index 2c978a835922..bc3f3bcc7be7 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -375,7 +375,6 @@ OfaSwAutoFmtOptionsPage::OfaSwAutoFmtOptionsPage(weld::Container* pPage, weld::D { m_xCheckLB->connect_changed(LINK(this, OfaSwAutoFmtOptionsPage, SelectHdl)); m_xCheckLB->connect_row_activated(LINK(this, OfaSwAutoFmtOptionsPage, DoubleClickEditHdl)); - m_xCheckLB->enable_toggle_buttons(weld::ColumnToggleType::Check); std::vector<int> aWidths { @@ -1586,7 +1585,6 @@ OfaQuoteTabPage::OfaQuoteTabPage(weld::Container* pPage, weld::DialogController* if ( bShowSWOptions ) { - m_xSwCheckLB->enable_toggle_buttons(weld::ColumnToggleType::Check); std::vector<int> aWidths { o3tl::narrowing<int>(m_xSwCheckLB->get_pixel_size(m_xSwCheckLB->get_column_title(0)).Width() * 2),