[Libreoffice-commits] core.git: 2 commits - sw/source vcl/jsdialog

[Caolán McNamara (via logerrit)]

 sw/source/uibase/uiview/view2.cxx |    4 ++--
 vcl/jsdialog/executor.cxx         |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit ee5f8b0bb59f974293a1810b5163ecc0cab6cc09
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Wed Mar 8 12:07:42 2023 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Wed Mar 8 19:54:26 2023 +0000

    cid#1521854 Unchecked return value
    
    Change-Id: I2636790165b2fc0d535d4b8648e16751a0b69e23
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148470
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/sw/source/uibase/uiview/view2.cxx 
b/sw/source/uibase/uiview/view2.cxx
index fea09391a051..48f38beb99f7 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -1243,8 +1243,8 @@ void SwView::Execute(SfxRequest &rReq)
                 const SwTOXBase* pBase = m_pWrtShell->GetCurTOX();
                 if( !pBase )
                 {
-                    m_pWrtShell->GotoNextTOXBase();
-                    pBase = m_pWrtShell->GetCurTOX();
+                    if (m_pWrtShell->GotoNextTOXBase())
+                        pBase = m_pWrtShell->GetCurTOX();
                 }
 
                 bool bAutoMarkApplied = false;
commit fa0f8dd9d3dcbbee2d8c23341981635f9c55e55f
Author:     Caolán McNamara <caol...@redhat.com>
AuthorDate: Wed Mar 8 12:03:35 2023 +0000
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Wed Mar 8 19:54:15 2023 +0000

    cid#1521852 Unchecked dynamic_cast
    
    Change-Id: Iec5f58101ca65665d6782e769a5a58765c9e6d37
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148469
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caol...@redhat.com>

diff --git a/vcl/jsdialog/executor.cxx b/vcl/jsdialog/executor.cxx
index be17d4ef353c..313661557893 100644
--- a/vcl/jsdialog/executor.cxx
+++ b/vcl/jsdialog/executor.cxx
@@ -143,7 +143,7 @@ bool ExecuteAction(const std::string& nWindowId, const 
OString& rWidget, StringM
                 }
                 else if (sAction == "toggle")
                 {
-                    
LOKTrigger::trigger_toggled(*dynamic_cast<weld::Toggleable*>(pWidget));
+                    
LOKTrigger::trigger_toggled(dynamic_cast<weld::Toggleable&>(*pWidget));
                     return true;
                 }
             }