[Libreoffice-commits] core.git: sot/qa

[Miklos Vajna (via logerrit)]

 sot/qa/cppunit/test_sot.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 34504d2496a32f64952ec434ce1ac30ee2d9fb66
Author:     Miklos Vajna <vmik...@collabora.com>
AuthorDate: Tue Mar 14 12:12:39 2023 +0100
Commit:     Miklos Vajna <vmik...@collabora.com>
CommitDate: Tue Mar 14 15:28:45 2023 +0000

    CppunitTest_sot_test_sot: remove duplicated assert
    
    This was added in commit 29d4ecf32392bc94ab0ba9e73fd79eba65c23fdb
    (tdf#115574 sot: fix Excel -> Writer paste, 2018-03-29), where it was
    hard to consider 4 bugreports at the same time, so I wrote asserts for
    each bugreport. But at the end 1 bugreport is a superset of an other
    one, so just moving the 2 comments next to each other having 2 asserts
    instead of 3 leads to a simple removal of the duplication.
    
    Change-Id: Iaedccf5ac498dd6842c25b60b507e63332daddf9
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148847
    Reviewed-by: Miklos Vajna <vmik...@collabora.com>
    Tested-by: Jenkins

diff --git a/sot/qa/cppunit/test_sot.cxx b/sot/qa/cppunit/test_sot.cxx
index 74f0771851d5..7fd1b9a6c18f 100644
--- a/sot/qa/cppunit/test_sot.cxx
+++ b/sot/qa/cppunit/test_sot.cxx
@@ -171,7 +171,6 @@ namespace
     {
         const SotAction_Impl* pFormats = 
sot::GetExchangeDestinationWriterFreeAreaCopy();
         // tdf#52547 prefer BITMAP over HTML
-        CPPUNIT_ASSERT(FindFormatIndex(pFormats, SotClipboardFormatId::BITMAP) 
< FindFormatIndex(pFormats, SotClipboardFormatId::HTML));
         // tdf#78801 prefer image over html over text
         CPPUNIT_ASSERT(FindFormatIndex(pFormats, SotClipboardFormatId::BITMAP) 
< FindFormatIndex(pFormats, SotClipboardFormatId::HTML));
         CPPUNIT_ASSERT(FindFormatIndex(pFormats, SotClipboardFormatId::HTML) < 
FindFormatIndex(pFormats, SotClipboardFormatId::STRING));