sw/source/uibase/app/docsh2.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 1b93a30a113e45cbf67b0683e233568e40446deb
Author:     Xisco Fauli <xiscofa...@libreoffice.org>
AuthorDate: Thu Mar 16 16:26:17 2023 +0100
Commit:     Caolán McNamara <caol...@redhat.com>
CommitDate: Sat Mar 18 21:55:36 2023 +0000

    sw: fix null dereference
    
    See 
https://crashreport.libreoffice.org/stats/signature/SfxDispatcher::ExecuteList(unsigned%20short,SfxCallMode,std::initializer_list%3CSfxPoolItem%20const%20*%3E,std::initializer_list%3CSfxPoolItem%20const%20*%3E)
    
    Change-Id: I7f5471f003798f260d9d015782bd2a798baa22d2
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148999
    Reviewed-by: Caolán McNamara <caol...@redhat.com>
    Tested-by: Jenkins
    Reviewed-by: Xisco Fauli <xiscofa...@libreoffice.org>
    (cherry picked from commit 11ce7e810ef5ba540afe676d58575fabf4ab386d)
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149019

diff --git a/sw/source/uibase/app/docsh2.cxx b/sw/source/uibase/app/docsh2.cxx
index e5b7b63c43d0..83ea01b75b91 100644
--- a/sw/source/uibase/app/docsh2.cxx
+++ b/sw/source/uibase/app/docsh2.cxx
@@ -1185,11 +1185,12 @@ void SwDocShell::Execute(SfxRequest& rReq)
                 // Ok.  I did my best.
                 break;
 
-            SfxStringItem aApp(SID_DOC_SERVICE, 
"com.sun.star.text.TextDocument");
-            SfxStringItem aTarget(SID_TARGETNAME, "_blank");
-            pViewShell->GetDispatcher()->ExecuteList(SID_OPENDOC,
-                SfxCallMode::API|SfxCallMode::SYNCHRON,
-                { &aApp, &aTarget });
+            if (SfxDispatcher* pDispatch = pViewShell->GetDispatcher())
+            {
+                SfxStringItem aApp(SID_DOC_SERVICE, 
"com.sun.star.text.TextDocument");
+                SfxStringItem aTarget(SID_TARGETNAME, "_blank");
+                pDispatch->ExecuteList(SID_OPENDOC, 
SfxCallMode::API|SfxCallMode::SYNCHRON, { &aApp, &aTarget });
+            }
         }
         break;
         case SID_CLASSIFICATION_APPLY:

Reply via email to