[Libreoffice-commits] core.git: svx/source

[Noel Grandin (via logerrit)]

 svx/source/svdraw/svdmodel.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 41741d0417a11ab3033e4dc6c899646d42871546
Author:     Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Mon Apr 17 11:40:55 2023 +0200
Commit:     Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Mon Apr 17 14:57:01 2023 +0200

    tdf#154473 remove assert
    
    so the commit that caused this:
        commit 8611f6e259b807b4f19c8dc0eab86ca648891ce3
        Author: Noel Grandin <noel.gran...@collabora.co.uk>
        Date:   Thu May 27 10:27:46 2021 +0200
        ref-count SdrObject
    did its job - we have far fewer crashes due to accessing dead SdrObjects
    - but the wide variety of other, smaller leaks, means that sometimes
    we have leaks of SdrObjects too.
    
    So just remove this assert for now (but leave the warning in DBG_UTIL
    mode in)
    
    Change-Id: I2123ba0f28a0cb4356eab3cbf34c8b67d785c516
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150486
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>

diff --git a/svx/source/svdraw/svdmodel.cxx b/svx/source/svdraw/svdmodel.cxx
index c3716a4a3efa..7bf82ca9747f 100644
--- a/svx/source/svdraw/svdmodel.cxx
+++ b/svx/source/svdraw/svdmodel.cxx
@@ -224,7 +224,6 @@ SdrModel::~SdrModel()
         for (const auto & pObj : maAllIncarnatedObjects)
             SAL_WARN("svx", "leaked instance of " << typeid(*pObj).name());
     }
-    assert(maAllIncarnatedObjects.empty());
 #endif
 
     m_pLayerAdmin.reset();