sd/source/ui/func/futext.cxx | 3 +++
1 file changed, 3 insertions(+)
New commits:
commit 0c421a9aa3210d3bafdc8bb5e0d79cc1b58b4b33
Author: Justin Luth <jl...@mail.com>
AuthorDate: Wed Jul 5 19:09:57 2023 -0400
Commit: Justin Luth <jl...@mail.com>
CommitDate: Thu Jul 13 23:20:26 2023 +0200
tdf#153446 sd FuText: handle mouse-up without mouse-down
This is a follow-up to the previous commit which did the same
thing to all of the other FuConstruct elements.
It isn't essential to have for FuText, just nice for consistency.
FuText is much more complex than the other FuConstructs,
and has been this complex since initial import.
In patchset1, I removed a large chunk of code that I assume
is now obsolete with my change, but now I just left it in.
Without any documentation or unit tests, it is hard to know
for sure why this function creates a textbox on mouse-up.
So I chickened out and did the smart thing of just leaving
stuff I don't know anything at all about alone.
Change-Id: I105178e6af343eed505a803c6c3642eec073f6a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154083
Tested-by: Jenkins
Reviewed-by: Justin Luth <jl...@mail.com>
diff --git a/sd/source/ui/func/futext.cxx b/sd/source/ui/func/futext.cxx
index 5639d424b8b1..48c166792e70 100644
--- a/sd/source/ui/func/futext.cxx
+++ b/sd/source/ui/func/futext.cxx
@@ -604,6 +604,9 @@ bool FuText::MouseButtonUp(const MouseEvent& rMEvt)
}
}
+ if (rMEvt.IsLeft() && !mxTextObj.get().is() &&
IsIgnoreUnexpectedMouseButtonUp())
+ return false;
+
if( mpView && mpView->IsDragObj())
{
// object was moved
