compilerplugins/clang/unusedfields.only-used-in-constructor.results | 46
++-----
compilerplugins/clang/unusedfields.readonly.results | 16 +-
compilerplugins/clang/unusedfields.untouched.results | 20 +--
compilerplugins/clang/unusedfields.writeonly.results | 62
++++------
vcl/source/gdi/pdfextoutdevdata.cxx | 2
xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx | 6
6 files changed, 60 insertions(+), 92 deletions(-)
New commits:
commit a66b9c9adfb2306a021cd286c8346dd1058499ce
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Fri Jul 21 11:52:24 2023 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Fri Jul 21 22:16:34 2023 +0200
loplugin:unusedfields
Change-Id: Ic2e9de67a00bb9ca8ab4d0f7528b22c58d0cc360
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154721
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git
a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index d897f095b3c2..01db79dd80aa 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -16,7 +16,7 @@ binaryurp/source/writer.hxx:135
binaryurp::Writer state_ WriterState
canvas/source/tools/surfaceproxy.hxx:104
canvas::SurfaceProxy mpPageManager PageManagerSharedPtr
-canvas/source/vcl/impltools.hxx:114
+canvas/source/vcl/impltools.hxx:119
vclcanvas::tools::LocalGuard aSolarGuard SolarMutexGuard
chart2/source/controller/accessibility/AccessibleChartShape.hxx:78
chart::AccessibleChartShape m_aShapeTreeInfo
::accessibility::AccessibleShapeTreeInfo
@@ -140,7 +140,7 @@ cppu/source/uno/check.cxx:267
(anonymous namespace)::Char4 chars Char3
cui/source/dialogs/colorpicker.cxx:748
cui::(anonymous namespace)::ColorPickerDialog m_aColorPrevious
ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1240
+cui/source/factory/dlgfact.cxx:1245
(anonymous namespace)::SvxMacroAssignDialog_Impl m_aItems SfxItemSet
cui/source/inc/AdditionsDialog.hxx:47
AdditionInfo sReleaseVersion OUString
@@ -586,9 +586,9 @@ sc/inc/token.hxx:402
SingleDoubleRefModifier aDub ScComplexRefData
sc/qa/unit/tiledrendering/tiledrendering.cxx:439
(anonymous namespace)::ViewCallback m_callbackWrapper
TestLokCallbackWrapper
-sc/source/core/data/document.cxx:1252
+sc/source/core/data/document.cxx:1217
(anonymous namespace)::BroadcastRecalcOnRefMoveGuard aSwitch
sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1253
+sc/source/core/data/document.cxx:1218
(anonymous namespace)::BroadcastRecalcOnRefMoveGuard aBulk ScBulkBroadcast
sc/source/core/data/table2.cxx:812
(anonymous namespace)::TransClipHandler mnEndRow size_t
@@ -810,7 +810,7 @@
svx/source/customshapes/EnhancedCustomShapeFunctionParser.cxx:1098
(anonymous namespace)::ExpressionGrammar::definition identifier
::boost::spirit::classic::rule<ScannerT>
svx/source/dialog/contimp.hxx:75
SvxSuperContourDlg aContourItem SvxContourDlgItem
-svx/source/dialog/framelinkarray.cxx:520
+svx/source/dialog/framelinkarray.cxx:515
svx::frame::(anonymous namespace)::MergedCellIterator mnFirstRow sal_Int32
svx/source/dialog/imapwnd.hxx:88
IMapWindow maItemInfos SfxItemInfo[1]
@@ -832,8 +832,6 @@ sw/inc/unosett.hxx:144
SwXNumberingRules m_pImpl ::sw::UnoImplPtr<Impl>
sw/qa/core/test_ToxTextGenerator.cxx:140
(anonymous namespace)::ToxTextGeneratorWithMockedChapterField
mChapterFieldType SwChapterFieldType
-sw/qa/extras/rtfimport/rtfimport.cxx:73
- Test m_aSavedSettings AllSettings
sw/qa/extras/uiwriter/uiwriter5.cxx:66
SwUiWriterTest5 m_aSavedSettings AllSettings
sw/qa/extras/uiwriter/uiwriter7.cxx:2286
@@ -878,8 +876,6 @@ sw/source/uibase/inc/uivwimp.hxx:95
SwView_Impl m_xTmpSelDocShell SfxObjectShellLock
sw/source/uibase/inc/unodispatch.hxx:43
SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard
SolarMutexGuard
-sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx:91
- sw::sidebar::A11yCheckIssuesPanel m_getIssueCollection
std::function<sfx::AccessibilityIssueCollection (void)>
toolkit/source/awt/stylesettings.cxx:74
toolkit::(anonymous namespace)::StyleMethodGuard m_aGuard SolarMutexGuard
ucb/source/ucp/gio/gio_mount.hxx:73
@@ -896,7 +892,7 @@ vcl/inc/graphic/Manager.hxx:42
vcl::graphic::Manager maSwapOutTimer Timer
vcl/inc/headless/BitmapHelper.hxx:32
BitmapHelper aTmpBmp SvpSalBitmap
-vcl/inc/jsdialog/jsdialogbuilder.hxx:702
+vcl/inc/jsdialog/jsdialogbuilder.hxx:716
JSToolbar m_pPopovers std::map<sal_uInt16, weld::Widget *>
vcl/inc/pdf/pdfbuildin_fonts.hxx:34
vcl::pdf::BuildinFont m_nAscent const int
@@ -906,9 +902,9 @@ vcl/inc/pdf/pdfbuildin_fonts.hxx:42
vcl::pdf::BuildinFont m_aWidths const int[256]
vcl/inc/salprn.hxx:45
SalPrinterQueueInfo moPortName std::optional<OUString>
-vcl/inc/salvtables.hxx:615
+vcl/inc/salvtables.hxx:616
SalInstanceEntry m_aTextFilter WeldTextFilter
-vcl/inc/salvtables.hxx:1006
+vcl/inc/salvtables.hxx:1007
SalInstanceComboBoxWithEdit m_aTextFilter WeldTextFilter
vcl/inc/sft.hxx:177
vcl::TTGlobalFontInfo_ fsSelection sal_uInt16
@@ -928,27 +924,11 @@ vcl/inc/unx/i18n_ic.hxx:45
SalI18N_InputContext maSwitchIMCallback XIMCallback
vcl/inc/unx/i18n_ic.hxx:46
SalI18N_InputContext maDestroyCallback XIMCallback
-vcl/inc/unx/saldisp.hxx:79
- SalVisual eRGBMode_ SalRGB
-vcl/inc/unx/saldisp.hxx:80
- SalVisual nRedShift_ int
-vcl/inc/unx/saldisp.hxx:81
- SalVisual nGreenShift_ int
-vcl/inc/unx/saldisp.hxx:82
- SalVisual nBlueShift_ int
-vcl/inc/unx/saldisp.hxx:83
- SalVisual nRedBits_ int
-vcl/inc/unx/saldisp.hxx:84
- SalVisual nGreenBits_ int
-vcl/inc/unx/saldisp.hxx:85
- SalVisual nBlueBits_ int
-vcl/inc/unx/saldisp.hxx:116
+vcl/inc/unx/saldisp.hxx:104
SalColormap m_aPalette std::vector<Color>
-vcl/inc/unx/saldisp.hxx:119
- SalColormap m_aLookupTable std::vector<sal_uInt16>
-vcl/inc/unx/saldisp.hxx:122
+vcl/inc/unx/saldisp.hxx:109
SalColormap m_nUsed Pixel
-vcl/source/app/salvtables.cxx:247
+vcl/source/app/salvtables.cxx:246
SalFlashAttention m_aOrigBackground Wallpaper
vcl/source/fontsubset/ttcr.hxx:40
vcl::longHorMetrics aw sal_uInt16
@@ -958,6 +938,8 @@ vcl/source/gdi/jobset.cxx:39
(anonymous namespace)::ImplOldJobSetupData cDeviceName char[32]
vcl/source/gdi/jobset.cxx:40
(anonymous namespace)::ImplOldJobSetupData cPortName char[32]
+vcl/source/gdi/pdfextoutdevdata.cxx:107
+ vcl::GlobalSyncData mStructIdMap std::vector<sal_Int32>
vcl/source/pdf/PDFiumLibrary.cxx:430
vcl::pdf::(anonymous namespace)::PDFiumDocumentImpl m_aFormCallbacks
FPDF_FORMFILLINFO
vcl/unx/gtk3/a11y/atkhypertext.cxx:31
@@ -990,3 +972,5 @@ xmloff/inc/XMLThemeContext.hxx:46
XMLThemeColorsContext m_aColorScheme std::vector<css::util::Color>
xmloff/source/text/XMLTextListBlockContext.hxx:40
XMLTextListBlockContext mbSetDefaults _Bool
+xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx:87
+ (anonymous namespace)::SaveODFItem m_nODF sal_Int16
diff --git a/compilerplugins/clang/unusedfields.readonly.results
b/compilerplugins/clang/unusedfields.readonly.results
index b4dfd0424e77..039b33e6f4a5 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -262,7 +262,7 @@ extensions/source/propctrlr/eformshelper.hxx:60
pcr::EFormsHelper m_aSubmissionUINames MapStringToPropertySet
extensions/source/propctrlr/eformshelper.hxx:62
pcr::EFormsHelper m_aBindingUINames MapStringToPropertySet
-extensions/source/update/check/updatehdl.hxx:90
+extensions/source/update/check/updatehdl.hxx:89
UpdateHandler mbStringsLoaded _Bool
filter/source/graphicfilter/icgm/chart.hxx:48
DataNode nBoxX1 sal_Int16
@@ -520,11 +520,13 @@ sc/source/filter/inc/stylesbuffer.hxx:777
oox::xls::CellStyleBuffer maBuiltinStyles CellStyleVector
sc/source/filter/inc/stylesbuffer.hxx:778
oox::xls::CellStyleBuffer maUserStyles CellStyleVector
-sc/source/filter/inc/XclExpChangeTrack.hxx:348
+sc/source/filter/inc/XclExpChangeTrack.hxx:349
XclExpChTrAction pAddAction std::unique_ptr<XclExpChTrAction>
sc/source/filter/inc/xepage.hxx:121
XclExpChartPageSettings maData XclPageData
-sc/source/filter/inc/xestyle.hxx:380
+sc/source/filter/inc/xestyle.hxx:352
+ XclExpCellBorder maComplexColorDiagonal model::ComplexColor
+sc/source/filter/inc/xestyle.hxx:386
XclExpCellArea maBackgroundComplexColor model::ComplexColor
sc/source/filter/inc/xistyle.hxx:518
XclImpXFBuffer maBuiltinStyles XclImpStyleList
@@ -664,6 +666,8 @@ sw/inc/swmodule.hxx:91
SwModule m_pAccessibilityOptions std::unique_ptr<SvtAccessibilityOptions>
sw/inc/swmodule.hxx:92
SwModule m_pCTLOptions std::unique_ptr<SvtCTLOptions>
+sw/qa/api/SwXHeadFootText.cxx:72
+ (anonymous namespace)::SwXHeadFootTextText mxTextContent
Reference<text::XTextContent>
sw/source/core/access/accfrmobjmap.hxx:100
SwAccessibleChildMap maMap std::map<key_type, mapped_type, key_compare>
sw/source/core/access/acchypertextdata.hxx:40
@@ -676,9 +680,9 @@ sw/source/core/access/accmap.cxx:625
SwAccessibleEventMap_Impl maMap std::map<key_type, mapped_type,
key_compare>
sw/source/core/access/accmap.cxx:669
SwAccessibleSelectedParas_Impl maMap std::map<key_type, mapped_type,
key_compare>
-sw/source/core/doc/swstylemanager.cxx:61
- (anonymous namespace)::SwStyleManager m_aAutoCharPool StylePool
sw/source/core/doc/swstylemanager.cxx:62
+ (anonymous namespace)::SwStyleManager m_aAutoCharPool StylePool
+sw/source/core/doc/swstylemanager.cxx:63
(anonymous namespace)::SwStyleManager m_aAutoParaPool StylePool
sw/source/core/inc/swblocks.hxx:69
SwImpBlocks m_bInPutMuchBlocks _Bool
@@ -806,7 +810,7 @@ vcl/inc/svdata.hxx:327
ImplSVNWFData mbNoFrameJunctionForPopups _Bool
vcl/inc/toolbox.h:109
vcl::ToolBoxLayoutData m_aLineItemIds std::vector<ToolBoxItemId>
-vcl/inc/unx/saldisp.hxx:261
+vcl/inc/unx/saldisp.hxx:248
SalDisplay m_aInvalidScreenData ScreenData
vcl/inc/widgetdraw/WidgetDefinition.hxx:224
vcl::WidgetDefinitionStyle maDefaultButtonTextColor Color
diff --git a/compilerplugins/clang/unusedfields.untouched.results
b/compilerplugins/clang/unusedfields.untouched.results
index 228e46a45f33..9c0eab199768 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -8,7 +8,7 @@ basic/qa/cppunit/test_global_as_new.cxx:25
(anonymous namespace)::GlobalAsNewTest lib BasicDLL
canvas/source/vcl/canvasbitmap.hxx:113
vclcanvas::CanvasBitmap mxDevice
css::uno::Reference<css::rendering::XGraphicDevice>
-canvas/source/vcl/impltools.hxx:114
+canvas/source/vcl/impltools.hxx:119
vclcanvas::tools::LocalGuard aSolarGuard SolarMutexGuard
chart2/source/controller/inc/dlg_DataEditor.hxx:55
chart::DataEditor m_xContext
css::uno::Reference<css::uno::XComponentContext>
@@ -390,13 +390,13 @@ sc/inc/mtvelements.hxx:171
sc::ColumnBlockConstPosition miSparklinePos
SparklineStoreType::const_iterator
sc/inc/SolverSettings.hxx:168
sc::SolverSettings SolverCodesToLOEngines std::map<OUString, OUString>
-sc/source/core/data/document.cxx:1252
+sc/source/core/data/document.cxx:1217
(anonymous namespace)::BroadcastRecalcOnRefMoveGuard aSwitch
sc::AutoCalcSwitch
-sc/source/core/data/document.cxx:1253
+sc/source/core/data/document.cxx:1218
(anonymous namespace)::BroadcastRecalcOnRefMoveGuard aBulk ScBulkBroadcast
sc/source/filter/inc/sheetdatacontext.hxx:50
oox::xls::SheetDataContext aReleaser SolarMutexReleaser
-sc/source/ui/inc/docsh.hxx:456
+sc/source/ui/inc/docsh.hxx:457
ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
sc/source/ui/inc/PivotLayoutTreeListBase.hxx:47
ScPivotLayoutTreeListBase maDropTargetHelper ScPivotLayoutTreeDropTarget
@@ -478,8 +478,6 @@ svx/source/sidebar/fontwork/FontworkPropertyPanel.hxx:41
svx::sidebar::FontworkPropertyPanel m_xToolbar
std::unique_ptr<ToolbarUnoDispatcher>
svx/source/tbxctrls/layctrl.cxx:432
(anonymous namespace)::ColumnsWindow mxControl
rtl::Reference<SvxColumnsToolBoxControl>
-sw/qa/extras/rtfimport/rtfimport.cxx:73
- Test m_aSavedSettings AllSettings
sw/qa/extras/uiwriter/uiwriter5.cxx:66
SwUiWriterTest5 m_aSavedSettings AllSettings
sw/source/core/crsr/crbm.cxx:62
@@ -508,12 +506,12 @@ sw/source/uibase/inc/pagenumberdlg.hxx:31
SwPageNumberDlg m_xCancel std::unique_ptr<weld::Button>
sw/source/uibase/inc/swuicnttab.hxx:243
SwTokenWindow m_aAdjustPositionsIdle Idle
+sw/source/uibase/inc/titlepage.hxx:34
+ SwTitlePageDlg m_xInsertNewPagesRB std::unique_ptr<weld::RadioButton>
sw/source/uibase/inc/uivwimp.hxx:95
SwView_Impl m_xTmpSelDocShell SfxObjectShellLock
sw/source/uibase/inc/unodispatch.hxx:43
SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard
SolarMutexGuard
-sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx:91
- sw::sidebar::A11yCheckIssuesPanel m_getIssueCollection
std::function<sfx::AccessibilityIssueCollection (void)>
sw/source/uibase/sidebar/ThemePanel.hxx:41
sw::sidebar::ThemePanel mxListBoxFonts std::unique_ptr<weld::TreeView>
toolkit/source/awt/stylesettings.cxx:74
@@ -524,7 +522,7 @@ unoidl/source/unoidlprovider.cxx:676
unoidl::detail::(anonymous namespace)::UnoidlCursor reference2_
rtl::Reference<UnoidlModuleEntity>
uui/source/openlocked.hxx:36
vcl::OpenLockedQueryBox mxQuestionMarkImage std::unique_ptr<weld::Image>
-vcl/inc/jsdialog/jsdialogbuilder.hxx:702
+vcl/inc/jsdialog/jsdialogbuilder.hxx:716
JSToolbar m_pPopovers std::map<sal_uInt16, weld::Widget *>
vcl/inc/pdf/pdfbuildin_fonts.hxx:34
vcl::pdf::BuildinFont m_nAscent const int
@@ -536,9 +534,7 @@ vcl/inc/salprn.hxx:45
SalPrinterQueueInfo moPortName std::optional<OUString>
vcl/inc/sft.hxx:177
vcl::TTGlobalFontInfo_ fsSelection sal_uInt16
-vcl/inc/unx/saldisp.hxx:119
- SalColormap m_aLookupTable std::vector<sal_uInt16>
-vcl/source/app/salvtables.cxx:247
+vcl/source/app/salvtables.cxx:246
SalFlashAttention m_aOrigBackground Wallpaper
vcl/source/fontsubset/ttcr.hxx:40
vcl::longHorMetrics aw sal_uInt16
diff --git a/compilerplugins/clang/unusedfields.writeonly.results
b/compilerplugins/clang/unusedfields.writeonly.results
index 49ca3f590cf7..098cd9e859a5 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -556,7 +556,7 @@ include/svx/srchdlg.hxx:167
SvxSearchDialog pOptionsController std::unique_ptr<SvxSearchController>
include/svx/svdmrkv.hxx:99
SdrMarkView mpMarkingSubSelectionOverlay
std::unique_ptr<MarkingSubSelectionOverlay>
-include/svx/tbcontrl.hxx:266
+include/svx/tbcontrl.hxx:265
SvxCurrencyToolBoxControl::SvxCurrencyData m_onlyIsoCode _Bool
include/svx/theme/ThemeColorPaletteManager.hxx:43
svx::ThemePaletteColorData maBaseColor Color
@@ -710,12 +710,12 @@ sc/inc/scmod.hxx:100
ScModule m_pErrorHdl std::unique_ptr<SfxErrorHandler>
sc/inc/tabopparams.hxx:37
ScInterpreterTableOpParams bValid _Bool
-sc/qa/unit/subsequent_export_test.cxx:2161
- (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2159:18) mnRow
SCROW
-sc/qa/unit/subsequent_export_test.cxx:2162
- (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2159:18) mnStyle
SvxBorderLineStyle
-sc/qa/unit/subsequent_export_test.cxx:2163
- (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2159:18) mnWidth
tools::Long
+sc/qa/unit/subsequent_export_test.cxx:2167
+ (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2165:18) mnRow
SCROW
+sc/qa/unit/subsequent_export_test.cxx:2168
+ (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2165:18) mnStyle
SvxBorderLineStyle
+sc/qa/unit/subsequent_export_test.cxx:2169
+ (unnamed struct at
/home/noel/libo-plugin/sc/qa/unit/subsequent_export_test.cxx:2165:18) mnWidth
tools::Long
sc/source/core/data/column4.cxx:1449
(anonymous namespace)::StartListeningFormulaCellsHandler mnStartRow SCROW
sc/source/core/data/column.cxx:1312
@@ -864,7 +864,7 @@ sd/source/ui/slidesorter/controller/SlsListener.hxx:140
sd::slidesorter::controller::Listener mpModelChangeLock
std::shared_ptr<SlideSorterController::ModelChangeLock>
sd/source/ui/slidesorter/inc/controller/SlsClipboard.hxx:114
sd::slidesorter::controller::Clipboard mxUndoContext
std::unique_ptr<UndoContext>
-sd/source/ui/view/ToolBarManager.cxx:317
+sd/source/ui/view/ToolBarManager.cxx:318
sd::ToolBarManager::Implementation mpAsynchronousLayouterLock
::std::unique_ptr<LayouterLock>
sfx2/inc/commandpopup/CommandPopup.hxx:108
CommandPopupHandler mpListBox std::unique_ptr<CommandListBox>
@@ -872,7 +872,7 @@ sfx2/inc/notebookbar/NotebookbarTabControl.hxx:42
NotebookbarTabControl m_pListener
css::uno::Reference<css::ui::XUIConfigurationListener>
sfx2/source/appl/fileobj.hxx:40
SvFileObject mxDelMed tools::SvRef<SfxMedium>
-sfx2/source/doc/sfxbasemodel.cxx:457
+sfx2/source/doc/sfxbasemodel.cxx:471
(anonymous namespace)::SfxSaveGuard m_pFramesLock
std::unique_ptr<SfxOwnFramesLocker>
sfx2/source/inc/appdata.hxx:68
SfxAppData_Impl maDocTopics std::vector<SfxDdeDocTopic_Impl *>
@@ -930,6 +930,8 @@ store/source/storbios.cxx:52
(anonymous namespace)::OStoreSuperBlock m_aMarked L
svgio/inc/svgcharacternode.hxx:84
svgio::svgreader::SvgTextPosition maY ::std::vector<double>
+svgio/inc/svgdocument.hxx:38
+ svgio::svgreader::SvgDocument maOrphanNodes SvgNodeVector
svgio/inc/svgsvgnode.hxx:41
svgio::svgreader::SvgSvgNode maVersion SvgNumber
svgio/inc/svgsymbolnode.hxx:32
@@ -1004,7 +1006,7 @@ svx/source/inc/docrecovery.hxx:132
svx::DocRecovery::TURLInfo Module OUString
svx/source/inc/StylesPreviewToolBoxControl.hxx:33
StylesPreviewToolBoxControl m_xWeldBox
std::unique_ptr<StylesPreviewWindow_Base>
-svx/source/inc/StylesPreviewWindow.hxx:105
+svx/source/inc/StylesPreviewWindow.hxx:106
StylesPreviewWindow_Base m_pStylePoolChangeListener
std::unique_ptr<StylePoolChangeListener>
svx/source/sdr/attribute/sdrformtextattribute.cxx:152
drawinglayer::attribute::ImpSdrFormTextAttribute mnFormTextShdwTransp
sal_uInt16
@@ -1073,24 +1075,22 @@ svx/source/sidebar/text/TextPropertyPanel.hxx:53
svx/source/sidebar/text/TextPropertyPanel.hxx:55
svx::sidebar::TextPropertyPanel mxFontAdjustDispatch
std::unique_ptr<ToolbarUnoDispatcher>
svx/source/sidebar/text/TextPropertyPanel.hxx:57
- svx::sidebar::TextPropertyPanel mxToolBoxFontColorSwDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:59
svx::sidebar::TextPropertyPanel mxToolBoxFontColorDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:61
+svx/source/sidebar/text/TextPropertyPanel.hxx:59
svx::sidebar::TextPropertyPanel mxToolBoxBackgroundColorDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:63
+svx/source/sidebar/text/TextPropertyPanel.hxx:61
svx::sidebar::TextPropertyPanel mxResetBarDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:65
+svx/source/sidebar/text/TextPropertyPanel.hxx:63
svx::sidebar::TextPropertyPanel mxDefaultBarDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:67
+svx/source/sidebar/text/TextPropertyPanel.hxx:65
svx::sidebar::TextPropertyPanel mxPositionBarDispatch
std::unique_ptr<ToolbarUnoDispatcher>
-svx/source/sidebar/text/TextPropertyPanel.hxx:69
+svx/source/sidebar/text/TextPropertyPanel.hxx:67
svx::sidebar::TextPropertyPanel mxSpacingBarDispatch
std::unique_ptr<ToolbarUnoDispatcher>
svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.hxx:40
svx::sidebar::TextColumnsPropertyPanel maColumnsNumberController
sfx2::sidebar::ControllerItem
svx/source/sidebar/textcolumns/TextColumnsPropertyPanel.hxx:41
svx::sidebar::TextColumnsPropertyPanel maColumnsSpacingController
sfx2::sidebar::ControllerItem
-svx/source/tbxctrls/tbcontrl.cxx:339
+svx/source/tbxctrls/tbcontrl.cxx:337
(anonymous namespace)::SvxFontNameBox_Base m_aOwnFontList
::std::unique_ptr<FontList>
sw/inc/accmap.hxx:95
SwAccessibleMap mvShapes SwShapeList_Impl
@@ -1256,24 +1256,12 @@ vcl/inc/unx/gtk/gtkframe.hxx:82
GtkSalFrame::IMHandler::PreviousKeyPress send_event gint8
vcl/inc/unx/gtk/gtkframe.hxx:83
GtkSalFrame::IMHandler::PreviousKeyPress time guint32
-vcl/inc/unx/saldisp.hxx:79
- SalVisual eRGBMode_ SalRGB
-vcl/inc/unx/saldisp.hxx:80
- SalVisual nRedShift_ int
-vcl/inc/unx/saldisp.hxx:81
- SalVisual nGreenShift_ int
-vcl/inc/unx/saldisp.hxx:82
- SalVisual nBlueShift_ int
-vcl/inc/unx/saldisp.hxx:83
- SalVisual nRedBits_ int
-vcl/inc/unx/saldisp.hxx:84
- SalVisual nGreenBits_ int
-vcl/inc/unx/saldisp.hxx:85
- SalVisual nBlueBits_ int
vcl/source/components/dtranscomp.cxx:210
vcl::(anonymous namespace)::GenericDragSource m_xTrans
css::uno::Reference<css::datatransfer::XTransferable>
vcl/source/fontsubset/sft.cxx:109
vcl::(anonymous namespace)::TTGlyphMetrics lsb sal_Int16
+vcl/source/gdi/pdfextoutdevdata.cxx:107
+ vcl::GlobalSyncData mStructIdMap std::vector<sal_Int32>
vcl/unx/generic/app/wmadaptor.cxx:1268
_mwmhints deco unsigned long
vcl/unx/generic/app/wmadaptor.cxx:1268
@@ -1306,7 +1294,7 @@ vcl/workben/vcldemo.cxx:1741
(anonymous namespace)::DemoWin mxThread rtl::Reference<RenderThread>
writerfilter/source/dmapper/DocumentProtection.hxx:50
writerfilter::dmapper::DocumentProtection m_sRedlineProtectionKey OUString
-writerfilter/source/dmapper/DomainMapperTableHandler.cxx:242
+writerfilter/source/dmapper/DomainMapperTableHandler.cxx:245
writerfilter::dmapper::TableInfo aTablePropertyIds std::vector<PropertyIds>
writerfilter/source/dmapper/PropertyMap.hxx:220
writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
@@ -1330,20 +1318,22 @@ xmloff/qa/unit/uxmloff.cxx:109
(unnamed struct at
/home/noel/libo-plugin/xmloff/qa/unit/uxmloff.cxx:106:12) result const
sal_uInt16
xmloff/source/draw/ximpstyl.hxx:215
SdXMLMasterStylesContext maMasterPageList
std::vector<rtl::Reference<SdXMLMasterPageContext> >
-xmloff/source/forms/elementexport.hxx:46
+xmloff/source/forms/elementexport.hxx:45
xmloff::OElementExport m_pXMLElement std::unique_ptr<SvXMLElementExport>
-xmloff/source/forms/elementexport.hxx:103
+xmloff/source/forms/elementexport.hxx:102
xmloff::OControlExport m_pOuterElement std::unique_ptr<SvXMLElementExport>
xmloff/source/forms/officeforms.hxx:68
xmloff::OFormsRootExport m_pImplElement std::unique_ptr<SvXMLElementExport>
xmloff/source/text/txtimp.cxx:104
XMLTextImportHelper::Impl m_xFrameImpPrMap
rtl::Reference<SvXMLImportPropertyMapper>
-xmlsecurity/inc/certificatechooser.hxx:53
+xmlsecurity/inc/certificatechooser.hxx:55
CertificateChooser mvUserData std::vector<std::shared_ptr<UserData> >
xmlsecurity/inc/certificateviewer.hxx:51
CertificateViewer mxGeneralPage std::unique_ptr<CertificateViewerGeneralTP>
xmlsecurity/inc/certificateviewer.hxx:52
CertificateViewer mxDetailsPage std::unique_ptr<CertificateViewerDetailsTP>
+xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx:87
+ (anonymous namespace)::SaveODFItem m_nODF sal_Int16
xmlsecurity/source/helper/pdfsignaturehelper.cxx:237
(anonymous namespace)::PageChecksum m_nPageContent BitmapChecksum
xmlsecurity/source/helper/pdfsignaturehelper.cxx:238
diff --git a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
index 2e14e609773f..4c8c2fea56b7 100644
--- a/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
+++ b/xmlsecurity/source/dialogs/digitalsignaturesdialog.cxx
@@ -84,8 +84,6 @@ namespace
class SaveODFItem: public utl::ConfigItem
{
private:
- sal_Int16 m_nODF;
-
virtual void ImplCommit() override;
public:
@@ -96,7 +94,7 @@ namespace
void SaveODFItem::ImplCommit() {}
void SaveODFItem::Notify( const css::uno::Sequence< OUString >& ) {}
- SaveODFItem::SaveODFItem(): utl::ConfigItem("Office.Common/Save"),
m_nODF(0)
+ SaveODFItem::SaveODFItem(): utl::ConfigItem("Office.Common/Save")
{
OUString sDef("ODF/DefaultVersion");
Sequence< css::uno::Any > aValues = GetProperties(
Sequence<OUString>(&sDef,1) );
@@ -110,8 +108,6 @@ namespace
throw uno::RuntimeException(
"[xmlsecurity]SaveODFItem::SaveODFItem(): Wrong Type!",
nullptr );
-
- m_nODF = nTmp;
}
std::vector<std::u16string_view>& GetGUIServers()
commit 70d78fdac115a98b64c8e3333519c0a80573ee4a
Author: Noel Grandin <noel.gran...@collabora.co.uk>
AuthorDate: Fri Jul 21 11:52:00 2023 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Fri Jul 21 22:16:24 2023 +0200
mStructIdMap is unused
ever since
commit 07d790ca473cd6e71f0343419b819fa6b485dc01
Author: Michael Stahl <michael.st...@allotropia.de>
Date: Wed Jul 12 15:26:25 2023 +0200
tdf#154982 vcl: PDF Export: split BeginStructureElement
Change-Id: I4708fde93fe9a10e67fefc7e87fa9f3f49075375
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154720
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/vcl/source/gdi/pdfextoutdevdata.cxx
b/vcl/source/gdi/pdfextoutdevdata.cxx
index 057cb4e07549..b110557e67d7 100644
--- a/vcl/source/gdi/pdfextoutdevdata.cxx
+++ b/vcl/source/gdi/pdfextoutdevdata.cxx
@@ -104,7 +104,6 @@ struct GlobalSyncData
*/
sal_Int32 mCurId;
std::vector< sal_Int32 > mParaIds;
- std::vector< sal_Int32 > mStructIdMap;
std::map<void const*, sal_Int32> mSEMap;
sal_Int32 mCurrentStructElement;
@@ -114,7 +113,6 @@ struct GlobalSyncData
mCurrentStructElement( 0 )
{
mStructParents.push_back(0); // because PDFWriterImpl has a dummy root
- mStructIdMap.push_back( 0 );
}
void PlayGlobalActions( PDFWriter& rWriter );
};
