[Libreoffice-commits] core.git: include/svx svx/source

[Caolán McNamara (via logerrit)]

 include/svx/compressgraphicdialog.hxx       |    8 ++++----
 svx/source/dialog/compressgraphicdialog.cxx |   16 ++++++++--------
 2 files changed, 12 insertions(+), 12 deletions(-)

New commits:
commit 6a51ab527b56ddc2bf6ec6ccbfbf2bc608244355
Author:     Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Tue Jul 25 21:28:54 2023 +0100
Commit:     Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Wed Jul 26 11:26:20 2023 +0200

    Resolves: tdf#156411 listen to "value-changed" not "changed"
    
    we were listening to "changed" and querying the "value", but the value
    isn't guaranteed to have changed while the contents are being edited,
    only when "value-changed" arrives.
    
    Change-Id: I077051555813df48adae4259aa9a93d39c360dc3
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154907
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>

diff --git a/include/svx/compressgraphicdialog.hxx 
b/include/svx/compressgraphicdialog.hxx
index 3319a41a431c..088d0b6fd45e 100644
--- a/include/svx/compressgraphicdialog.hxx
+++ b/include/svx/compressgraphicdialog.hxx
@@ -67,10 +67,10 @@ private:
 
     DECL_DLLPRIVATE_LINK( SlideHdl, weld::Scale&, void );
     DECL_DLLPRIVATE_LINK( NewInterpolationModifiedHdl, weld::ComboBox&, void );
-    DECL_DLLPRIVATE_LINK( NewQualityModifiedHdl, weld::Entry&, void );
-    DECL_DLLPRIVATE_LINK( NewCompressionModifiedHdl, weld::Entry&, void );
-    DECL_DLLPRIVATE_LINK( NewWidthModifiedHdl, weld::Entry&, void );
-    DECL_DLLPRIVATE_LINK( NewHeightModifiedHdl, weld::Entry&, void );
+    DECL_DLLPRIVATE_LINK( NewQualityModifiedHdl, weld::SpinButton&, void );
+    DECL_DLLPRIVATE_LINK( NewCompressionModifiedHdl, weld::SpinButton&, void );
+    DECL_DLLPRIVATE_LINK( NewWidthModifiedHdl, weld::SpinButton&, void );
+    DECL_DLLPRIVATE_LINK( NewHeightModifiedHdl, weld::SpinButton&, void );
     DECL_DLLPRIVATE_LINK( ResolutionModifiedHdl, weld::ComboBox&, void );
     DECL_DLLPRIVATE_LINK( ToggleCompressionRB, weld::Toggleable&, void );
     DECL_DLLPRIVATE_LINK( ToggleReduceResolutionRB, weld::Toggleable&, void );
diff --git a/svx/source/dialog/compressgraphicdialog.cxx 
b/svx/source/dialog/compressgraphicdialog.cxx
index a8be5ed6c5e8..8fcf479d889d 100644
--- a/svx/source/dialog/compressgraphicdialog.cxx
+++ b/svx/source/dialog/compressgraphicdialog.cxx
@@ -135,8 +135,8 @@ void CompressGraphicsDialog::Initialize()
 
     m_xInterpolationCombo->connect_changed(LINK(this, CompressGraphicsDialog, 
NewInterpolationModifiedHdl));
 
-    m_xMFNewWidth->connect_changed( LINK( this, CompressGraphicsDialog, 
NewWidthModifiedHdl ));
-    m_xMFNewHeight->connect_changed( LINK( this, CompressGraphicsDialog, 
NewHeightModifiedHdl ));
+    m_xMFNewWidth->connect_value_changed( LINK( this, CompressGraphicsDialog, 
NewWidthModifiedHdl ));
+    m_xMFNewHeight->connect_value_changed( LINK( this, CompressGraphicsDialog, 
NewHeightModifiedHdl ));
 
     m_xResolutionLB->connect_changed( LINK( this, CompressGraphicsDialog, 
ResolutionModifiedHdl ));
     m_xBtnCalculate->connect_clicked(  LINK( this, CompressGraphicsDialog, 
CalculateClickHdl ) );
@@ -148,8 +148,8 @@ void CompressGraphicsDialog::Initialize()
 
     m_xQualitySlider->connect_value_changed( LINK( this, 
CompressGraphicsDialog, SlideHdl ));
     m_xCompressionSlider->connect_value_changed( LINK( this, 
CompressGraphicsDialog, SlideHdl ));
-    m_xQualityMF->connect_changed( LINK( this, CompressGraphicsDialog, 
NewQualityModifiedHdl ));
-    m_xCompressionMF->connect_changed( LINK( this, CompressGraphicsDialog, 
NewCompressionModifiedHdl ));
+    m_xQualityMF->connect_value_changed( LINK( this, CompressGraphicsDialog, 
NewQualityModifiedHdl ));
+    m_xCompressionMF->connect_value_changed( LINK( this, 
CompressGraphicsDialog, NewCompressionModifiedHdl ));
 
     m_xJpegCompRB->set_active(true);
     m_xReduceResolutionCB->set_active(true);
@@ -288,7 +288,7 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, OkayClickHdl, 
weld::Button&, void )
     CompressGraphicsDialog::response(RET_OK);
 }
 
-IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, weld::Entry&, 
void )
+IMPL_LINK_NOARG( CompressGraphicsDialog, NewWidthModifiedHdl, 
weld::SpinButton&, void )
 {
     m_dResolution =  m_xMFNewWidth->get_value() / GetViewWidthInch();
 
@@ -311,19 +311,19 @@ IMPL_LINK_NOARG( CompressGraphicsDialog, 
NewInterpolationModifiedHdl, weld::Comb
     Update();
 }
 
-IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, weld::Entry&, 
void )
+IMPL_LINK_NOARG( CompressGraphicsDialog, NewQualityModifiedHdl, 
weld::SpinButton&, void )
 {
     m_xQualitySlider->set_value(m_xQualityMF->get_value());
     Update();
 }
 
-IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, 
weld::Entry&, void )
+IMPL_LINK_NOARG( CompressGraphicsDialog, NewCompressionModifiedHdl, 
weld::SpinButton&, void )
 {
     m_xCompressionSlider->set_value(m_xCompressionMF->get_value());
     Update();
 }
 
-IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, weld::Entry&, 
void )
+IMPL_LINK_NOARG( CompressGraphicsDialog, NewHeightModifiedHdl, 
weld::SpinButton&, void )
 {
     m_dResolution =  m_xMFNewHeight->get_value() / GetViewHeightInch();