Hi Benjamin, On 2012-06-23 at 19:57 +0200, Benjamin Drung wrote:
> > I am afraid this > > breaks the way we are handling the hicontrast theme that is supposed to > > target visually impaired people - we use dark background and white text > > in the hicontrast case (which wouldn't be the case any more with this > > patch). > > > > Adding the UX advise people what they think - I have no experience with > > accessibility, so cannot say what is right in this area. If they agree > > that we should let the hicontrast behavior as it is, I'd prefer: > > > > case DOCCOLOR : > > - aRet = > > Application::GetSettings().GetStyleSettings().GetWindowColor(); > > + aRet = > > Application::GetSettings().GetStyleSettings().GetHighContrastMode()? > > COL_BLACK: COL_WHITE; > > break; > > > > and similarly for FONTCOLOR - how does that sound to you? > > Does it make a difference for visually impaired people between black on > white and white on black? I have no idea :-( What I wanted to say was that we were handling the color the way I described, but unfortunately I still do not know if it is the correct thing to do, or not - I hope the UX people will be able to help... > Is it really a good idea to allow the desktop theme to influence the > appearance of the document? Imagine following: > > I create a document where LibreOffice is configured with black font on > white background. I select a brown 1 for the text and save it. Then > someone with a hiconstrast theme opens the document and will see dark > brown text on a black background. The contrast was reduces instead of > increased. ...but you are right that the current handling of hicontrast would make this use case much worse. > Please read bug #50861 and the examples given in comment 2 [1]. > > [1] https://bugs.freedesktop.org/show_bug.cgi?id=50861#c2 > > > BTW, this all color setting thing requires a cleanup - why should we > > have the baroque StyleSettings class, and on top of that this > > ColorConfig approach to colors? Are you interested in cleaning up / > > consolidating the approach to colors as a follow-up? ;-) > > Yes and no. On the one hand it is appealing to me, but on the other hand > other free software projects already consume enough of my spare time. Completely understood :-) All the best, Kendy _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice