cui/source/tabpages/chardlg.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 7ac066438f6d029fd0be2f0c72207805b0ca8153
Author:     Justin Luth <jl...@mail.com>
AuthorDate: Thu Oct 26 15:48:30 2023 -0400
Commit:     Justin Luth <jl...@mail.com>
CommitDate: Fri Oct 27 02:38:36 2023 +0200

    tdf#156988 chardlg: default to AUTO escapement
    
    As of 24.2, the default value for a superscript or subscript
    is automatic placement since d384ccdb04ebeb8b094e6d9a2ddf4e5aea5327c8.
    
    Therefore, it makes sense for the character properties
    dialog to also default to automatic.
    
    Normally this happens - since normally there is some kind of context,
    and in that case m_xNormalPosBtn was set with AUTO (m_xHighLowRB).
    However, in the case of finding a formating, there is no context
    for the very first run. That is what this patch intended to fix,
    since in that case too we want m_xHighLowRB to be set to true.
    
    For any other similar situation where there is no context,
    assuming DFLT_ESC_AUTO_SUPER or DFLT_ESC_AUTO_SUB
    should be appropriate.
    
    Change-Id: I1ee78c72bbb1c3d23fa39da29322436632f12b14
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158514
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <jl...@mail.com>

diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx
index 3075f3fc4258..d8ea76e9a9d4 100644
--- a/cui/source/tabpages/chardlg.cxx
+++ b/cui/source/tabpages/chardlg.cxx
@@ -2748,6 +2748,8 @@ void SvxCharPositionPage::Reset( const SfxItemSet* rSet )
         m_xHighPosBtn->set_active(false);
         m_xNormalPosBtn->set_active(false);
         m_xLowPosBtn->set_active(false);
+
+        m_xHighLowRB->set_active(true);
     }
 
     // set BspFont

Reply via email to