android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java | 15
----------
android/source/src/java/org/mozilla/gecko/gfx/LayerView.java | 2 -
2 files changed, 17 deletions(-)
New commits:
commit f324220e8772799ecf2b21cb6084757c0e56953f
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Thu Nov 9 08:13:22 2023 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Thu Nov 9 13:18:17 2023 +0100
android: Drop Robocop comment
Robocop is a tool for UI-testing fore Firefox on Android [1],
but not used for LibreOffice Viewer, so drop the misleading
comment.
[1] https://wiki.mozilla.org/Auto-tools/Projects/Robocop
Change-Id: I270735b2258f18691f60865c683856d58a94bb04
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159199
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java
b/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java
index 7c2dda766d0a..2e1a897b62e7 100644
--- a/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java
+++ b/android/source/src/java/org/mozilla/gecko/gfx/LayerView.java
@@ -35,8 +35,6 @@ import org.mozilla.gecko.OnSlideSwipeListener;
*
* This view delegates to LayerRenderer to actually do the drawing. Its role
is largely that of a
* mediator between the LayerRenderer and the LayerController.
- *
- * Note that LayerView is accessed by Robocop via reflection.
*/
public class LayerView extends FrameLayout {
private static String LOGTAG = LayerView.class.getName();
commit aef1b023d5ccd3cf532f98f921734b22e4a027ed
Author: Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Thu Nov 9 08:09:47 2023 +0100
Commit: Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Thu Nov 9 13:18:11 2023 +0100
android: Drop never-assigned to LayerRenderer#mPixelBuffer
That member was never assigned a value but only read
from by code claiming to be "used by robocop for testing purposes".
[1] describes Robocop as a UI-level testing framework for Firefox
for Android, which we don't use, so drop the class member and
related test code.
[1] https://wiki.mozilla.org/Auto-tools/Projects/Robocop
Change-Id: I467296874d4295060cc9670d1f1c8b0dfeb77523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159198
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>
diff --git a/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java
b/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java
index 6f013612384e..6ea7dd0edc10 100644
--- a/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java
+++ b/android/source/src/java/org/mozilla/gecko/gfx/LayerRenderer.java
@@ -51,9 +51,6 @@ public class LayerRenderer implements GLSurfaceView.Renderer {
private CopyOnWriteArrayList<Layer> mExtraLayers = new
CopyOnWriteArrayList<Layer>();
- /* Used by robocop for testing purposes */
- private IntBuffer mPixelBuffer;
-
// Used by GLES 2.0
private int mProgram;
private int mPositionHandle;
@@ -451,18 +448,6 @@ public class LayerRenderer implements
GLSurfaceView.Renderer {
// If a layer update requires further work, schedule another redraw
if (!mUpdated)
mView.requestRender();
-
- /* Used by robocop for testing purposes */
- IntBuffer pixelBuffer = mPixelBuffer;
- if (mUpdated && pixelBuffer != null) {
- synchronized (pixelBuffer) {
- pixelBuffer.position(0);
- GLES20.glReadPixels(0, 0,
(int)mScreenContext.viewport.width(),
- (int)mScreenContext.viewport.height(),
GLES20.GL_RGBA,
- GLES20.GL_UNSIGNED_BYTE, pixelBuffer);
- pixelBuffer.notify();
- }
- }
}
}
}
