On Mon, Jul 02, 2012 at 06:13:50PM +0200, Lionel Elie Mamane wrote: > Then I click on "sw/source/core/bastyp/SwSmartTagMgr.cxx" just to > *see* what this patch is about. I go back to previous page, and now > this line has a green mark in "Reviewed". This gives the idea that > I somehow approve of these changes.
No it does not. You approve the changes by giving a +2 code review. > When I click "Diff All Side-by-Side" (or "Diff All Unified"), it shows > me only the first file with a link to the (diff) of the next file. I > expected to see the diff for *all* files on one page. That is much > more convenient to check if the changes in one file match the changes > in another file. For example: the signature of a function is called in > foo.h and everywhere it is called (in bar.cxx and qux.cxx), the call > is adapted correctly. There is gitweb to see all changes on one page. We might patch the diff-all button to link there too (although you cannot do inline comments there). Best, Bjoern _______________________________________________ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice