sc/source/ui/undo/undoblk3.cxx | 1 -
sc/source/ui/view/viewfun4.cxx | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
New commits:
commit 27894455857eab436a7676de370a5bb897509f29
Author: Caolán McNamara <caolan.mcnam...@collabora.com>
AuthorDate: Tue Feb 20 14:04:24 2024 +0000
Commit: Caolán McNamara <caolan.mcnam...@collabora.com>
CommitDate: Tue Feb 20 21:29:46 2024 +0100
none of these defaults can be hit
and so pEngine is always set to something here
Change-Id: I8a0ac4a47a3d70e7ede52c2626af871dd360038a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163657
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnam...@collabora.com>
diff --git a/sc/source/ui/undo/undoblk3.cxx b/sc/source/ui/undo/undoblk3.cxx
index 82d381d2f9ae..40d38a4ec1ed 100644
--- a/sc/source/ui/undo/undoblk3.cxx
+++ b/sc/source/ui/undo/undoblk3.cxx
@@ -1212,7 +1212,6 @@ OUString ScUndoConversion::GetComment() const
case SC_CONVERSION_SPELLCHECK: aText = ScResId( STR_UNDO_SPELLING
); break;
case SC_CONVERSION_HANGULHANJA: aText = ScResId(
STR_UNDO_HANGULHANJA ); break;
case SC_CONVERSION_CHINESE_TRANSL: aText = ScResId(
STR_UNDO_CHINESE_TRANSLATION ); break;
- default: OSL_FAIL( "ScUndoConversion::GetComment - unknown conversion
type" );
}
return aText;
}
diff --git a/sc/source/ui/view/viewfun4.cxx b/sc/source/ui/view/viewfun4.cxx
index 48ac1a97cf02..8ff799ad46f4 100644
--- a/sc/source/ui/view/viewfun4.cxx
+++ b/sc/source/ui/view/viewfun4.cxx
@@ -516,10 +516,10 @@ void ScViewFunc::DoSheetConversion( const
ScConversionParam& rConvParam )
pEngine.reset(new ScTextConversionEngine(
rDoc.GetEnginePool(), rViewData, rConvParam, pUndoDoc.get(),
pRedoDoc.get() ));
break;
- default:
- OSL_FAIL( "ScViewFunc::DoSheetConversion - unknown conversion
type" );
}
+ assert(pEngine && "all cases result in pEngine set");
+
MakeEditView( pEngine.get(), nCol, nRow );
pEngine->SetRefDevice( rViewData.GetActiveWin()->GetOutDev() );
// simulate dummy cell:
