New branch 'private/quwex/notespaneflat' available with the following commits: commit 347a4c77314b09e254d5632a82cc96446dee7b61 Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Fri Apr 19 00:40:28 2024 +0200
related tdf#33603: sd: do not assume there's always a viewshell Change-Id: I171639150a84372e7e25b5246d4882c467edd58b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166271 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit bcdc39128642d6d5bfd63dec13a632e23c98fa63 Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Tue Apr 16 17:09:28 2024 +0200 tdf#33603: make the notes pane handle placeholder text on focus Change-Id: Id2bca2b8a8bafa9da44a5f97a8e763b512078ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166152 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit dfee653b274b536ecdbe4c353a2f5a7c15bf479d Author: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> Date: Thu Apr 11 11:24:22 2024 +0200 tdf#33603 Typo: 'Notes Panel' -> 'Notes Pane' Similiar to 'Slide Pane' Change-Id: If96afc4c054bbbff7c9bf8c5f4309e8eeb419d77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166005 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fit...@ubuntu.com> Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit 1405ccd249a0cc3aef013eb216acfcd5f83bad10 Author: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> Date: Thu Apr 11 10:55:31 2024 +0200 tdf#33603 Allow adding Notes Panel to toolbar/menubar/keyboard shortcuts Change-Id: Ic3e8f6b5a0cc8697c62e8f10f69ff53859f33d3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166004 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit c3f7f711e52497a49540d896a3a5295505bb1c9a Author: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> Date: Thu Apr 11 10:55:01 2024 +0200 tdf#33603 Make notes panel available in readonly mode Change-Id: I2dd10802f3798b2e87833d3cd8ebd21366e0f546 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166003 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit 5d19c742adf596c77c97ad3752ffdd4f584386b4 Author: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> Date: Thu Apr 11 10:19:40 2024 +0200 tdf#33603 Fix Close button not working in Notes Pane Remove duplicate command and now unused NotesChildWindow Change-Id: Idef94086ca91dd1474070c426c37ef921ad4fa03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166002 Tested-by: Jenkins Reviewed-by: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> commit 3a7ab12873113dff90039e0a3cc6e7aba37000dd Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Fri Apr 5 09:39:24 2024 +0300 related tdf#33603: sd: fix notespanel crash on drag and drop Change-Id: I067fd3f3eccd8e0fa0d13795f660fe43410b0aa3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165809 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> commit 76c91efcad81ad0808e8d66f51a7894cf7f7b32b Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Fri Apr 5 09:23:55 2024 +0300 related tdf#33603: sd: force invalidate notespanel This is likely not the correct thing to do here, but is a working solution that fixes the view lagging behind the resize for now. Change-Id: I662e59cfd0f1259eeb10a49b6e9c5fd616afa7a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165808 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> commit 1bc2ebaf410c22c41ebaadbfdc648a4da6093a1a Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Thu Apr 4 18:41:33 2024 +0300 related tdf#33603: fix notespanel missing outliner on mode change When MainViewShell changed editing mode, two EventMultipexerEvents arrive in succession - if while processing the first one links are reset, second one was ignored. Do not remove EventMultiplexer listener on FillOutliner() Change-Id: I9c41c823ca74574238d1199ed38f92d9c75a113e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165807 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> commit 72095cf1cb060f4a8ca3c398f95e78d72907cec2 Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Thu Apr 4 07:18:38 2024 +0300 tdf#33603: sd: rework notes panel To be able to support various dispatch commands, sidebar, proper user configuration, and more - reworked the previous notes panel implementation as a sd::View/sd::ViewShell pair that plays nice with Impress framework. To be able to support TextObjectBar(Shell) functionality, without having TextObjectBar as a SubShell (In the current sd::framework implementation AFAICS, SubShells are only possible for the MainViewShell - this doesn't work for notes panel which is never used as the MainViewShell.). A workaround is implemented where NotesPanel inherits dispatching slots from TextObjectBar, and for these inherited slots forwards the calls to TextObjectBar's implementation. This workaround could be removed if/when, SubShell support outside of MainViewShell is implemented. Known issues/TODO: - Drag & Drop crashes / doesn't work. - Some notes placeholder syncing problems on page change, edit mode change. - A rendering issue related to resizing when ArrangeGUIElements isn't called on resize. Change-Id: I588a4854fbedf6556e001fee1693b32410cbc23f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/165770 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbr...@allotropia.de> commit b344c324ce1cc222f57b980dc29e9e796f208fc4 Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Thu Feb 22 17:45:54 2024 +0300 related tdf#33603: do not register NotesChildWindow for Draw Draw doesn't need the notes panel introduced in c4c1ca58bb587a56a30c7f4817c346054ce37f2a, so don't register that for it's shell (GraphicViewShell). Change-Id: I062a54e806058f352721b89d7cffff10cece8612 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163775 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behr...@allotropia.de> commit bc523b2b17c3b1f23370868e01253633994f2561 Author: Sarper Akdemir <sarper.akdemir.ext...@allotropia.de> Date: Thu Nov 9 20:18:44 2023 +0300 tdf#33603: sd: add notes panel for normal view Change-Id: Ibc6e8a3f126c443453c5ecab52ba988a4f4f56e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159288 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behr...@allotropia.de>