desktop/source/app/cmdlinehelp.cxx |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

New commits:
commit 3d4a3b30aea603b98da447ec6587b5d3eb20da66
Author:     Justin Luth <justin.l...@collabora.com>
AuthorDate: Tue May 14 09:20:49 2024 -0400
Commit:     Justin Luth <jl...@mail.com>
CommitDate: Mon May 20 15:42:36 2024 +0200

    tdf#69192 fix cmdlinehelp: --show[=slide_number], etc.
    
    I had skimmed the help file earlier, and concluded that { }
    are used elsewhere to indicate optional paramaters.
    However, there is --quickstart[=no], and -env:<VAR>[=<VALUE>]
    which exactly match my optional addition.
    
    Thanks Stéphane for pointing this out.
    Also included are some other changes we made
    to clarify the help wording in general,
    so the documentation and the cmdline help are in sync.
    
    We dropped
        Files other than Impress documents are opened in
        default mode, regardless of previous mode.
    because:
    -from an initial reading it doesn't convey any useful meaning.
    -searching for other uses of "mode" in the file suggests it means
     that prior --print/--convert-to/--view modes
     no longer apply. This override of prior modes is true for all modes,
     but only this argument tries to spell this out.
    -it seems rather inconceivable that any user would attempt
     to mix --show with any other arguments or more than one file.
    
    Change-Id: I191e572506cf2b39ed6c9ff4ebaf66f258a176a1
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/167633
    Tested-by: Jenkins
    Reviewed-by: Justin Luth <jl...@mail.com>

diff --git a/desktop/source/app/cmdlinehelp.cxx 
b/desktop/source/app/cmdlinehelp.cxx
index 10b3e5c48cbb..7fb0b3d48a1e 100644
--- a/desktop/source/app/cmdlinehelp.cxx
+++ b/desktop/source/app/cmdlinehelp.cxx
@@ -145,11 +145,10 @@ namespace desktop
         "                       not appear. If the file name contains spaces, 
then it   
"
         "                       must be enclosed in quotation marks.           
         
"
         "   --view              Opens following files in viewer mode 
(read-only).       
"
-        "   --show{=slide#}     Opens and starts the following presentation 
documents   
"
-        "                       of each immediately. Files are closed after 
the showing.
"
-        "                       If a slide # is provided, they start at that 
slide.     
"
-        "                       Files other than Impress documents are opened 
in        
"
-        "                       default mode , regardless of previous mode.    
         
"
+        "   --show[=slide_number]  Opens and starts the slideshow of the 
following      
"
+        "                       presentation documents immediately.            
         
"
+        "                       Files are closed after the showing.            
         
"
+        "                       If a slide_number is provided, they start at 
that slide.
"
         "   --convert-to OutputFileExtension[:OutputFilterName] \              
        
"
         "     [--outdir output_dir] [--convert-images-to]                      
         
"
         "                       Batch convert files (implies --headless). If 
--outdir   
"

Reply via email to