vcl/inc/salframe.hxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit eacc3489392bf4006acdd10bcd191afe2a5c92e2
Author:     Michael Weghorn <m.wegh...@posteo.de>
AuthorDate: Wed Sep 25 18:17:39 2024 +0200
Commit:     Michael Weghorn <m.wegh...@posteo.de>
CommitDate: Thu Sep 26 07:11:56 2024 +0200

    tdf#160837 vcl: Protect SalFrame::maGeometry access
    
    Make SalFrame::maGeometry a protected instead
    of a public class member.
    
    This restricts direct access to subclasses
    and friends, making it easier to keep
    track and preventing direct access (including the
    possibility to set a different geometry) from
    "random" places.
    
    Other code previously directly accessing
    SalFrame::maGeometry was adjusted in previous
    commits.
    
    Change-Id: I8b41f382228e48afb94da88f99d1cfb3c3b8f834
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/173960
    Tested-by: Jenkins
    Reviewed-by: Michael Weghorn <m.wegh...@posteo.de>

diff --git a/vcl/inc/salframe.hxx b/vcl/inc/salframe.hxx
index ab2ce4d0430f..aec104b43175 100644
--- a/vcl/inc/salframe.hxx
+++ b/vcl/inc/salframe.hxx
@@ -119,13 +119,12 @@ private:
     SALFRAMEPROC            m_pProc;
     Link<bool, void>        m_aModalHierarchyHdl;
 protected:
+    SalFrameGeometry maGeometry; ///< absolute, unmirrored values
     mutable std::unique_ptr<weld::Window> m_xFrameWeld;
 public:
                             SalFrame();
     virtual                 ~SalFrame() override;
 
-    SalFrameGeometry maGeometry; ///< absolute, unmirrored values
-
     // SalGeometryProvider
     virtual tools::Long GetWidth() const override { return maGeometry.width(); 
}
     virtual tools::Long GetHeight() const override { return 
maGeometry.height(); }

Reply via email to