sc/source/core/data/fillinfo.cxx | 2 +-
store/source/storcach.cxx | 2 +-
store/source/storcach.hxx | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 2009ecbeb1b6b4c771c79ea695e34e7bf4e10965
Author: Noel Grandin <noelgran...@gmail.com>
AuthorDate: Sat Sep 28 19:33:58 2024 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Sun Sep 29 09:05:06 2024 +0200
cid#1607257 Overflowed constant
this is a false positve, but perhaps we can help coverity work it
out properly with some constexpr
Change-Id: I8398153d6678585dacf4acaf7081ec32094bcda6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174150
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
diff --git a/store/source/storcach.cxx b/store/source/storcach.cxx
index bb4e34b5af27..dc030fa1c809 100644
--- a/store/source/storcach.cxx
+++ b/store/source/storcach.cxx
@@ -123,7 +123,7 @@ void EntryCache::destroy (Entry * entry)
}
// highbit():= log2() + 1 (complexity O(1))
-static int highbit(std::size_t n)
+static constexpr int highbit(std::size_t n)
{
int k = 1;
diff --git a/store/source/storcach.hxx b/store/source/storcach.hxx
index b787248349ac..ebdbd392ee18 100644
--- a/store/source/storcach.hxx
+++ b/store/source/storcach.hxx
@@ -39,7 +39,7 @@ struct Entry;
class PageCache :
public store::OStoreObject
{
- static size_t const theTableSize = 32;
+ static size_t constexpr theTableSize = 32;
static_assert((theTableSize & (theTableSize-1)) == 0, "table size should
be a power of 2");
Entry ** m_hash_table;
commit df389675fc1e6c4f620b6769cc70c9c3b794175a
Author: Noel Grandin <noelgran...@gmail.com>
AuthorDate: Sat Sep 28 20:12:42 2024 +0200
Commit: Noel Grandin <noel.gran...@collabora.co.uk>
CommitDate: Sun Sep 29 09:04:52 2024 +0200
cid#1607205 Overflowed constant
Change-Id: Ic70c6f866a78ee01947415fe2f4af9508490e351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174152
Reviewed-by: Noel Grandin <noel.gran...@collabora.co.uk>
Tested-by: Jenkins
diff --git a/sc/source/core/data/fillinfo.cxx b/sc/source/core/data/fillinfo.cxx
index 7afa00b86543..d3739b2878ef 100644
--- a/sc/source/core/data/fillinfo.cxx
+++ b/sc/source/core/data/fillinfo.cxx
@@ -397,7 +397,7 @@ void ScDocument::FillInfo(
{
//TODO: check Conditionals also for HasAttrFlags::Rotate ????
- OSL_ENSURE( nArrCount>2, "nArrCount too small" );
+ assert( nArrCount>2 && "nArrCount too small" );
FindMaxRotCol( nTab, &pRowInfo[1], nArrCount-1, nCol1, nCol2 );
// FindMaxRotCol sets nRotMaxCol
