connectivity/source/drivers/file/fcomp.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit d98de2d0324c0e1cd808643633889423fccfc75e
Author:     Bogdan Buzea <[email protected]>
AuthorDate: Fri Oct 18 06:26:50 2024 +0200
Commit:     David Gilbert <[email protected]>
CommitDate: Wed Nov 6 22:26:56 2024 +0100

    tdf#163486: PVS: Identical branches
    
    Change-Id: Iad298c2819b0fa1fd4d98a64f19008a7ef8d39be
    V1037: Two or more case-branches perform the same actions. Check lines: 
353, 362
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175050
    Reviewed-by: David Gilbert <[email protected]>
    Tested-by: Jenkins

diff --git a/connectivity/source/drivers/file/fcomp.cxx 
b/connectivity/source/drivers/file/fcomp.cxx
index 871e8fc8bef6..86ed7d4cf8c5 100644
--- a/connectivity/source/drivers/file/fcomp.cxx
+++ b/connectivity/source/drivers/file/fcomp.cxx
@@ -350,6 +350,8 @@ void OPredicateCompiler::execute_BETWEEN(OSQLParseNode 
const * pPredicateNode)
                 break;
             case DataType::DECIMAL:
             case DataType::NUMERIC:
+            case DataType::DOUBLE:
+            case DataType::REAL:
                 pOb1->setValue(pOb1->getValue().getDouble());
                 pOb2->setValue(pOb2->getValue().getDouble());
                 break;
@@ -357,11 +359,6 @@ void OPredicateCompiler::execute_BETWEEN(OSQLParseNode 
const * pPredicateNode)
                 pOb1->setValue(pOb1->getValue().getFloat());
                 pOb2->setValue(pOb2->getValue().getFloat());
                 break;
-            case DataType::DOUBLE:
-            case DataType::REAL:
-                pOb1->setValue(pOb1->getValue().getDouble());
-                pOb2->setValue(pOb2->getValue().getDouble());
-                break;
             case DataType::DATE:
                 pOb1->setValue(pOb1->getValue().getDate());
                 pOb2->setValue(pOb2->getValue().getDate());

Reply via email to