cui/source/tabpages/chardlg.cxx | 12 ++++++------ sw/source/uibase/sidebar/PageStylesPanel.cxx | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-)
New commits: commit 05dafbdc9d7e6755d67d63e58cec3cc1f9038848 Author: Caolán McNamara <[email protected]> AuthorDate: Thu Nov 7 08:26:42 2024 +0000 Commit: Caolán McNamara <[email protected]> CommitDate: Thu Nov 7 13:27:33 2024 +0100 cid#1634480 Use of auto that causes a copy and cid#1634481 Use of auto that causes a copy Change-Id: Ia301cc4ffae4ad451dfafb90c63cc8feb0eb0ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176194 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/cui/source/tabpages/chardlg.cxx b/cui/source/tabpages/chardlg.cxx index 235bda92d184..62ed6940dd38 100644 --- a/cui/source/tabpages/chardlg.cxx +++ b/cui/source/tabpages/chardlg.cxx @@ -2099,9 +2099,9 @@ bool SvxCharEffectsPage::FillItemSet( SfxItemSet* rSet ) if ( bChanged ) { SvxUnderlineItem aNewItem( eUnder, nWhich ); - auto aNamedColor = m_xUnderlineColorLB->GetSelectedEntry(); - aNewItem.SetColor(aNamedColor.m_aColor); - aNewItem.setComplexColor(aNamedColor.getComplexColor()); + const NamedColor& rNamedColor = m_xUnderlineColorLB->GetSelectedEntry(); + aNewItem.SetColor(rNamedColor.m_aColor); + aNewItem.setComplexColor(rNamedColor.getComplexColor()); rSet->Put(aNewItem); bModified = true; } @@ -2138,9 +2138,9 @@ bool SvxCharEffectsPage::FillItemSet( SfxItemSet* rSet ) if ( bChanged ) { SvxOverlineItem aNewItem( eOver, nWhich ); - auto aNamedColor = m_xOverlineColorLB->GetSelectedEntry(); - aNewItem.SetColor(aNamedColor.m_aColor); - aNewItem.setComplexColor(aNamedColor.getComplexColor()); + const NamedColor& rNamedColor = m_xOverlineColorLB->GetSelectedEntry(); + aNewItem.SetColor(rNamedColor.m_aColor); + aNewItem.setComplexColor(rNamedColor.getComplexColor()); rSet->Put(aNewItem); bModified = true; } diff --git a/sw/source/uibase/sidebar/PageStylesPanel.cxx b/sw/source/uibase/sidebar/PageStylesPanel.cxx index 881ce78d3eb3..e35640cd6fbd 100644 --- a/sw/source/uibase/sidebar/PageStylesPanel.cxx +++ b/sw/source/uibase/sidebar/PageStylesPanel.cxx @@ -552,9 +552,9 @@ void PageStylesPanel::ModifyFillColor() { case SOLID: { - auto aNamedColor = mxBgColorLB->GetSelectedEntry(); - XFillColorItem aItem(OUString(), aNamedColor.m_aColor); - aItem.setComplexColor(aNamedColor.getComplexColor()); + const NamedColor& rNamedColor = mxBgColorLB->GetSelectedEntry(); + XFillColorItem aItem(OUString(), rNamedColor.m_aColor); + aItem.setComplexColor(rNamedColor.getComplexColor()); aItem.setComplexColor(mxBgColorLB->GetSelectedEntry().getComplexColor()); GetBindings()->GetDispatcher()->ExecuteList(SID_ATTR_PAGE_COLOR, SfxCallMode::RECORD, { &aItem }); }
