sc/source/ui/dbgui/scuiasciiopt.cxx |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

New commits:
commit 8044f9a2b5a99c865f1ead89c60986a66151c488
Author:     Andreas Heinisch <[email protected]>
AuthorDate: Fri Mar 28 10:00:48 2025 +0100
Commit:     Andreas Heinisch <[email protected]>
CommitDate: Fri Mar 28 18:00:53 2025 +0100

    tdf#163638 - CSV Import Dialog: show visual indicator for from rows
    
    Reflect remembered from rows control in the visual indicator after
    opening a new CSV file in the current session.
    
    Change-Id: If51a10cbe1282ef45786f672d2a237b37dced89e
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183440
    Reviewed-by: Andreas Heinisch <[email protected]>
    Tested-by: Jenkins

diff --git a/sc/source/ui/dbgui/scuiasciiopt.cxx 
b/sc/source/ui/dbgui/scuiasciiopt.cxx
index 5a8c75a00f9d..a81d568bdeb2 100644
--- a/sc/source/ui/dbgui/scuiasciiopt.cxx
+++ b/sc/source/ui/dbgui/scuiasciiopt.cxx
@@ -458,8 +458,6 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent, 
std::u16string_view aD
         mxRbSeparated->set_active(true);
     else
         mxRbDetectSep->set_active(true);
-    if (nFromRow != 1)
-        mxNfRow->set_value(nFromRow);
 
     // Clipboard is always Unicode, else rely on default/config.
     rtl_TextEncoding ePreselectUnicode = (meCall == SC_IMPORTFILE ?
@@ -487,8 +485,6 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent, 
std::u16string_view aD
     // Get Separators from the dialog (empty are set from default)
     maFieldSeparators = GetActiveSeparators();
 
-    mxNfRow->connect_value_changed( LINK( this, ScImportAsciiDlg, FirstRowHdl 
) );
-
     // *** Separator characters ***
     lcl_FillCombo( *mxCbTextSep, SCSTR_TEXTSEP, mcTextSep );
     mxCbTextSep->set_entry_text(sTextSeparators);
@@ -562,6 +558,14 @@ ScImportAsciiDlg::ScImportAsciiDlg(weld::Window* pParent, 
std::u16string_view aD
 
     mxTableBox->GetGrid().Execute( CSVCMD_NEWCELLTEXTS );
 
+    if (nFromRow != 1)
+    {
+        mxNfRow->set_value(nFromRow);
+        // tdf#163638 - show visual indicator for from rows
+        mxTableBox->GetGrid().Execute(CSVCMD_SETFIRSTIMPORTLINE, nFromRow - 1);
+    }
+    mxNfRow->connect_value_changed(LINK(this, ScImportAsciiDlg, FirstRowHdl));
+
     if (meCall == SC_TEXTTOCOLUMNS)
     {
         mxFtCharSet->set_sensitive(false);

Reply via email to