sd/source/ui/animations/SlideTransitionPane.cxx |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

New commits:
commit 0621d14cb488ca024c86fb2069b7fd39016aff9c
Author:     Darshan Upadhyay <[email protected]>
AuthorDate: Wed May 21 06:35:57 2025 +0200
Commit:     Szymon Kłos <[email protected]>
CommitDate: Wed May 21 08:34:14 2025 +0200

    Revert "Broadcast the transition change"
    
    This reverts commit ba0ec3b5f6f2154205ad72ce444a48b4dfb9af88.
    
    Reason for revert: While the change in the transition variant does happen 
and is applied to the slide, the variant button does not change to the new 
variant.
    
    Change-Id: I3f6072c139c4d18abf9a00fb019ceee249061681
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/185583
    Tested-by: Jenkins CollaboraOffice <[email protected]>
    Reviewed-by: Szymon Kłos <[email protected]>

diff --git a/sd/source/ui/animations/SlideTransitionPane.cxx 
b/sd/source/ui/animations/SlideTransitionPane.cxx
index 91a053b0db44..1ab9ca44ab0c 100644
--- a/sd/source/ui/animations/SlideTransitionPane.cxx
+++ b/sd/source/ui/animations/SlideTransitionPane.cxx
@@ -544,15 +544,10 @@ void SlideTransitionPane::updateControls()
     {
          // ToDo: That 0 is "no transition" is documented nowhere except in the
         // CTOR of sdpage
-        OUString sSelectedId = mxTransitionsIconView->get_selected_id();
-        auto* pTransitionEntry = weld::fromId<TransitionEntry*>(sSelectedId);
-
         if( aEffect.mnType == 0 )
             mxTransitionsIconView->select(0);
-        else if(!pTransitionEntry)
-            updateVariants(getPreset(aEffect));
         else
-            updateVariants(pTransitionEntry->mpPreset);
+            updateVariants(getPreset(aEffect));
     }
 
     if( aEffect.mbDurationAmbiguous )
@@ -882,8 +877,6 @@ impl::TransitionEffect 
SlideTransitionPane::getTransitionEffectFromControls() co
         aResult.mbLoopSoundAmbiguous = false;
     }
 
-    mpDrawDoc->Broadcast(SdrHint(SdrHintKind::ObjectChange));
-
     return aResult;
 }
 

Reply via email to