offapi/UnoApi_offapi.mk | 1 offapi/com/sun/star/chart/AccessibleChartDocumentView.idl | 122 -------------- svx/source/dialog/weldeditview.cxx | 20 -- 3 files changed, 1 insertion(+), 142 deletions(-)
New commits: commit 9fd0e7bbe64b24136b99274b04ecc25e3ac51cad Author: Michael Weghorn <[email protected]> AuthorDate: Fri Jun 20 11:48:11 2025 +0200 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Jun 20 21:22:49 2025 +0200 [API CHANGE]: Drop unused AccessibleChartDocumentView service The service is not implemented or used anywhere. A search in Google and on Ask [1] also didn't give any results that would suggest this could be relevant for third party code. [1] https://ask.libreoffice.org/ Change-Id: I888f891704c2ba9087d91be391f89efbae997e3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186757 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Jenkins diff --git a/offapi/UnoApi_offapi.mk b/offapi/UnoApi_offapi.mk index 3a2d8508bcdc..451b2ba25794 100644 --- a/offapi/UnoApi_offapi.mk +++ b/offapi/UnoApi_offapi.mk @@ -589,7 +589,6 @@ $(eval $(call gb_UnoApi_add_idlfiles_noheader,offapi,com/sun/star/awt/tree,\ TreeControlModel \ )) $(eval $(call gb_UnoApi_add_idlfiles_noheader,offapi,com/sun/star/chart,\ - AccessibleChartDocumentView \ AccessibleChartElement \ AreaDiagram \ BarDiagram \ diff --git a/offapi/com/sun/star/chart/AccessibleChartDocumentView.idl b/offapi/com/sun/star/chart/AccessibleChartDocumentView.idl deleted file mode 100644 index 345d9196a6de..000000000000 --- a/offapi/com/sun/star/chart/AccessibleChartDocumentView.idl +++ /dev/null @@ -1,122 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ - -module com { module sun { module star { module chart { - -/** The AccessibleChartDocumentView service is supported - by a Component that represents the view of a Chart document to - provide an entry point to the document tree for accessibility. - - <p>An object that implements the AccessibleChartDocumentView - service provides information about itself and about the chart - subcomponents contained in the chart document displayed in a - window. This service gives a simplified view on the underlying - implementation. It tries both to keep the structure of the - accessibility representation tree as simple as possible and - provide as much relevant information as possible.</p> - - @since OOo 1.1.2 -*/ -service AccessibleChartDocumentView -{ - /** Base interface for being accessible. It gives access to the - ::com::sun::star::accessibility::XAccessibleContext - interface. - */ - interface ::com::sun::star::accessibility::XAccessible; - - /** Provide access to a Chart document's view. - - <p>You can access the following information:</p> - <dl> - <dt>Role</dt> - <dd>The object's role is - com::sun::star::accessibility::AccessibleRole::DOCUMENT.</dd> - <dt>Name</dt> - <dd>Its name is the document's name or the base name of the filename if - no document name has been set explicitly.</dd> - <dt>Description</dt> - <dd>The description is the document's description or the - full filename if no description has been set - explicitly.</dd> - <dt>Children</dt> - <dd>The subcomponents of a chart. This includes all kinds of - titles, a legend and the diagram. The diagram and the legend are - the only children that themselves contain children. The Chart - subcomponents support the service - AccessibleChartElement. Additionally, there may be - shapes a user added via the clipboard. For details see the - ::com::sun::star::drawing::AccessibleShape. - </dd> - <dt>Parent</dt> - <dd>The parent will usually be the window that contains the - Chart document view. It has to be set via implementation dependent - ways.</dd> - <dt>Relations</dt> - <dd>At the moment relations are not supported. The method - com::sun::star::accessibility::XAccessibleContext::getAccessibleRelationSet() - will always return an empty set.</dd> - <dt>States</dt> - <dd>The following states are supported: - <ul> - <li>com::sun::star::accessibility::AccessibleStateType::DEFUNC - is set if a document view becomes obsolete like when - the window, which displays the view, is closed.</li> - <li>com::sun::star::accessibility::AccessibleStateType::ENABLED - is always set unless the - com::sun::star::accessibility::AccessibleStateType::DEFUNC - state is set.</li> - <li>com::sun::star::accessibility::AccessibleStateType::OPAQUE - is always set.</li> - <li>com::sun::star::accessibility::AccessibleStateType::SHOWING - is always set unless the - com::sun::star::accessibility::AccessibleStateType::DEFUNC - state is set.</li> - <li>com::sun::star::accessibility::AccessibleStateType::VISIBLE - is always set unless the - com::sun::star::accessibility::AccessibleStateType::DEFUNC - state is set.</li> - </ul> - </dd> - <dt>Locale</dt> - <dd>Is the locale set at the document.</dd> - <dt>Property change listeners</dt> - <dd>They are supported to inform the - listeners about changes in this object.</dd> - </dl> - */ - interface ::com::sun::star::accessibility::XAccessibleContext; - - /** Provide access to a Chart document's graphical representation. - - <p>The main purpose of this interface is to provide a bounding - box of the currently visible area and to let the user find the - subcomponents of a chart that cover a given test point.</p> - - <p>The accessible Chart subcomponents all support the service - AccessibleChartElement</p> - - @see AccessibleChartElement - */ - interface ::com::sun::star::accessibility::XAccessibleComponent; -}; - -}; }; }; }; - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ commit 9561efde494d18cb59453d95ba0e3244ed0db2e4 Author: Michael Weghorn <[email protected]> AuthorDate: Fri Jun 20 11:29:53 2025 +0200 Commit: Michael Weghorn <[email protected]> CommitDate: Fri Jun 20 21:22:38 2025 +0200 WeldEditView a11y: No longer implement XServiceInfo This is the WeldEditAccessible version of Change-Id: Id306320710a1718ff10536127427f3a5daf68559 Author: Michael Weghorn <[email protected]> Date: Fri Jun 20 11:14:19 2025 +0200 svtools ruler a11y: No longer implement XServiceInfo , see that commit's message for background. Change-Id: Ib85aff8b9a31687bca93c0b86545ac0392203baa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186756 Reviewed-by: Michael Weghorn <[email protected]> Tested-by: Jenkins diff --git a/svx/source/dialog/weldeditview.cxx b/svx/source/dialog/weldeditview.cxx index 91efe3381202..3fb6886d643a 100644 --- a/svx/source/dialog/weldeditview.cxx +++ b/svx/source/dialog/weldeditview.cxx @@ -24,7 +24,6 @@ #include <com/sun/star/accessibility/AccessibleStateType.hpp> #include <com/sun/star/accessibility/XAccessible.hpp> #include <com/sun/star/lang/IndexOutOfBoundsException.hpp> -#include <com/sun/star/lang/XServiceInfo.hpp> #include <comphelper/accessiblecomponenthelper.hxx> #include <cppuhelper/supportsservice.hxx> #include <drawinglayer/processor2d/baseprocessor2d.hxx> @@ -510,7 +509,7 @@ public: class WeldEditAccessible : public cppu::ImplInheritanceHelper<comphelper::OAccessibleComponentHelper, - css::accessibility::XAccessible, css::lang::XServiceInfo> + css::accessibility::XAccessible> { weld::CustomWidgetController* m_pController; EditEngine* m_pEditEngine; @@ -808,23 +807,6 @@ public: return; m_xTextHelper->RemoveEventListener(rListener); } - - virtual OUString SAL_CALL getImplementationName() override - { - return u"WeldEditAccessible"_ustr; - } - - virtual sal_Bool SAL_CALL supportsService(const OUString& rServiceName) override - { - return cppu::supportsService(this, rServiceName); - } - - virtual css::uno::Sequence<OUString> SAL_CALL getSupportedServiceNames() override - { - return { u"css::accessibility::Accessible"_ustr, - u"css::accessibility::AccessibleComponent"_ustr, - u"css::accessibility::AccessibleContext"_ustr }; - } }; css::uno::Reference<css::accessibility::XAccessible> WeldEditView::CreateAccessible()
