Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
10 new defect(s) introduced to LibreOffice found with Coverity Scan.
2 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 10 of 10 defect(s)
** CID 1655086: Code maintainability issues (UNUSED_VALUE)
/svx/source/tbxctrls/StylesPreviewWindow.cxx: 320 in
StyleItemController::DrawEntry(OutputDevice &, SfxStyleSheetBase *)()
_____________________________________________________________________________________________
*** CID 1655086: Code maintainability issues (UNUSED_VALUE)
/svx/source/tbxctrls/StylesPreviewWindow.cxx: 320 in
StyleItemController::DrawEntry(OutputDevice &, SfxStyleSheetBase *)()
314 SfxStyleSheetBasePool* pPool = pShell->GetStyleSheetPool();
315 if (!pPool)
316 return;
317
318 SfxStyleSheetBase* pStyle = nullptr;
319 if (pStyleHint)
>>> CID 1655086: Code maintainability issues (UNUSED_VALUE)
>>> Assigning value from "pStyleHint" to "pStyle" here, but that stored
>>> value is overwritten before it can be used.
320 pStyle = pStyleHint;
321 {
322 pStyle = pPool->First(m_eStyleFamily);
323 while (pStyle && pStyle->GetName() != m_aStyleName.first
324 && pStyle->GetName() != m_aStyleName.second)
325 pStyle = pPool->Next();
** CID 1655085: Possible Control flow issues (DEADCODE)
/sc/source/ui/view/cellsh1.cxx: 2028 in
ScCellShell::ExecuteEdit(SfxRequest &)()
_____________________________________________________________________________________________
*** CID 1655085: Possible Control flow issues (DEADCODE)
/sc/source/ui/view/cellsh1.cxx: 2028 in
ScCellShell::ExecuteEdit(SfxRequest &)()
2022 bool bUseVariants = false;
2023 bool bCommonTerms =
xDialog->getIsTranslateCommonTerms();
2024
2025 //execute translation
2026 LanguageType eSourceLang = bToSimplified ?
LANGUAGE_CHINESE_TRADITIONAL : LANGUAGE_CHINESE_SIMPLIFIED;
2027 LanguageType eTargetLang = bToSimplified ?
LANGUAGE_CHINESE_SIMPLIFIED : LANGUAGE_CHINESE_TRADITIONAL;
>>> CID 1655085: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "2" inside this statement:
>>> "nOptions = (bUseVariants ? ...".
2028 sal_Int32 nOptions = bUseVariants ?
i18n::TextConversionOption::USE_CHARACTER_VARIANTS : 0;
2029 if( !bCommonTerms )
2030 nOptions |=
i18n::TextConversionOption::CHARACTER_BY_CHARACTER;
2031
2032 vcl::Font aTargetFont =
OutputDevice::GetDefaultFont(
2033
DefaultFontType::CJK_SPREADSHEET,
** CID 1655084: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/export/chartexport.cxx: 3392 in
oox::drawingml::ChartExport::exportSeriesText(const
com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence> &,
bool)()
_____________________________________________________________________________________________
*** CID 1655084: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/oox/source/export/chartexport.cxx: 3392 in
oox::drawingml::ChartExport::exportSeriesText(const
com::sun::star::uno::Reference<com::sun::star::chart2::data::XDataSequence> &,
bool)()
3386 {
3387 FSHelperPtr pFS = GetFS();
3388
3389 OUString aLabelString =
lcl_flattenStringSequence(lcl_getLabelSequence(xValueSeq));
3390
3391 if (bIsChartex) {
>>> CID 1655084: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "pFS" is passed-by-value as parameter to "lcl_writeChartexString" when
>>> it could be moved instead.
3392 lcl_writeChartexString(pFS, aLabelString);
3393 } else {
3394 pFS->startElement(FSNS(XML_c, XML_tx));
3395
3396 OUString aCellRange =
xValueSeq->getSourceRangeRepresentation();
3397 aCellRange = parseFormula( aCellRange );
** CID 1655083: Possible Control flow issues (DEADCODE)
/sw/source/uibase/uiview/viewling.cxx: 127 in
SwView::ExecLingu(SfxRequest &)()
_____________________________________________________________________________________________
*** CID 1655083: Possible Control flow issues (DEADCODE)
/sw/source/uibase/uiview/viewling.cxx: 127 in
SwView::ExecLingu(SfxRequest &)()
121 bool bUseVariants = false;
122 bool bCommonTerms =
xDialog->getIsTranslateCommonTerms();
123
124 //execute translation
125 LanguageType nSourceLang = bToSimplified ?
LANGUAGE_CHINESE_TRADITIONAL : LANGUAGE_CHINESE_SIMPLIFIED;
126 LanguageType nTargetLang = bToSimplified ?
LANGUAGE_CHINESE_SIMPLIFIED : LANGUAGE_CHINESE_TRADITIONAL;
>>> CID 1655083: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "2" inside this statement:
>>> "nOptions = (bUseVariants ? ...".
127 sal_Int32 nOptions = bUseVariants ?
i18n::TextConversionOption::USE_CHARACTER_VARIANTS : 0;
128 if( !bCommonTerms )
129 nOptions = nOptions |
i18n::TextConversionOption::CHARACTER_BY_CHARACTER;
130
131 vcl::Font aTargetFont = OutputDevice::GetDefaultFont(
DefaultFontType::CJK_TEXT,
132 nTargetLang,
GetDefaultFontFlags::OnlyOne );
** CID 1655082: Possible Control flow issues (DEADCODE)
/sd/source/ui/func/fuhhconv.cxx: 201 in
sd::FuHangulHanjaConversion::StartChineseConversion()()
_____________________________________________________________________________________________
*** CID 1655082: Possible Control flow issues (DEADCODE)
/sd/source/ui/func/fuhhconv.cxx: 201 in
sd::FuHangulHanjaConversion::StartChineseConversion()()
195 bool bUseVariants = false;
196 bool bCommonTerms = xDialog->getIsTranslateCommonTerms();
197
198 //execute translation
199 LanguageType nSourceLang = bToSimplified ?
LANGUAGE_CHINESE_TRADITIONAL : LANGUAGE_CHINESE_SIMPLIFIED;
200 LanguageType nTargetLang = bToSimplified ?
LANGUAGE_CHINESE_SIMPLIFIED : LANGUAGE_CHINESE_TRADITIONAL;
>>> CID 1655082: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "2" inside this statement:
>>> "nOptions = (bUseVariants ? ...".
201 sal_Int32 nOptions = bUseVariants ?
i18n::TextConversionOption::USE_CHARACTER_VARIANTS : 0;
202 if( !bCommonTerms )
203 nOptions = nOptions |
i18n::TextConversionOption::CHARACTER_BY_CHARACTER;
204
205 vcl::Font aTargetFont = OutputDevice::GetDefaultFont(
206 DefaultFontType::CJK_PRESENTATION,
** CID 1655081: (UNCAUGHT_EXCEPT)
/usr/include/c++/13/bits/unique_ptr.h: 206 in
std::__uniq_ptr_impl<sd::PaneHider,
std::default_delete<sd::PaneHider>>::reset(sd::PaneHider *)()
/usr/include/c++/13/bits/unique_ptr.h: 206 in
std::__uniq_ptr_impl<sd::framework::ConfigurationController::Lock,
std::default_delete<sd::framework::ConfigurationController::Lock>>::reset(sd::framework::ConfigurationController::Lock
*)()
_____________________________________________________________________________________________
*** CID 1655081: (UNCAUGHT_EXCEPT)
/usr/include/c++/13/bits/unique_ptr.h: 206 in
std::__uniq_ptr_impl<sd::PaneHider,
std::default_delete<sd::PaneHider>>::reset(sd::PaneHider *)()
200 _GLIBCXX23_CONSTEXPR
201 _Dp& _M_deleter() noexcept { return std::get<1>(_M_t); }
202 _GLIBCXX23_CONSTEXPR
203 const _Dp& _M_deleter() const noexcept { return
std::get<1>(_M_t); }
204
205 _GLIBCXX23_CONSTEXPR
>>> CID 1655081: (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown
>>> but the exception specification "noexcept" doesn't allow it to be thrown.
>>> This will result in a call to terminate().
206 void reset(pointer __p) noexcept
207 {
208 const pointer __old_p = _M_ptr();
209 _M_ptr() = __p;
210 if (__old_p)
211 _M_deleter()(__old_p);
/usr/include/c++/13/bits/unique_ptr.h: 206 in
std::__uniq_ptr_impl<sd::framework::ConfigurationController::Lock,
std::default_delete<sd::framework::ConfigurationController::Lock>>::reset(sd::framework::ConfigurationController::Lock
*)()
200 _GLIBCXX23_CONSTEXPR
201 _Dp& _M_deleter() noexcept { return std::get<1>(_M_t); }
202 _GLIBCXX23_CONSTEXPR
203 const _Dp& _M_deleter() const noexcept { return
std::get<1>(_M_t); }
204
205 _GLIBCXX23_CONSTEXPR
>>> CID 1655081: (UNCAUGHT_EXCEPT)
>>> An exception of type "com::sun::star::uno::RuntimeException" is thrown
>>> but the exception specification "noexcept" doesn't allow it to be thrown.
>>> This will result in a call to terminate().
206 void reset(pointer __p) noexcept
207 {
208 const pointer __old_p = _M_ptr();
209 _M_ptr() = __p;
210 if (__old_p)
211 _M_deleter()(__old_p);
** CID 1655080: Control flow issues (DEADCODE)
/sw/source/core/text/portxt.cxx: 427 in
SwTextPortion::Format_(SwTextFormatInfo &)()
_____________________________________________________________________________________________
*** CID 1655080: Control flow issues (DEADCODE)
/sw/source/core/text/portxt.cxx: 427 in
SwTextPortion::Format_(SwTextFormatInfo &)()
421 bool bOrigHyphenated = pGuess->HyphWord().is() &&
422 pGuess->BreakPos() > rInf.GetLineStart();
423 // calculate line breaking with desired word spacing, also
424 // if the desired word spacing is 100%, but there is a
greater
425 // maximum word spacing, and the word is hyphenated at the
desired
426 // word spacing: to skip hyphenation, if the maximum word
spacing allows it
>>> CID 1655080: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "bOrigHyphenated" inside this
>>> statement: "if (bWordSpacing || (bWordS...".
427 if ( bWordSpacing || ( bWordSpacingMaximum &&
bOrigHyphenated ) )
428 {
429 pGuess.emplace();
430 bFull = !pGuess->Guess( *this, rInf, Height(),
nSpacesInLine, aAdjustItem.GetPropWordSpacing(), nSpaceWidth );
431 sal_Int32 nSpacesInLine2 = rInf.GetLineSpaceCount(
pGuess->BreakPos() );
432
** CID 1655079: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sfx2/source/doc/docfile.cxx: 1791 in
SfxMedium::TryEncryptedInnerPackage(const
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &)()
_____________________________________________________________________________________________
*** CID 1655079: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/sfx2/source/doc/docfile.cxx: 1791 in
SfxMedium::TryEncryptedInnerPackage(const
com::sun::star::uno::Reference<com::sun::star::embed::XStorage> &)()
1785 if (outerMediaType.isEmpty() || outerMediaType !=
innerMediaType)
1786 {
1787 throw io::WrongFormatException(u"MediaType inconsistent in
encrypted ODF package"_ustr);
1788 }
1789 // success:
1790 pImpl->m_bODFWholesomeEncryption = true;
>>> CID 1655079: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "xDecryptedInnerPackageStream" is copied in a call to copy assignment
>>> "operator =", when it could be moved instead.
1791 pImpl->m_xODFDecryptedInnerPackageStream =
xDecryptedInnerPackageStream;
1792 pImpl->m_xODFEncryptedOuterStorage = xStorage;
1793 pImpl->xStorage = xRet;
1794 }
1795 return xRet;
1796 }
** CID 1655078: Possible Control flow issues (DEADCODE)
/sw/source/uibase/shells/annotsh.cxx: 1376 in
SwAnnotationShell::ExecLingu(SfxRequest &)()
_____________________________________________________________________________________________
*** CID 1655078: Possible Control flow issues (DEADCODE)
/sw/source/uibase/shells/annotsh.cxx: 1376 in
SwAnnotationShell::ExecLingu(SfxRequest &)()
1370 bool bUseVariants = false;
1371 bool bCommonTerms =
xDialog->getIsTranslateCommonTerms();
1372
1373 //execute translation
1374 LanguageType nSourceLang = bToSimplified ?
LANGUAGE_CHINESE_TRADITIONAL : LANGUAGE_CHINESE_SIMPLIFIED;
1375 LanguageType nTargetLang = bToSimplified ?
LANGUAGE_CHINESE_SIMPLIFIED : LANGUAGE_CHINESE_TRADITIONAL;
>>> CID 1655078: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "2" inside this statement:
>>> "nOptions = (bUseVariants ? ...".
1376 sal_Int32 nOptions = bUseVariants ?
i18n::TextConversionOption::USE_CHARACTER_VARIANTS : 0;
1377 if( !bCommonTerms )
1378 nOptions = nOptions |
i18n::TextConversionOption::CHARACTER_BY_CHARACTER;
1379
1380 vcl::Font aTargetFont = OutputDevice::GetDefaultFont(
DefaultFontType::CJK_TEXT,
1381 nTargetLang, GetDefaultFontFlags::OnlyOne
);
** CID 1655077: Possible Control flow issues (DEADCODE)
/sw/source/uibase/shells/drwtxtsh.cxx: 302 in
SwDrawTextShell::ExecDrawLingu(const SfxRequest &)()
_____________________________________________________________________________________________
*** CID 1655077: Possible Control flow issues (DEADCODE)
/sw/source/uibase/shells/drwtxtsh.cxx: 302 in
SwDrawTextShell::ExecDrawLingu(const SfxRequest &)()
296 bool bUseVariants = false;
297 bool bCommonTerms =
xDialog->getIsTranslateCommonTerms();
298
299 //execute translation
300 LanguageType nSourceLang = bToSimplified ?
LANGUAGE_CHINESE_TRADITIONAL : LANGUAGE_CHINESE_SIMPLIFIED;
301 LanguageType nTargetLang = bToSimplified ?
LANGUAGE_CHINESE_SIMPLIFIED : LANGUAGE_CHINESE_TRADITIONAL;
>>> CID 1655077: Possible Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "2" inside this statement:
>>> "nOptions = (bUseVariants ? ...".
302 sal_Int32 nOptions = bUseVariants ?
i18n::TextConversionOption::USE_CHARACTER_VARIANTS : 0;
303 if(!bCommonTerms)
304 nOptions = nOptions |
i18n::TextConversionOption::CHARACTER_BY_CHARACTER;
305
306 vcl::Font aTargetFont =
OutputDevice::GetDefaultFont(DefaultFontType::CJK_TEXT, nTargetLang,
GetDefaultFontFlags::OnlyOne);
307
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
