compilerplugins/clang/unusedfields.only-used-in-constructor.results | 32 +++++----- compilerplugins/clang/unusedfields.readonly.results | 6 - compilerplugins/clang/unusedfields.untouched.results | 22 ++++-- compilerplugins/clang/unusedfields.writeonly.results | 30 +++++---- 4 files changed, 47 insertions(+), 43 deletions(-)
New commits: commit 3b12495e480bf292342111aa09b9d422430bba69 Author: Noel Grandin <[email protected]> AuthorDate: Wed Jun 25 12:15:14 2025 +0200 Commit: Noel Grandin <[email protected]> CommitDate: Wed Jun 25 17:20:33 2025 +0200 loplugin:unusedfields update results Change-Id: Ie3d42903f1bad50fe948a47d5ad115de1ded864c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/186968 Tested-by: Jenkins Reviewed-by: Noel Grandin <[email protected]> diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results index 88aa8b8b03be..e0b137e5eba7 100644 --- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results +++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results @@ -18,7 +18,7 @@ canvas/source/tools/surfaceproxy.hxx:104 canvas::SurfaceProxy mpPageManager PageManagerSharedPtr canvas/source/vcl/impltools.hxx:95 vclcanvas::tools::LocalGuard aSolarGuard SolarMutexGuard -chart2/source/controller/accessibility/AccessibleChartShape.hxx:65 +chart2/source/controller/accessibility/AccessibleChartShape.hxx:62 chart::AccessibleChartShape m_aShapeTreeInfo ::accessibility::AccessibleShapeTreeInfo chart2/source/controller/dialogs/tp_3D_SceneIllumination.hxx:70 chart::ThreeD_SceneIllumination_TabPage m_aModelChangeListener ModifyListenerCallBack @@ -150,8 +150,6 @@ cui/source/inc/AdditionsDialog.hxx:82 AdditionsDialog m_sTag OUString cui/source/inc/cfgutil.hxx:244 SvxScriptSelectorDialog m_aStylesInfo SfxStylesInfo_Impl -cui/source/inc/connect.hxx:34 - SvxConnectionPage rOutAttrs const SfxItemSet & cui/source/inc/cuitabarea.hxx:232 SvxAreaTabPage maFixed_ChangeType ChangeType cui/source/inc/cuitabarea.hxx:236 @@ -556,7 +554,7 @@ sd/source/filter/eppt/epptbase.hxx:348 PPTWriterBase maFraction Fraction sd/source/filter/ppt/pptin.hxx:81 SdPPTImport maParam PowerPointImportParam -sd/source/ui/inc/AccessibleDocumentViewBase.hxx:246 +sd/source/ui/inc/AccessibleDocumentViewBase.hxx:244 accessibility::AccessibleDocumentViewBase maViewForwarder AccessibleViewForwarder sd/source/ui/inc/CustomAnimationList.hxx:127 sd::CustomAnimationList maDropTargetHelper CustomAnimationListDropTarget @@ -566,19 +564,21 @@ sd/source/ui/inc/SlideshowLayerRenderer.hxx:114 sd::RenderState mpCurrentTarget SdrObject * sd/source/ui/inc/SlideshowLayerRenderer.hxx:115 sd::RenderState mnCurrentTargetParagraph sal_Int32 +sd/source/ui/inc/ViewTabBar.hxx:74 + sd::TabBarButton HelpText OUString sd/source/ui/remotecontrol/Receiver.hxx:34 sd::Receiver pTransmitter Transmitter * sd/source/ui/remotecontrol/ZeroconfService.hxx:31 sd::ZeroconfService port uint sd/source/ui/view/DocumentRenderer.cxx:1650 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1310 +sd/source/ui/view/viewshel.cxx:1309 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1311 +sd/source/ui/view/viewshel.cxx:1310 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1312 +sd/source/ui/view/viewshel.cxx:1311 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1313 +sd/source/ui/view/viewshel.cxx:1312 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::SelectionObserver::Context sdext/source/pdfimport/pdfparse/pdfparse.cxx:249 (anonymous namespace)::PDFGrammar::definition boolean rule<ScannerT> @@ -732,15 +732,15 @@ svx/source/dialog/contimp.hxx:74 SvxSuperContourDlg aContourItem SvxContourDlgItem svx/source/dialog/framelinkarray.cxx:570 svx::frame::(anonymous namespace)::MergedCellIterator mnFirstRow sal_Int32 -svx/source/dialog/weldeditview.cxx:463 +svx/source/dialog/weldeditview.cxx:462 (anonymous namespace)::WeldEditSource m_rEditAcc WeldEditAccessible & svx/source/inc/datanavi.hxx:190 svxform::XFormsPage m_aDropHelper DataTreeDropTarget svx/source/svdraw/svdcrtv.cxx:49 ImplConnectMarkerOverlay maObjects sdr::overlay::OverlayObjectList -svx/source/svdraw/svdmrkv.cxx:143 +svx/source/svdraw/svdmrkv.cxx:146 MarkingSelectionOverlay maObjects sdr::overlay::OverlayObjectList -svx/source/svdraw/svdmrkv.cxx:168 +svx/source/svdraw/svdmrkv.cxx:171 MarkingSubSelectionOverlay maObjects sdr::overlay::OverlayObjectList svx/source/tbxctrls/extrusioncontrols.hxx:66 svx::ExtrusionDirectionWindow maImgDirection Image[9] @@ -984,15 +984,15 @@ vcl/unx/gtk3/gloactiongroup.cxx:27 (anonymous namespace)::GLOAction parent_instance GObject vcl/unx/gtk3/glomenu.cxx:16 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtkinst.cxx:7446 +vcl/unx/gtk3/gtkinst.cxx:7553 (anonymous namespace)::GtkInstanceAssistant m_pButtonBox GtkButtonBox * -vcl/unx/gtk3/gtkinst.cxx:11152 +vcl/unx/gtk3/gtkinst.cxx:11259 (anonymous namespace)::GtkInstanceMenuToggleButton m_pContainer GtkBox * -vcl/unx/gtk3/gtkinst.cxx:11154 +vcl/unx/gtk3/gtkinst.cxx:11261 (anonymous namespace)::GtkInstanceMenuToggleButton m_pMenuButton GtkMenuButton * -vcl/unx/gtk3/gtkinst.cxx:21304 +vcl/unx/gtk3/gtkinst.cxx:21411 (anonymous namespace)::GtkInstanceComboBox m_pOverlay GtkOverlay * -vcl/unx/gtk3/gtkinst.cxx:21310 +vcl/unx/gtk3/gtkinst.cxx:21417 (anonymous namespace)::GtkInstanceComboBox m_pMenuTextRenderer GtkCellRenderer * xmloff/inc/XMLThemeContext.hxx:45 XMLThemeColorsContext m_aColorScheme std::vector<css::util::Color> diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results index 81342f1d7fca..85dd6c74ff6a 100644 --- a/compilerplugins/clang/unusedfields.readonly.results +++ b/compilerplugins/clang/unusedfields.readonly.results @@ -752,10 +752,8 @@ sw/source/uibase/dbui/mmconfigitem.cxx:117 SwMailMergeConfigItem_Impl m_aNeutralGreetingLines std::vector<OUString> sw/source/uibase/inc/fldmgr.hxx:75 SwInsertField_Data m_aDBDataSource css::uno::Any -sw/source/uibase/inc/swrenamexnameddlg.hxx:30 - SwRenameXNamedDlg m_xSecondAccess css::uno::Reference<css::container::XNameAccess> -sw/source/uibase/inc/swrenamexnameddlg.hxx:31 - SwRenameXNamedDlg m_xThirdAccess css::uno::Reference<css::container::XNameAccess> +sw/source/writerfilter/dmapper/StyleSheetTable.hxx:157 + writerfilter::dmapper::StyleSheetTable m_ClonedTOCStylesMap std::map<OUString, OUString> sw/source/writerfilter/ooxml/OOXMLFactory.hxx:60 writerfilter::ooxml::AttributeInfo m_nToken Token_t sw/source/writerfilter/ooxml/OOXMLFactory.hxx:61 diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results index df12223922c3..8055dc5dc717 100644 --- a/compilerplugins/clang/unusedfields.untouched.results +++ b/compilerplugins/clang/unusedfields.untouched.results @@ -42,6 +42,8 @@ cui/source/inc/fileextcheckdlg.hxx:30 FileExtCheckDialog m_pOk std::unique_ptr<weld::Button> cui/source/inc/paragrph.hxx:73 SvxStdParagraphTabPage m_xAbsDist std::unique_ptr<weld::Label> +cui/source/inc/uipickerdlg.hxx:20 + UIPickerDialog m_xHelpBtn std::unique_ptr<weld::Button> cui/source/options/optinet2.hxx:108 SvxSecurityTabPage m_xCertPathImg std::unique_ptr<weld::Widget> cui/source/options/optinet2.hxx:109 @@ -82,8 +84,6 @@ filter/source/xsltdialog/xmlfiltertabpagebasic.hxx:35 XMLFilterTabPageBasic m_xContainer std::unique_ptr<weld::Widget> filter/source/xsltdialog/xmlfiltertabpagexslt.hxx:45 XMLFilterTabPageXSLT m_xContainer std::unique_ptr<weld::Widget> -forms/source/inc/FormComponent.hxx:148 - frm::OControl m_xContext css::uno::Reference<css::uno::XComponentContext> framework/inc/dispatch/dispatchprovider.hxx:76 framework::DispatchProvider m_aProtocolHandlerCache HandlerCache helpcompiler/inc/HelpCompiler.hxx:200 @@ -338,27 +338,31 @@ sd/source/ui/inc/CustomAnimationList.hxx:127 sd::CustomAnimationList maDropTargetHelper CustomAnimationListDropTarget sd/source/ui/inc/custsdlg.hxx:68 SdDefineCustomShowDlg m_xDropTargetHelper std::unique_ptr<weld::ReorderingDropTarget> +sd/source/ui/inc/framework/PresentationFactory.hxx:69 + sd::framework::PresentationFactory mxListener rtl::Reference<Listener> sd/source/ui/inc/SlideshowLayerRenderer.hxx:114 sd::RenderState mpCurrentTarget SdrObject * sd/source/ui/inc/SlideshowLayerRenderer.hxx:115 sd::RenderState mnCurrentTargetParagraph sal_Int32 sd/source/ui/inc/TableDesignPane.hxx:116 sd::TableDesignPane m_xImpl std::unique_ptr<TableDesignWidget> +sd/source/ui/inc/ViewTabBar.hxx:74 + sd::TabBarButton HelpText OUString sd/source/ui/remotecontrol/ZeroconfService.hxx:31 sd::ZeroconfService port uint sd/source/ui/slidesorter/view/SlsLayouter.cxx:63 sd::slidesorter::view::Layouter::Implementation mpTheme std::shared_ptr<view::Theme> sd/source/ui/view/DocumentRenderer.cxx:1650 sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef -sd/source/ui/view/viewshel.cxx:1310 +sd/source/ui/view/viewshel.cxx:1309 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::SlideSorterView::DrawLock -sd/source/ui/view/viewshel.cxx:1311 +sd/source/ui/view/viewshel.cxx:1310 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::SlideSorterController::ModelChangeLock -sd/source/ui/view/viewshel.cxx:1312 +sd/source/ui/view/viewshel.cxx:1311 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::PageSelector::UpdateLock -sd/source/ui/view/viewshel.cxx:1313 +sd/source/ui/view/viewshel.cxx:1312 sd::(anonymous namespace)::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::SelectionObserver::Context -sd/source/ui/view/ViewShellBase.cxx:197 +sd/source/ui/view/ViewShellBase.cxx:196 sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager> sdext/source/pdfimport/pdfparse/pdfparse.cxx:250 (anonymous namespace)::PDFGrammar::definition array rule<ScannerT> @@ -430,7 +434,7 @@ svtools/source/filter/exportdialog.hxx:124 ExportDialog mxEncoding std::unique_ptr<weld::Widget> svx/source/dialog/contimp.hxx:74 SvxSuperContourDlg aContourItem SvxContourDlgItem -svx/source/dialog/weldeditview.cxx:463 +svx/source/dialog/weldeditview.cxx:462 (anonymous namespace)::WeldEditSource m_rEditAcc WeldEditAccessible & svx/source/inc/datanavi.hxx:190 svxform::XFormsPage m_aDropHelper DataTreeDropTarget @@ -474,7 +478,7 @@ sw/source/uibase/inc/uivwimp.hxx:86 SwView_Impl m_xTmpSelDocShell SfxObjectShellLock sw/source/uibase/inc/unodispatch.hxx:44 SwXDispatchProviderInterceptor::DispatchMutexLock_Impl aGuard SolarMutexGuard -sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx:66 +sw/source/uibase/sidebar/A11yCheckIssuesPanel.hxx:68 sw::sidebar::AccessibilityCheckLevel m_xContainer std::unique_ptr<weld::Box> sw/source/uibase/sidebar/CommentsPanel.hxx:161 sw::sidebar::CommentsPanel mxShowReference std::unique_ptr<weld::CheckButton> diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results index 28b60408f694..3370984ec87b 100644 --- a/compilerplugins/clang/unusedfields.writeonly.results +++ b/compilerplugins/clang/unusedfields.writeonly.results @@ -84,9 +84,9 @@ canvas/source/cairo/cairo_spritehelper.hxx:98 cairocanvas::SpriteHelper mbTextureDirty _Bool chart2/inc/ChartModel.hxx:161 chart::ChartModel m_aGraphicObjectVector std::vector<GraphicObject> -chart2/inc/ChartModel.hxx:524 +chart2/inc/ChartModel.hxx:526 chart::ChartModel mnStart sal_Int32 -chart2/inc/ChartModel.hxx:525 +chart2/inc/ChartModel.hxx:527 chart::ChartModel mnEnd sal_Int32 chart2/source/controller/dialogs/DialogModel.cxx:178 (anonymous namespace)::lcl_RolesWithRangeAppend m_rDestCnt tContainerType * @@ -284,10 +284,12 @@ dbaccess/source/ui/browser/dbloader.cxx:60 (anonymous namespace)::DBContentLoader m_xListener Reference<XLoadEventListener> dbaccess/source/ui/inc/RelationController.hxx:36 dbaui::ORelationController m_xWaitObject std::unique_ptr<weld::WaitObject> -desktop/qa/desktop_lib/test_desktop_lib.cxx:320 +desktop/qa/desktop_lib/test_desktop_lib.cxx:316 DesktopLOKTest m_bModified _Bool -desktop/qa/desktop_lib/test_desktop_lib.cxx:321 +desktop/qa/desktop_lib/test_desktop_lib.cxx:317 DesktopLOKTest m_nTrackChanges int +desktop/qa/desktop_lib/test_desktop_lib.cxx:2209 + (anonymous namespace)::RedlineInfo index std::string desktop/source/app/app.cxx:1285 desktop::(anonymous namespace)::ExecuteGlobals pCTLLanguageOptions std::unique_ptr<SvtCTLOptions> desktop/source/app/app.cxx:1286 @@ -1214,7 +1216,7 @@ sd/source/console/PresenterTimer.cxx:111 sdext::presenter::(anonymous namespace)::TimerScheduler mpLateDestroy std::shared_ptr<TimerScheduler> sd/source/ui/dlg/RemoteDialogClientBox.hxx:66 sd::ClientBox m_vEntries std::vector<TClientBoxEntry> -sd/source/ui/framework/module/ToolBarModule.hxx:84 +sd/source/ui/framework/module/ToolBarModule.hxx:80 sd::framework::ToolBarModule mpToolBarManagerLock std::unique_ptr<ToolBarManager::UpdateLock, o3tl::default_delete<ToolBarManager::UpdateLock> > sd/source/ui/inc/animobjs.hxx:122 sd::AnimationWindow pControllerItem std::unique_ptr<AnimationControllerItem> @@ -1494,7 +1496,7 @@ sw/inc/unoframe.hxx:310 SwXOLEListener m_xOLEModel css::uno::Reference<css::frame::XModel> sw/inc/view.hxx:197 SwView m_xGlueDocShell std::unique_ptr<SwViewGlueDocShell> -sw/qa/core/doc/doc.cxx:398 +sw/qa/core/doc/doc.cxx:399 (anonymous namespace)::SelectionChangeListener m_aAnchors std::vector<uno::Reference<text::XTextRange> > sw/source/core/doc/docbm.cxx:549 sw::mark::UniqueNameChecksGuard_impl usedNames std::unordered_set<OUString> @@ -1546,9 +1548,9 @@ sw/source/uibase/inc/maildispatcher.hxx:149 MailDispatcher m_xSelfReference ::rtl::Reference<MailDispatcher> sw/source/uibase/inc/navipi.hxx:62 SwNavigationPI m_xContent3Dispatch std::unique_ptr<ToolbarUnoDispatcher> -sw/source/uibase/inc/redlndlg.hxx:62 - SwRedlineAcceptDlg m_RedlinData std::vector<std::unique_ptr<RedlinData> > sw/source/uibase/inc/redlndlg.hxx:63 + SwRedlineAcceptDlg m_RedlinData std::vector<std::unique_ptr<RedlinData> > +sw/source/uibase/inc/redlndlg.hxx:64 SwRedlineAcceptDlg m_aUsedSeqNo SwRedlineDataParentSortArr sw/source/uibase/sidebar/TableEditPanel.hxx:51 sw::sidebar::TableEditPanel m_xInsertDispatch std::unique_ptr<ToolbarUnoDispatcher> @@ -1956,15 +1958,15 @@ vcl/source/fontsubset/sft.cxx:70 vcl::(anonymous namespace)::TTGlyphMetrics lsb sal_Int16 vcl/source/fontsubset/sft.cxx:71 vcl::(anonymous namespace)::TTGlyphMetrics ah sal_uInt16 -vcl/unx/generic/app/wmadaptor.cxx:1268 +vcl/unx/generic/app/wmadaptor.cxx:1267 _mwmhints deco unsigned long -vcl/unx/generic/app/wmadaptor.cxx:1268 +vcl/unx/generic/app/wmadaptor.cxx:1267 _mwmhints flags unsigned long -vcl/unx/generic/app/wmadaptor.cxx:1268 +vcl/unx/generic/app/wmadaptor.cxx:1267 _mwmhints func unsigned long -vcl/unx/generic/app/wmadaptor.cxx:1269 +vcl/unx/generic/app/wmadaptor.cxx:1268 _mwmhints input_mode tools::Long -vcl/unx/generic/app/wmadaptor.cxx:1270 +vcl/unx/generic/app/wmadaptor.cxx:1269 _mwmhints status unsigned long vcl/unx/generic/gdi/cairotextrender.cxx:51 (anonymous namespace)::CairoFontsCache::CacheId maFace FT_Face @@ -1978,7 +1980,7 @@ vcl/unx/gtk3/a11y/atkwrapper.hxx:80 AtkObjectWrapperClass aParentClass GtkWidgetAccessibleClass vcl/unx/gtk3/glomenu.cxx:16 GLOMenu parent_instance const GMenuModel -vcl/unx/gtk3/gtkinst.cxx:21315 +vcl/unx/gtk3/gtkinst.cxx:21422 (anonymous namespace)::GtkInstanceComboBox m_xCustomMenuButtonHelper std::unique_ptr<CustomRenderMenuButtonHelper> vcl/unx/gtk3/hudawareness.cxx:18 (anonymous namespace)::HudAwarenessHandle connection gpointer
