vcl/source/treelist/svtabbx.cxx | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
New commits: commit 569a7d76e4d6598edf73e878689e721b830fd851 Author: Skyler Grey <[email protected]> AuthorDate: Tue Jul 8 14:24:00 2025 +0000 Commit: Szymon Kłos <[email protected]> CommitDate: Tue Jul 8 20:24:45 2025 +0200 fix: exclude editable field when edit is disabled There are some dialogs which have spurious 'IsEditable' responses (e.g. the autofilter dialog in calc) but which are still not editable globally - IsInplaceEditingEnabled returns false. We shouldn't be reporting their fields as editable when they are not. Signed-off-by: Skyler Grey <[email protected]> Change-Id: Iea90267406addf40c139bc77b827f920b8be6a97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187545 Tested-by: Jenkins CollaboraOffice <[email protected]> Reviewed-by: Szymon Kłos <[email protected]> diff --git a/vcl/source/treelist/svtabbx.cxx b/vcl/source/treelist/svtabbx.cxx index 14dc8387d8ff..edf47d9f47d9 100644 --- a/vcl/source/treelist/svtabbx.cxx +++ b/vcl/source/treelist/svtabbx.cxx @@ -99,9 +99,12 @@ static void lcl_DumpEntryAndSiblings(tools::JsonWriter& rJsonWriter, auto aColumn = rJsonWriter.startStruct(); rJsonWriter.put("text", pStringItem->GetText()); - SvLBoxTab* pTab = pTabListBox->GetTab( pEntry, &rItem ); - if ( pTab ) - rJsonWriter.put("editable", pTab->IsEditable()); + if (pTabListBox->IsInplaceEditingEnabled()) { + SvLBoxTab* pTab = pTabListBox->GetTab( pEntry, &rItem ); + if ( pTab ) { + rJsonWriter.put("editable", pTab->IsEditable()); + } + } if (pStringItem->IsCustomRender()) rJsonWriter.put("customEntryRenderer", true);
