basctl/source/basicide/bastype3.cxx | 2 +- framework/source/services/autorecovery.cxx | 2 +- sc/source/core/data/column.cxx | 6 +++--- sc/source/core/data/column3.cxx | 12 ++++++------ sc/source/core/data/document.cxx | 6 +++--- sc/source/core/data/document10.cxx | 12 ++++++------ sc/source/core/data/table4.cxx | 6 +++--- sfx2/source/appl/appuno.cxx | 2 +- tools/source/generic/config.cxx | 2 +- unoidl/source/legacyprovider.cxx | 8 ++++---- 10 files changed, 29 insertions(+), 29 deletions(-)
New commits: commit c2e99a25028cc0d215f7bb50b08b5a25babce26b Author: Caolán McNamara <[email protected]> AuthorDate: Tue Aug 5 08:52:41 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Tue Aug 5 12:05:04 2025 +0200 cid#1555615 Variable copied when it could be moved and cid#1555637 Variable copied when it could be moved cid#1555640 Variable copied when it could be moved cid#1555863 Variable copied when it could be moved cid#1556471 Variable copied when it could be moved cid#1556634 Variable copied when it could be moved cid#1556731 Variable copied when it could be moved cid#1556751 Variable copied when it could be moved cid#1556807 Variable copied when it could be moved cid#1557366 Variable copied when it could be moved cid#1558026 Variable copied when it could be moved Change-Id: I187cb364877d35acd843d8391e5b376437ec96f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188935 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/basctl/source/basicide/bastype3.cxx b/basctl/source/basicide/bastype3.cxx index 741409665d44..4e84562f725f 100644 --- a/basctl/source/basicide/bastype3.cxx +++ b/basctl/source/basicide/bastype3.cxx @@ -248,7 +248,7 @@ EntryDescriptor SbTreeListBox::GetEntryDescriptor(const weld::TreeIter* pEntry) EntryType eType = OBJ_TYPE_UNKNOWN; if ( !pEntry ) - return EntryDescriptor( aDocument, eLocation, aLibName, aLibSubName, aName, aMethodName, eType ); + return EntryDescriptor(std::move(aDocument), eLocation, aLibName, aLibSubName, aName, aMethodName, eType); std::vector<std::pair<Entry*, OUString>> aEntries; diff --git a/framework/source/services/autorecovery.cxx b/framework/source/services/autorecovery.cxx index 9f5072e1b7ba..b2431fd93e59 100644 --- a/framework/source/services/autorecovery.cxx +++ b/framework/source/services/autorecovery.cxx @@ -2953,7 +2953,7 @@ AutoRecovery::ETimerType AutoRecovery::implts_saveDocs( bool bAllow if ( !xDocRecover->wasModifiedSinceLastSave() ) { aInfo.DocumentState |= DocState::Handled; - *pIt = aInfo; + *pIt = std::move(aInfo); continue; } diff --git a/sc/source/core/data/column.cxx b/sc/source/core/data/column.cxx index 4ef8dff3d01c..41c603f5b777 100644 --- a/sc/source/core/data/column.cxx +++ b/sc/source/core/data/column.cxx @@ -2173,9 +2173,9 @@ class UpdateRefOnNonCopy // Make sure that the start and end listening contexts share the // same block position set, else an invalid iterator may ensue. - const auto pPosSet = std::make_shared<sc::ColumnBlockPositionSet>(mpCxt->mrDoc); - sc::StartListeningContext aStartCxt(mpCxt->mrDoc, pPosSet); - sc::EndListeningContext aEndCxt(mpCxt->mrDoc, pPosSet, &aOldCode); + auto xPosSet = std::make_shared<sc::ColumnBlockPositionSet>(mpCxt->mrDoc); + sc::StartListeningContext aStartCxt(mpCxt->mrDoc, xPosSet); + sc::EndListeningContext aEndCxt(mpCxt->mrDoc, std::move(xPosSet), &aOldCode); aEndCxt.setPositionDelta( ScAddress(-mpCxt->mnColDelta, -mpCxt->mnRowDelta, -mpCxt->mnTabDelta)); diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx index a56bb6bbcb59..0d0670011ea5 100644 --- a/sc/source/core/data/column3.cxx +++ b/sc/source/core/data/column3.cxx @@ -437,9 +437,9 @@ void ScColumn::StartListeningUnshared( const std::vector<SCROW>& rNewSharedRows if (rNewSharedRows.empty() || rDoc.IsDelayedFormulaGrouping()) return; - const auto pPosSet = std::make_shared<sc::ColumnBlockPositionSet>(rDoc); - sc::StartListeningContext aStartCxt(rDoc, pPosSet); - sc::EndListeningContext aEndCxt(rDoc, pPosSet); + auto xPosSet = std::make_shared<sc::ColumnBlockPositionSet>(rDoc); + sc::StartListeningContext aStartCxt(rDoc, xPosSet); + sc::EndListeningContext aEndCxt(rDoc, std::move(xPosSet)); if (rNewSharedRows.size() >= 2) { if(!rDoc.CanDelayStartListeningFormulaCells( this, rNewSharedRows[0], rNewSharedRows[1])) @@ -711,9 +711,9 @@ void ScColumn::AttachNewFormulaCell( { case sc::ConvertToGroupListening: { - const auto pPosSet = std::make_shared<sc::ColumnBlockPositionSet>(rDocument); - sc::StartListeningContext aStartCxt(rDocument, pPosSet); - sc::EndListeningContext aEndCxt(rDocument, pPosSet); + auto xPosSet = std::make_shared<sc::ColumnBlockPositionSet>(rDocument); + sc::StartListeningContext aStartCxt(rDocument, xPosSet); + sc::EndListeningContext aEndCxt(rDocument, std::move(xPosSet)); SCROW nStartRow, nEndRow; nStartRow = nEndRow = aPos.first->position + aPos.second; for (const SCROW nR : rNewSharedRows) diff --git a/sc/source/core/data/document.cxx b/sc/source/core/data/document.cxx index 97cff73ddd7a..e179081ce6df 100644 --- a/sc/source/core/data/document.cxx +++ b/sc/source/core/data/document.cxx @@ -2646,9 +2646,9 @@ void ScDocument::StartListeningFromClip( SCCOL nCol1, SCROW nRow1, if (!(nInsFlag & InsertDeleteFlags::CONTENTS)) return; - const auto pSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); - sc::StartListeningContext aStartCxt(*this, pSet); - sc::EndListeningContext aEndCxt(*this, pSet, nullptr); + auto xSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); + sc::StartListeningContext aStartCxt(*this, xSet); + sc::EndListeningContext aEndCxt(*this, std::move(xSet), nullptr); for (SCTAB nTab : rMark) StartListeningFromClip(aStartCxt, aEndCxt, nTab, nCol1, nRow1, nCol2, nRow2); diff --git a/sc/source/core/data/document10.cxx b/sc/source/core/data/document10.cxx index 68cbf2ea5b54..cf6cae5d296f 100644 --- a/sc/source/core/data/document10.cxx +++ b/sc/source/core/data/document10.cxx @@ -225,9 +225,9 @@ void ScDocument::SwapNonEmpty( sc::TableValues& rValues ) if (!rRange.IsValid()) return; - const auto pPosSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); - sc::StartListeningContext aStartCxt(*this, pPosSet); - sc::EndListeningContext aEndCxt(*this, pPosSet); + auto xPosSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); + sc::StartListeningContext aStartCxt(*this, xPosSet); + sc::EndListeningContext aEndCxt(*this, std::move(xPosSet)); for (SCTAB nTab = rRange.aStart.Tab(); nTab <= rRange.aEnd.Tab(); ++nTab) { @@ -563,9 +563,9 @@ void ScDocument::StartAllListeners( const ScRange& rRange ) if (IsClipOrUndo() || GetNoListening()) return; - const auto pPosSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); - sc::StartListeningContext aStartCxt(*this, pPosSet); - sc::EndListeningContext aEndCxt(*this, pPosSet); + auto xPosSet = std::make_shared<sc::ColumnBlockPositionSet>(*this); + sc::StartListeningContext aStartCxt(*this, xPosSet); + sc::EndListeningContext aEndCxt(*this, std::move(xPosSet)); for (SCTAB nTab = rRange.aStart.Tab(); nTab <= rRange.aEnd.Tab(); ++nTab) { diff --git a/sc/source/core/data/table4.cxx b/sc/source/core/data/table4.cxx index 46635b64fda3..718aae92f8d4 100644 --- a/sc/source/core/data/table4.cxx +++ b/sc/source/core/data/table4.cxx @@ -1807,9 +1807,9 @@ void ScTable::FillFormulaVertical( aCol[nCol].DeleteRanges(aSpans, InsertDeleteFlags::VALUE | InsertDeleteFlags::DATETIME | InsertDeleteFlags::STRING | InsertDeleteFlags::FORMULA | InsertDeleteFlags::OUTLINE); aCol[nCol].CloneFormulaCell(rSrcCell, sc::CellTextAttr(), aSpans); - const auto pSet = std::make_shared<sc::ColumnBlockPositionSet>(rDocument); - sc::StartListeningContext aStartCxt(rDocument, pSet); - sc::EndListeningContext aEndCxt(rDocument, pSet); + auto xSet = std::make_shared<sc::ColumnBlockPositionSet>(rDocument); + sc::StartListeningContext aStartCxt(rDocument, xSet); + sc::EndListeningContext aEndCxt(rDocument, std::move(xSet)); SCROW nStartRow = aSpans.front().mnRow1; SCROW nEndRow = aSpans.back().mnRow2; diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx index b9540dfbf1c4..8e11aeace279 100644 --- a/sfx2/source/appl/appuno.cxx +++ b/sfx2/source/appl/appuno.cxx @@ -1329,7 +1329,7 @@ void TransformItems( sal_uInt16 nSlotId, const SfxItemSet& rSet, uno::Sequence<b } } - rArgs = aSequ; + rArgs = std::move(aSequ); return; } diff --git a/unoidl/source/legacyprovider.cxx b/unoidl/source/legacyprovider.cxx index c5b92e942861..5e46bf6e03e1 100644 --- a/unoidl/source/legacyprovider.cxx +++ b/unoidl/source/legacyprovider.cxx @@ -508,17 +508,17 @@ rtl::Reference< Entity > readEntity( case RTReferenceType::EXPORTS: if (!(reader.getReferenceFlags(j) & RTFieldAccess::OPTIONAL)) { - mandServs.push_back(base); + mandServs.push_back(std::move(base)); } else { - optServs.push_back(base); + optServs.push_back(std::move(base)); } break; case RTReferenceType::SUPPORTS: if (!(reader.getReferenceFlags(j) & RTFieldAccess::OPTIONAL)) { - mandIfcs.push_back(base); + mandIfcs.push_back(std::move(base)); } else { - optIfcs.push_back(base); + optIfcs.push_back(std::move(base)); } break; default: commit 07393eb2cc25cc1bea6f2b5ef9a64747d3acfbef Author: Caolán McNamara <[email protected]> AuthorDate: Tue Aug 5 08:49:20 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Tue Aug 5 12:04:55 2025 +0200 cid#1659901 silence Logically dead code Change-Id: I615714cca414e004368bb781b4ed1aacce027a57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188934 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/tools/source/generic/config.cxx b/tools/source/generic/config.cxx index 07cd81bf1382..8389c578da52 100644 --- a/tools/source/generic/config.cxx +++ b/tools/source/generic/config.cxx @@ -102,8 +102,8 @@ static std::unique_ptr<sal_uInt8[]> ImplSysReadConfig( const OUString& rFileName sal_uInt64 nPos = 0; if( aFile.getSize( nPos ) == ::osl::FileBase::E_None ) { + // coverity[dead_error_condition] - suppress warning, 32bit platforms still if (nPos > SAL_MAX_SIZE) { - // coverity[dead_error_line] - suppress warning, 32bit platforms still aFile.close(); return nullptr; }
