basctl/source/basicide/documentenumeration.cxx | 2 +- dbaccess/source/ui/misc/indexcollection.cxx | 2 +- sc/source/ui/miscdlgs/retypepassdlg.cxx | 2 +- sw/source/filter/ww8/docxattributeoutput.cxx | 2 +- sw/source/filter/ww8/ww8scan.cxx | 2 +- sw/source/uibase/docvw/PageBreakWin.cxx | 6 +++--- vcl/source/window/toolbox2.cxx | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-)
New commits: commit 368cd2678f91303065975fcfee3e39cdc8c038a0 Author: Caolán McNamara <[email protected]> AuthorDate: Tue Aug 5 21:14:23 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Wed Aug 6 09:33:31 2025 +0200 cid#1660185 Variable copied when it could be moved and cid#1660184 Variable copied when it could be moved cid#1660183 Variable copied when it could be moved cid#1660182 Variable copied when it could be moved cid#1660181 Variable copied when it could be moved cid#1660177 Variable copied when it could be moved cid#1660176 Variable copied when it could be moved Change-Id: Id5c90c0a0d4a0a86ef0f4b513b45c2db3a97b207 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188975 Tested-by: Jenkins Reviewed-by: Caolán McNamara <[email protected]> diff --git a/basctl/source/basicide/documentenumeration.cxx b/basctl/source/basicide/documentenumeration.cxx index 60ace06d2bac..306ed3748c9f 100644 --- a/basctl/source/basicide/documentenumeration.cxx +++ b/basctl/source/basicide/documentenumeration.cxx @@ -124,7 +124,7 @@ namespace basctl::docs { if ( _pFilter && !_pFilter->includeDocument( aDescriptor ) ) continue; - _out_rDocuments.push_back( aDescriptor ); + _out_rDocuments.push_back(std::move(aDescriptor)); } catch( const Exception& ) { diff --git a/dbaccess/source/ui/misc/indexcollection.cxx b/dbaccess/source/ui/misc/indexcollection.cxx index 5949333b57c8..5c29759fd182 100644 --- a/dbaccess/source/ui/misc/indexcollection.cxx +++ b/dbaccess/source/ui/misc/indexcollection.cxx @@ -309,7 +309,7 @@ namespace dbaui // fill the OIndex structure OIndex aCurrentIndex(name); implFillIndexInfo(aCurrentIndex, xIndex); - m_aIndexes.push_back(aCurrentIndex); + m_aIndexes.push_back(std::move(aCurrentIndex)); } } diff --git a/sc/source/ui/miscdlgs/retypepassdlg.cxx b/sc/source/ui/miscdlgs/retypepassdlg.cxx index 4dc5808a8bae..40170a0235b4 100644 --- a/sc/source/ui/miscdlgs/retypepassdlg.cxx +++ b/sc/source/ui/miscdlgs/retypepassdlg.cxx @@ -83,7 +83,7 @@ void ScRetypePassDlg::SetDataFromDocument(const ScDocument& rDoc) if (pTabProtect && pTabProtect->isProtected()) aTabItem.mpProtect = std::make_shared<ScTableProtection>(*pTabProtect); - maTableItems.push_back(aTabItem); + maTableItems.push_back(std::move(aTabItem)); maSheets.emplace_back(new PassFragment(mxSheetsBox.get())); maSheets.back()->m_xButton->connect_clicked(LINK(this, ScRetypePassDlg, RetypeBtnHdl)); } diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx index 9379e06ac660..42e20dbbb368 100644 --- a/sw/source/filter/ww8/docxattributeoutput.cxx +++ b/sw/source/filter/ww8/docxattributeoutput.cxx @@ -8726,7 +8726,7 @@ void DocxAttributeOutput::WriteField_Impl(const SwField *const pField, infos.bClose = bool(FieldFlags::Close & nMode); infos.bSep = bool(FieldFlags::CmdEnd & nMode); infos.bOpen = bool(FieldFlags::Start & nMode); - m_Fields.push_back( infos ); + m_Fields.push_back(std::move(infos)); if (pBookmarkName) { diff --git a/sw/source/filter/ww8/ww8scan.cxx b/sw/source/filter/ww8/ww8scan.cxx index 477ed7180bd2..b5e4ccefe3f8 100644 --- a/sw/source/filter/ww8/ww8scan.cxx +++ b/sw/source/filter/ww8/ww8scan.cxx @@ -4250,7 +4250,7 @@ void WW8ReadSTTBF(bool bVer8, SvStream& rStrm, sal_uInt32 nStart, sal_Int32 nLen { ww::bytes extraData(nExtraLen); rStrm.ReadBytes(extraData.data(), nExtraLen); - pExtraArray->push_back(extraData); + pExtraArray->push_back(std::move(extraData)); } else rStrm.SeekRel( nExtraLen ); diff --git a/sw/source/uibase/docvw/PageBreakWin.cxx b/sw/source/uibase/docvw/PageBreakWin.cxx index 7e111f14f5be..ef41b1898ec0 100644 --- a/sw/source/uibase/docvw/PageBreakWin.cxx +++ b/sw/source/uibase/docvw/PageBreakWin.cxx @@ -233,11 +233,11 @@ void SwPageBreakWin::PaintButton() drawinglayer::primitive2d::Primitive2DContainer aGhostedSeq; double nFadeRate = double(m_nFadeRate) / 100.0; - const basegfx::BColorModifierSharedPtr aBColorModifier = - std::make_shared<basegfx::BColorModifier_interpolate>(COL_WHITE.getBColor(), + basegfx::BColorModifierSharedPtr aBColorModifier = + std::make_shared<basegfx::BColorModifier_interpolate>(COL_WHITE.getBColor(), 1.0 - nFadeRate); aGhostedSeq.push_back( new drawinglayer::primitive2d::ModifiedColorPrimitive2D( - std::move(aSeq), aBColorModifier)); + std::move(aSeq), std::move(aBColorModifier))); // Create the processor and process the primitives const drawinglayer::geometry::ViewInformation2D aNewViewInfos; diff --git a/vcl/source/window/toolbox2.cxx b/vcl/source/window/toolbox2.cxx index 2392257e0ec6..07ada8b6fa40 100644 --- a/vcl/source/window/toolbox2.cxx +++ b/vcl/source/window/toolbox2.cxx @@ -587,7 +587,7 @@ void ToolBox::CopyItem( const ToolBox& rToolBox, ToolBoxItemId nItemId ) aNewItem.mpWindow = nullptr; aNewItem.mbShowWindow = false; - mpData->m_aItems.push_back( aNewItem ); + mpData->m_aItems.push_back(std::move(aNewItem)); mpData->ImplClearLayoutData(); // redraw ToolBox ImplInvalidate();
