vcl/qt5/QtInstanceComboBox.cxx |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 56d651a63c2e4bf41cfcc2eaf3b5106d06f3da5e
Author:     Michael Weghorn <[email protected]>
AuthorDate: Wed Aug 13 14:52:30 2025 +0200
Commit:     Michael Weghorn <[email protected]>
CommitDate: Wed Aug 13 21:48:38 2025 +0200

    tdf#130857 qt weld: Demote assert in QtInstanceComboBox::set_width_chars
    
    Only warn, no longer assert to not block other work
    (in particular adding support for the "File" -> "Properties"
    dialog) in an upcoming commit.
    
    See also
    
        commit 14d01d78ca82a57080fd9582e362b45780961540
        Author: Michael Weghorn <[email protected]>
        Date:   Sat Feb 15 18:06:58 2025 +0100
    
            tdf#130857 qt weld: Demote assert in 
QtInstanceEntry::set_width_chars
    
    which did the same for QtInstanceEntry::set_width_chars.
    
    Change-Id: I804a9c5659d23481e5476e2d9b2b7c0310388146
    Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189519
    Reviewed-by: Michael Weghorn <[email protected]>
    Tested-by: Jenkins

diff --git a/vcl/qt5/QtInstanceComboBox.cxx b/vcl/qt5/QtInstanceComboBox.cxx
index 9286897f149d..eaba58fe9aa7 100644
--- a/vcl/qt5/QtInstanceComboBox.cxx
+++ b/vcl/qt5/QtInstanceComboBox.cxx
@@ -240,7 +240,12 @@ void QtInstanceComboBox::set_entry_text(const OUString& 
rStr)
     GetQtInstance().RunInMainThread([&] { 
m_pComboBox->setEditText(toQString(rStr)); });
 }
 
-void QtInstanceComboBox::set_entry_width_chars(int) { assert(false && "Not 
implemented yet"); }
+void QtInstanceComboBox::set_entry_width_chars(int)
+{
+    // see also QtInstanceEntry::set_width_chars, might be able to reuse logic 
once
+    // that is implemented
+    SAL_WARN("vcl.qt", "QtInstanceComboBox::set_width_chars not implemented 
yet");
+}
 
 void QtInstanceComboBox::set_entry_max_length(int) { assert(false && "Not 
implemented yet"); }
 

Reply via email to