basctl/source/basicide/iderdll.cxx | 1 - basegfx/source/matrix/b3dhommatrix.cxx | 2 -- basic/source/comp/buffer.cxx | 1 - basic/source/sbx/sbxbase.cxx | 1 - bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx | 4 ---- bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx | 2 +- bridges/source/cpp_uno/shared/vtablefactory.cxx | 2 -- comphelper/source/misc/backupfilehelper.cxx | 3 +-- comphelper/source/misc/storagehelper.cxx | 1 - cppu/source/helper/purpenv/helper_purpenv_Proxy.cxx | 1 - cppu/source/typelib/static_types.cxx | 3 +-- cppu/source/typelib/typelib.cxx | 2 -- cppu/source/uno/copy.hxx | 1 - cppu/source/uno/data.cxx | 1 - cppu/source/uno/sequence.cxx | 6 +----- drawinglayer/source/processor2d/cairopixelprocessor2d.cxx | 2 +- 16 files changed, 5 insertions(+), 28 deletions(-)
New commits: commit d3fcc9a5b698aa92a980beb447d08f8299532743 Author: Caolán McNamara <[email protected]> AuthorDate: Tue Aug 12 11:04:28 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Aug 15 11:25:12 2025 +0200 drop apparently no longer needed coverity markup Change-Id: Ia8b3b271bb5cc67131b50d563bed58400da5b317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189662 Reviewed-by: Caolán McNamara <[email protected]> Tested-by: Jenkins diff --git a/basctl/source/basicide/iderdll.cxx b/basctl/source/basicide/iderdll.cxx index 6796cc640c46..191fc92f295c 100644 --- a/basctl/source/basicide/iderdll.cxx +++ b/basctl/source/basicide/iderdll.cxx @@ -73,7 +73,6 @@ struct theDllInstance : public rtl::Static<DllInstance, theDllInstance> { }; void EnsureIde () { - // coverity[side_effect_free : FALSE] - not actually side-effect-free theDllInstance::get(); } diff --git a/basegfx/source/matrix/b3dhommatrix.cxx b/basegfx/source/matrix/b3dhommatrix.cxx index 96edab9158b6..35cac47b1822 100644 --- a/basegfx/source/matrix/b3dhommatrix.cxx +++ b/basegfx/source/matrix/b3dhommatrix.cxx @@ -467,7 +467,6 @@ namespace basegfx if(!fTools::equalZero(fShearY)) { - // coverity[copy_paste_error : FALSE] - this is correct getZ, not getY rShear.setY(rShear.getY() / rScale.getZ()); } @@ -475,7 +474,6 @@ namespace basegfx if(!fTools::equalZero(fShearZ)) { - // coverity[original] - this is not an original copy-and-paste source for ^^^ rShear.setZ(rShear.getZ() / rScale.getZ()); } diff --git a/basic/source/comp/buffer.cxx b/basic/source/comp/buffer.cxx index 0ff898fd6940..38dbbb2095a5 100644 --- a/basic/source/comp/buffer.cxx +++ b/basic/source/comp/buffer.cxx @@ -27,7 +27,6 @@ const sal_uInt32 UP_LIMIT=0xFFFFFF00; template <class I, typename T> void write(I it, T n) { *it = static_cast<sal_uInt8>(n & 0xFF); - // coverity[stray_semicolon : FALSE] - coverity parse error if constexpr (sizeof(n) > 1) { for (std::size_t i = 1; i < sizeof(n); ++i) diff --git a/basic/source/sbx/sbxbase.cxx b/basic/source/sbx/sbxbase.cxx index 1d34683aea19..4676bc59df30 100644 --- a/basic/source/sbx/sbxbase.cxx +++ b/basic/source/sbx/sbxbase.cxx @@ -194,7 +194,6 @@ SbxObjectRef SbxBase::CreateObject( const OUString& rClass ) namespace { -// coverity[ -taint_source ] [[nodiscard]] SbxFlagBits CorrectFlags(SbxFlagBits nFlags) { // Correcting a foolishness of mine: diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx index 4f724dbb6861..dbd4ef1a1517 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/abi.cxx @@ -223,7 +223,6 @@ classify_argument( typelib_TypeDescriptionReference *pTypeRef, enum x86_64_reg_c bool x86_64::examine_argument( typelib_TypeDescriptionReference *pTypeRef, int &nUsedGPR, int &nUsedSSE ) noexcept { enum x86_64_reg_class classes[MAX_CLASSES]; - // coverity[uninit_use_in_call : FALSE] int n = classify_argument( pTypeRef, classes, 0 ); if ( n == 0 ) @@ -254,13 +253,11 @@ bool x86_64::return_in_hidden_param( typelib_TypeDescriptionReference *pTypeRef return false; } enum x86_64_reg_class classes[MAX_CLASSES]; - // coverity[uninit_use_in_call : FALSE] return classify_argument(pTypeRef, classes, 0) == 0; } x86_64::ReturnKind x86_64::getReturnKind(typelib_TypeDescriptionReference * type) noexcept { x86_64_reg_class classes[MAX_CLASSES]; - // coverity[uninit_use_in_call : FALSE] auto const n = classify_argument(type, classes, 0); if (n == 0) { return ReturnKind::Memory; @@ -281,7 +278,6 @@ x86_64::ReturnKind x86_64::getReturnKind(typelib_TypeDescriptionReference * type void x86_64::fill_struct( typelib_TypeDescriptionReference *pTypeRef, const sal_uInt64 *pGPR, const double *pSSE, void *pStruct ) noexcept { enum x86_64_reg_class classes[MAX_CLASSES]; - // coverity[uninit_use_in_call : FALSE] int n = classify_argument( pTypeRef, classes, 0 ); sal_uInt64 *pStructAlign = static_cast<sal_uInt64 *>( pStruct ); diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx index c901449422dd..6423c184e64b 100644 --- a/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx +++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx @@ -113,7 +113,7 @@ static void cpp_call( // Return typelib_TypeDescription * pReturnTypeDescr = nullptr; - // coverity[freed_arg] - pReturnTypeRef's nRefCount is > 1 here + // coverity[freed_arg] 2024.6.1 - pReturnTypeRef's nRefCount is > 1 here TYPELIB_DANGER_GET( &pReturnTypeDescr, pReturnTypeRef ); assert(pReturnTypeDescr); diff --git a/bridges/source/cpp_uno/shared/vtablefactory.cxx b/bridges/source/cpp_uno/shared/vtablefactory.cxx index e428d042be56..1fb768b21849 100644 --- a/bridges/source/cpp_uno/shared/vtablefactory.cxx +++ b/bridges/source/cpp_uno/shared/vtablefactory.cxx @@ -67,7 +67,6 @@ extern "C" void * allocExec( #if defined FREEBSD || defined NETBSD || defined OPENBSD || defined DRAGONFLY || defined HAIKU pagesize = getpagesize(); #else - // coverity[ tainted_data_return : FALSE ] version 2023.12.2 pagesize = sysconf(_SC_PAGESIZE); #endif #elif defined _WIN32 @@ -273,7 +272,6 @@ bool VtableFactory::createBlock(Block &block, sal_Int32 slotCount) const OString aTmpName = OUStringToOString(strDirectory, osl_getThreadTextEncoding()); std::unique_ptr<char[]> tmpfname(new char[aTmpName.getLength()+1]); strncpy(tmpfname.get(), aTmpName.getStr(), aTmpName.getLength()+1); - // coverity[secure_temp] - https://communities.coverity.com/thread/3179 if ((block.fd = mkstemp(tmpfname.get())) == -1) fprintf(stderr, "mkstemp(\"%s\") failed: %s ", tmpfname.get(), strerror(errno)); if (block.fd == -1) diff --git a/comphelper/source/misc/backupfilehelper.cxx b/comphelper/source/misc/backupfilehelper.cxx index 8548c4f3ff83..cc6c0c7637d9 100644 --- a/comphelper/source/misc/backupfilehelper.cxx +++ b/comphelper/source/misc/backupfilehelper.cxx @@ -707,8 +707,7 @@ namespace return false; } - // coverity#1373663 Untrusted loop bound, check file size - // isn't utterly broken + // Check that file size isn't utterly broken sal_uInt64 nFileSize(0); rFile->getSize(nFileSize); if (nFileSize < nExtEntries) diff --git a/comphelper/source/misc/storagehelper.cxx b/comphelper/source/misc/storagehelper.cxx index b504aef0be61..1540b16b8b7b 100644 --- a/comphelper/source/misc/storagehelper.cxx +++ b/comphelper/source/misc/storagehelper.cxx @@ -415,7 +415,6 @@ uno::Sequence< beans::NamedValue > OStorageHelper::CreatePackageEncryptionData( return aEncryptionData; } - // coverity[overrun-buffer-arg : FALSE] - coverity has difficulty with css::uno::Sequence pEncryptionData[nSha1Ind+nInd].Value <<= uno::Sequence< sal_Int8 >( reinterpret_cast<sal_Int8*>(pBuffer), RTL_DIGEST_LENGTH_SHA1 ); } diff --git a/cppu/source/helper/purpenv/helper_purpenv_Proxy.cxx b/cppu/source/helper/purpenv/helper_purpenv_Proxy.cxx index 16352fdac006..fc4f82daf07c 100644 --- a/cppu/source/helper/purpenv/helper_purpenv_Proxy.cxx +++ b/cppu/source/helper/purpenv/helper_purpenv_Proxy.cxx @@ -397,7 +397,6 @@ void Proxy::dispatch(typelib_TypeDescriptionReference * pReturnTypeRef, void * ret = pReturn; if (pReturnTypeRef) { - // coverity[freed_arg] - pReturnTypeRef's nRefCount is > 1 here TYPELIB_DANGER_GET(&return_td, pReturnTypeRef); if (relatesToInterface(return_td)) diff --git a/cppu/source/typelib/static_types.cxx b/cppu/source/typelib/static_types.cxx index c5af49b7164f..606d1441ad10 100644 --- a/cppu/source/typelib/static_types.cxx +++ b/cppu/source/typelib/static_types.cxx @@ -280,7 +280,7 @@ void SAL_CALL typelib_static_type_init( OUString aTypeName( OUString::createFromAscii( pTypeName ) ); ::typelib_typedescriptionreference_new( ppRef, eTypeClass, aTypeName.pData ); - assert(*ppRef && "coverity[var_deref_op] - shouldn't be possible"); + assert(*ppRef && "shouldn't be possible"); ++((*ppRef)->nStaticRefCount); } } @@ -427,7 +427,6 @@ void SAL_CALL typelib_static_interface_type_init( const char * pTypeName, typelib_TypeDescriptionReference * pBaseType ) noexcept { - // coverity[callee_ptr_arith] - not a bug typelib_static_mi_interface_type_init( ppRef, pTypeName, pBaseType == nullptr ? 0 : 1, &pBaseType); } diff --git a/cppu/source/typelib/typelib.cxx b/cppu/source/typelib/typelib.cxx index 034a1819db91..38119d9ee371 100644 --- a/cppu/source/typelib/typelib.cxx +++ b/cppu/source/typelib/typelib.cxx @@ -824,7 +824,6 @@ extern "C" void SAL_CALL typelib_typedescription_newInterface( sal_Int32 nMembers, typelib_TypeDescriptionReference ** ppMembers ) noexcept { - // coverity[callee_ptr_arith] - not a bug typelib_typedescription_newMIInterface( ppRet, pTypeName, 0, 0, 0, 0, 0, pBaseInterface == nullptr ? 0 : 1, &pBaseInterface, nMembers, ppMembers); @@ -1540,7 +1539,6 @@ extern "C" void SAL_CALL typelib_typedescription_register( { // switch from !OnDemand to OnDemand, so the description must be released assert(pTDR->pType->nRefCount > 1); - // coverity[freed_arg] - pType's nRefCount is > 1 here typelib_typedescription_release( pTDR->pType ); } diff --git a/cppu/source/uno/copy.hxx b/cppu/source/uno/copy.hxx index 10985a87a16f..cbe80e1c2ed8 100644 --- a/cppu/source/uno/copy.hxx +++ b/cppu/source/uno/copy.hxx @@ -465,7 +465,6 @@ inline uno_Sequence * icopyConstructSequence( } case typelib_TypeClass_SEQUENCE: // sequence of sequence { - // coverity[suspicious_sizeof] - sizeof(uno_Sequence*) is correct here pDest = allocSeq( sizeof (uno_Sequence *), nElements ); if (pDest != nullptr) { diff --git a/cppu/source/uno/data.cxx b/cppu/source/uno/data.cxx index e6279c8bfdbb..f218fe3e83fa 100644 --- a/cppu/source/uno/data.cxx +++ b/cppu/source/uno/data.cxx @@ -50,7 +50,6 @@ void * binuno_queryInterface( void * pUnoI, typelib_TypeDescriptionReference * p typelib_TypeDescription* pQITD = nullptr; typelib_typedescriptionreference_getDescription(&pQITD, pTXInterfaceDescr->ppAllMembers[0]); - // coverity[callee_ptr_arith] - not a bug TYPELIB_DANGER_RELEASE(&pTXInterfaceDescr->aBase); return pQITD; }(); diff --git a/cppu/source/uno/sequence.cxx b/cppu/source/uno/sequence.cxx index e249f7549780..b756c111920c 100644 --- a/cppu/source/uno/sequence.cxx +++ b/cppu/source/uno/sequence.cxx @@ -274,7 +274,6 @@ static bool idefaultConstructElements( { if (nAlloc >= 0) { - // coverity[suspicious_sizeof : FALSE] - sizeof(uno_Sequence*) is correct here pSeq = reallocSeq(pSeq, sizeof(uno_Sequence*), nAlloc); } if (pSeq != nullptr) @@ -314,7 +313,7 @@ static bool idefaultConstructElements( return true; } -// coverity[ -tainted_data_sink : arg-1 ] +// coverity[ -tainted_data_sink : arg-1 ] 2024.6.1 static bool icopyConstructFromElements( uno_Sequence ** ppSeq, void * pSourceElements, typelib_TypeDescriptionReference * pElementType, @@ -426,8 +425,6 @@ static bool icopyConstructFromElements( rtl_uString ** pDestElements = reinterpret_cast<rtl_uString **>(pSeq->elements); for ( sal_Int32 nPos = 0; nPos < nStopIndex; ++nPos ) { - // This code tends to trigger coverity's overrun-buffer-arg warning - // coverity[index_parm_via_loop_bound] - https://communities.coverity.com/thread/2993 ::rtl_uString_acquire( static_cast<rtl_uString **>(pSourceElements)[nPos] ); pDestElements[nPos] = static_cast<rtl_uString **>(pSourceElements)[nPos]; @@ -526,7 +523,6 @@ static bool icopyConstructFromElements( } case typelib_TypeClass_SEQUENCE: // sequence of sequence { - // coverity[suspicious_sizeof : FALSE] - sizeof(uno_Sequence*) is correct here pSeq = reallocSeq(pSeq, sizeof(uno_Sequence*), nAlloc); if (pSeq != nullptr) { commit 6d1841c1e60e2215910e10a4a0f61ce1e6bee547 Author: Caolán McNamara <[email protected]> AuthorDate: Fri Aug 15 08:36:33 2025 +0100 Commit: Caolán McNamara <[email protected]> CommitDate: Fri Aug 15 11:25:05 2025 +0200 cid#1664055 Variable copied when it could be moved Change-Id: I6dcdb52011ad3461cb34209ae1429d35c5450866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189661 Tested-by: Caolán McNamara <[email protected]> Reviewed-by: Caolán McNamara <[email protected]> diff --git a/drawinglayer/source/processor2d/cairopixelprocessor2d.cxx b/drawinglayer/source/processor2d/cairopixelprocessor2d.cxx index 7151f4ec7bb4..e73250819007 100644 --- a/drawinglayer/source/processor2d/cairopixelprocessor2d.cxx +++ b/drawinglayer/source/processor2d/cairopixelprocessor2d.cxx @@ -1217,7 +1217,7 @@ Bitmap CairoPixelProcessor2D::extractBitmap() const } // construct and return Bitmap - aRetval = aBitmap; + aRetval = std::move(aBitmap); if (pReadSource != pSource) {
