Hi,
this patch fixes
https://bugs.freedesktop.org/show_bug.cgi?id=51231
"UI: Slide thumbnail overlay "start presentation, disable slide, copy
slide" position depends on slides pane scroll slider position and mouse way"
where "depends on slides pane scroll slider position" is a bug, but "and
mouse way" is a feature:
http://cgit.freedesktop.org/libreoffice/core/commit/?id=4866b20ec6205b04cd21077fd00d68c4d4bb2c1b
But (don't cast stones at me) could we revert this feature?
IMHO it only creates the nervous tension: "oh, where this black thing
would appear now?".
My usual mouse movements are sweeping, and if I entered a (quite small)
slide preview at the bottom, it does not mean that I will stop and click
immediately at the bottom.
If you disagree with me and want this feature staying in - just push my
patch to master and 3-6, it fixes a MAB. :)
Cheers,
Ivan
>From 8aa577a7472c7e5b3da9f9c0f093c98f372e9440 Mon Sep 17 00:00:00 2001
From: Ivan Timofeev <timofeev....@gmail.com>
Date: Sun, 29 Jul 2012 14:47:35 +0400
Subject: [PATCH] fdo#51231: mouse position must be in logic slidesorter
window coordinates
Change-Id: I658bbd937c028ad2b4dc906d86d85e168320a8c0
---
sd/source/ui/slidesorter/view/SlideSorterView.cxx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sd/source/ui/slidesorter/view/SlideSorterView.cxx b/sd/source/ui/slidesorter/view/SlideSorterView.cxx
index 711a0f6..0fd3401 100644
--- a/sd/source/ui/slidesorter/view/SlideSorterView.cxx
+++ b/sd/source/ui/slidesorter/view/SlideSorterView.cxx
@@ -955,13 +955,13 @@ void SlideSorterView::UpdatePageUnderMouse (
const bool bIsMouseButtonDown,
const bool bAnimate)
{
- // Update the page under the mouse.
- SetPageUnderMouse(rpDescriptor, bAnimate, rMousePosition);
-
// Tell the button bar about the new mouse position.
SharedSdWindow pWindow (mrSlideSorter.GetContentWindow());
const Point aMouseModelPosition (pWindow->PixelToLogic(rMousePosition));
+ // Update the page under the mouse.
+ SetPageUnderMouse(rpDescriptor, bAnimate, aMouseModelPosition);
+
::boost::shared_ptr<ViewShell> pMainViewShell (mrSlideSorter.GetViewShellBase()->GetMainViewShell());
if (pMainViewShell
&& pMainViewShell->GetShellType()!=ViewShell::ST_DRAW)
--
1.7.11.3
_______________________________________________
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
