Hi,
Please find the latest report on new defect(s) introduced to LibreOffice found
with Coverity Scan.
2 new defect(s) introduced to LibreOffice found with Coverity Scan.
6 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent
build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 2 of 2 defect(s)
** CID 1665199: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
_____________________________________________________________________________________________
*** CID 1665199: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
/vcl/source/image/Image.cxx: 165 in Image::Draw(OutputDevice *,
const Point &, DrawImageFlags, const Size *) const()
159 }
160 else
161 {
162 sal_uInt8 cErase = 128;
163 aTempBitmap = Bitmap(aTempBitmap,
AlphaMask(aTempBitmap.GetSizePixel(), &cErase));
164 }
>>> CID 1665199: Performance inefficiencies (COPY_INSTEAD_OF_MOVE)
>>> "aTempBitmap" is copied in call to copy assignment for class "Bitmap",
>>> when it could be moved instead.
165 aRenderBmp = aTempBitmap;
166 }
167 }
168
169 pOutDev->DrawBitmapEx(rPos, aOutSize, aRenderBmp);
170 }
171
** CID 1665198: (DEADCODE)
/canvas/source/vcl/canvashelper.cxx: 958 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
/canvas/source/vcl/canvashelper.cxx: 967 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
/canvas/source/vcl/canvashelper.cxx: 947 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
_____________________________________________________________________________________________
*** CID 1665198: (DEADCODE)
/canvas/source/vcl/canvashelper.cxx: 958 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
952 case FILL_COLOR:
953 rOutDev.SetFillColor( aColor );
954 rOutDev.SetLineColor();
955
956 if( p2ndOutDev )
957 {
>>> CID 1665198: (DEADCODE)
>>> Execution cannot reach this statement: "p2ndOutDev->SetFillColor(aC...".
958 p2ndOutDev->SetFillColor( aColor );
959 p2ndOutDev->SetLineColor();
960 }
961 break;
962
963 case TEXT_COLOR:
/canvas/source/vcl/canvashelper.cxx: 967 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
961 break;
962
963 case TEXT_COLOR:
964 rOutDev.SetTextColor( aColor );
965
966 if( p2ndOutDev )
>>> CID 1665198: (DEADCODE)
>>> Execution cannot reach this statement: "p2ndOutDev->SetTextColor(aC...".
967 p2ndOutDev->SetTextColor( aColor );
968 break;
969
970 default:
971 ENSURE_OR_THROW( false,
972 "Unexpected color type");
/canvas/source/vcl/canvashelper.cxx: 947 in
vclcanvas::CanvasHelper::setupOutDevState(const
com::sun::star::rendering::ViewState &, const
com::sun::star::rendering::RenderState &, vclcanvas::CanvasHelper::ColorType)
const()
941 case LINE_COLOR:
942 rOutDev.SetLineColor( aColor );
943 rOutDev.SetFillColor();
944
945 if( p2ndOutDev )
946 {
>>> CID 1665198: (DEADCODE)
>>> Execution cannot reach this statement: "p2ndOutDev->SetLineColor(aC...".
947 p2ndOutDev->SetLineColor( aColor );
948 p2ndOutDev->SetFillColor();
949 }
950 break;
951
952 case FILL_COLOR:
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/libreoffice?tab=overview
