chart2/IwyuFilter_chart2.yaml | 21 --------------------- configmgr/IwyuFilter_configmgr.yaml | 3 --- forms/IwyuFilter_forms.yaml | 3 --- framework/IwyuFilter_framework.yaml | 6 ------ include/IwyuFilter_include.yaml | 12 ------------ sc/IwyuFilter_sc.yaml | 3 --- sd/IwyuFilter_sd.yaml | 12 ------------ slideshow/IwyuFilter_slideshow.yaml | 3 --- stoc/IwyuFilter_stoc.yaml | 3 --- sw/IwyuFilter_sw.yaml | 8 -------- xmloff/IwyuFilter_xmloff.yaml | 12 ------------ 11 files changed, 86 deletions(-)
New commits: commit e505e066b5286e302e66685c1026de7248b61b2e Author: Gabor Kelemen <[email protected]> AuthorDate: Wed Sep 24 22:55:14 2025 +0200 Commit: Gabor Kelemen <[email protected]> CommitDate: Thu Oct 2 15:55:20 2025 +0200 Drop IWYU exclusions about css shortcut At least IWYU 0.24 no longer gives a warning if sal/types.h is included only for the css alias Few other places were excluded because an enum type used some base type from sal/types.h Now there is no false warning about those instances either, so drop them too Change-Id: Ib2fac8fe2c7022c28194514e828c773385217ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191564 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <[email protected]> diff --git a/chart2/IwyuFilter_chart2.yaml b/chart2/IwyuFilter_chart2.yaml index dbd273e1fb17..55b485ae1f0b 100644 --- a/chart2/IwyuFilter_chart2.yaml +++ b/chart2/IwyuFilter_chart2.yaml @@ -676,27 +676,6 @@ excludelist: - WrappedPropertySet.hxx - com/sun/star/lang/XComponent.hpp - com/sun/star/lang/XServiceInfo.hpp - chart2/source/controller/chartapiwrapper/WrappedAutomaticPositionProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedDataCaptionProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedScaleTextProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedSplineProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h - chart2/source/controller/chartapiwrapper/WrappedStockProperties.hxx: - # Needed for css namespace shortcut - - sal/types.h chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx: # Needed for implicit dtor - RegressionCurveModel.hxx diff --git a/configmgr/IwyuFilter_configmgr.yaml b/configmgr/IwyuFilter_configmgr.yaml index 5cb79e6ae069..ba31283931f0 100644 --- a/configmgr/IwyuFilter_configmgr.yaml +++ b/configmgr/IwyuFilter_configmgr.yaml @@ -4,9 +4,6 @@ excludelist: configmgr/source/nodemap.hxx: # Needed for direct member access - node.hxx - configmgr/source/type.hxx: - # Needed for css shortcut - - sal/types.h configmgr/source/access.cxx: # Safer to keep for use in cppu:UnoType template - com/sun/star/uno/XWeak.hpp diff --git a/forms/IwyuFilter_forms.yaml b/forms/IwyuFilter_forms.yaml index 432373604333..83fab9586854 100644 --- a/forms/IwyuFilter_forms.yaml +++ b/forms/IwyuFilter_forms.yaml @@ -7,9 +7,6 @@ excludelist: forms/inc/strings.hrc: # Needed for TranslateId macro - unotools/resmgr.hxx - forms/source/xforms/unohelper.hxx: - # Needed for css shortcut - - sal/types.h forms/source/xforms/datatypes.hxx: # Needed for macro defines - com/sun/star/beans/PropertyAttribute.hpp diff --git a/framework/IwyuFilter_framework.yaml b/framework/IwyuFilter_framework.yaml index e2c1a2ef3d4a..4b28ab478bff 100644 --- a/framework/IwyuFilter_framework.yaml +++ b/framework/IwyuFilter_framework.yaml @@ -1,12 +1,6 @@ --- assumeFilename: framework/source/services/autorecovery.cxx excludelist: - framework/inc/statusbarconfiguration.hxx: - # Needed for css shortcut - - sal/types.h - framework/inc/toolboxconfiguration.hxx: - # Needed for css shortcut - - sal/types.h framework/source/dispatch/closedispatcher.cxx: # Needed on MAC - com/sun/star/beans/XFastPropertySet.hpp diff --git a/include/IwyuFilter_include.yaml b/include/IwyuFilter_include.yaml index 4bf618a38a78..92b39eb60d7f 100644 --- a/include/IwyuFilter_include.yaml +++ b/include/IwyuFilter_include.yaml @@ -47,9 +47,6 @@ excludelist: # the unstable API needs C99's bool - stdbool.h - stdint.h - include/sfx2/toolbarids.hxx: - # needed for enum definition - - sal/types.h include/cppuhelper/compbase1.hxx: # Needed for template functions - cppuhelper/implbase1.hxx @@ -240,9 +237,6 @@ excludelist: - com/sun/star/lang/IllegalArgumentException.hpp - com/sun/star/uno/RuntimeException.hpp - rtl/ustring.hxx - include/tools/fldunit.hxx: - # Needed for enum type - - sal/types.h include/tools/long.hxx: # Needed on _WIN64 - sal/types.h @@ -712,12 +706,6 @@ excludelist: # base class has to be a complete type - com/sun/star/lang/XServiceInfo.hpp - com/sun/star/sheet/XFormulaOpCodeMapper.hpp - include/formula/paramclass.hxx: - # Needed for enum type - - sal/types.h - include/formula/opcode.hxx: - # Needed for enum type - - sal/types.h include/formula/tokenarray.hxx: # Needed to avoid linking errors on WIN - formula/ExternalReferenceHelper.hxx diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml index cdf091a2b2d1..e0819eb76e66 100644 --- a/sc/IwyuFilter_sc.yaml +++ b/sc/IwyuFilter_sc.yaml @@ -372,9 +372,6 @@ excludelist: sc/qa/unit/ucalc_sort.cxx: # Needed for namespace shortcuts - helper/debughelper.hxx - sc/qa/unit/functions_test.hxx: - # Needed for css shortcut - - sal/types.h sc/qa/unit/screenshots/screenshots.cxx: # Needed for template - sfx2/sfxdlg.hxx diff --git a/sd/IwyuFilter_sd.yaml b/sd/IwyuFilter_sd.yaml index 21b76f138c28..2baad50f2fc6 100644 --- a/sd/IwyuFilter_sd.yaml +++ b/sd/IwyuFilter_sd.yaml @@ -106,9 +106,6 @@ excludelist: # Needed on MACOSX - svl/intitem.hxx - app.hrc - sd/source/ui/framework/configuration/ConfigurationTracer.hxx: - # Needed for css shortcut - - sal/types.h sd/source/ui/framework/configuration/GenericConfigurationChangeRequest.hxx: # base class has to be a complete type - com/sun/star/container/XNamed.hpp @@ -201,12 +198,6 @@ excludelist: sd/source/ui/inc/framework/ConfigurationController.hxx: # base class has to be a complete type - com/sun/star/lang/XInitialization.hpp - sd/source/ui/inc/framework/DrawModule.hxx: - # Needed for css shortcut - - sal/types.h - sd/source/ui/inc/framework/ImpressModule.hxx: - # Needed for css shortcut - - sal/types.h sd/source/ui/inc/framework/ModuleController.hxx: # base class has to be a complete type - com/sun/star/lang/XInitialization.hpp @@ -214,9 +205,6 @@ excludelist: # base class has to be a complete type - com/sun/star/drawing/framework/AbstractPane.hpp - com/sun/star/lang/XUnoTunnel.hpp - sd/source/ui/inc/framework/PresentationModule.hxx: - # Needed for css shortcut - - sal/types.h sd/source/ui/inc/framework/ViewShellWrapper.hxx: # base class has to be a complete type - com/sun/star/awt/XWindowListener.hpp diff --git a/slideshow/IwyuFilter_slideshow.yaml b/slideshow/IwyuFilter_slideshow.yaml index 92f41bc23ba2..6581db9743fb 100644 --- a/slideshow/IwyuFilter_slideshow.yaml +++ b/slideshow/IwyuFilter_slideshow.yaml @@ -1,9 +1,6 @@ --- assumeFilename: slideshow/source/engine/slideshowimpl.cxx excludelist: - slideshow/source/inc/mouseeventhandler.hxx: - # Needed for css shortcut - - sal/types.h slideshow/source/engine/opengl/Operation.hxx: # Needed for licensing - config_lgpl.h diff --git a/stoc/IwyuFilter_stoc.yaml b/stoc/IwyuFilter_stoc.yaml index 5b046e4da1e4..ba4859595a0c 100644 --- a/stoc/IwyuFilter_stoc.yaml +++ b/stoc/IwyuFilter_stoc.yaml @@ -1,9 +1,6 @@ --- assumeFilename: stoc/source/javavm/javavm.cxx excludelist: - stoc/source/implementationregistration/mergekeys.hxx: - # Needed for css shortcut - - sal/types.h stoc/source/javavm/interact.hxx: # Base class needs complete type - com/sun/star/task/XInteractionRequest.hpp diff --git a/sw/IwyuFilter_sw.yaml b/sw/IwyuFilter_sw.yaml index 3ec155280cd9..0b7671bd5e43 100644 --- a/sw/IwyuFilter_sw.yaml +++ b/sw/IwyuFilter_sw.yaml @@ -47,8 +47,6 @@ excludelist: sw/inc/swtypes.hxx: # Needed for macro #define - com/sun/star/i18n/CollatorOptions.hpp - sw/inc/IDocumentLinksAdministration.hxx: - - sal/types.h sw/inc/pagedesc.hxx: - boost/multi_index/identity.hpp sw/inc/rdfhelper.hxx: @@ -76,9 +74,6 @@ excludelist: # inline dtor, complete type is needed - com/sun/star/linguistic2/XSpellAlternatives.hpp - com/sun/star/linguistic2/XSpellChecker1.hpp - sw/inc/SwGetPoolIdFromName.hxx: - # Needed for enum type - - sal/types.h sw/inc/unocoll.hxx: # base class has to be a complete type - com/sun/star/container/XEnumerationAccess.hpp @@ -301,9 +296,6 @@ excludelist: - com/sun/star/beans/XPropertySet.hpp - com/sun/star/beans/XPropertyState.hpp - com/sun/star/lang/XServiceInfo.hpp - sw/source/core/inc/swthreadjoiner.hxx: - # Needed for css shortcut - - sal/types.h sw/source/core/inc/unobookmark.hxx: # Base class needs complete type - com/sun/star/lang/XUnoTunnel.hpp diff --git a/xmloff/IwyuFilter_xmloff.yaml b/xmloff/IwyuFilter_xmloff.yaml index 356b76dac5bb..ca80111de9bd 100644 --- a/xmloff/IwyuFilter_xmloff.yaml +++ b/xmloff/IwyuFilter_xmloff.yaml @@ -1,15 +1,6 @@ --- assumeFilename: xmloff/source/core/xmlexp.cxx excludelist: - xmloff/inc/DomExport.hxx: - # Needed for css shortcut - - sal/types.h - xmloff/inc/XMLImageMapExport.hxx: - # Needed for css shortcut - - sal/types.h - xmloff/inc/XMLTextColumnsExport.hxx: - # Needed for css shortcut - - sal/types.h xmloff/source/forms/logging.hxx: # Used after #ifdef TIMELOG - stack @@ -18,9 +9,6 @@ excludelist: xmloff/source/forms/propertyexport.hxx: # Used after #ifdef in non-DBG_UTIL builds - xmloff/xmlexp.hxx - xmloff/source/xforms/XFormsModelExport.hxx: - # Needed for css shortcut - - sal/types.h xmloff/source/chart/SchXMLCalculationSettingsContext.cxx: # Complete type is needed - com/sun/star/frame/XModel.hpp
